2 # -*- coding: utf-8 -*-
4 # lint.py - part of the FDroid server tool
5 # Copyright (C) 2013-2014 Daniel Martà <mvdan@mvdan.cc>
7 # This program is free software: you can redistribute it and/or modify
8 # it under the terms of the GNU Affero General Public License as published by
9 # the Free Software Foundation, either version 3 of the License, or
10 # (at your option) any later version.
12 # This program is distributed in the hope that it will be useful,
13 # but WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See th
15 # GNU Affero General Public License for more details.
17 # You should have received a copy of the GNU Affero General Public Licen
18 # along with this program. If not, see <http://www.gnu.org/licenses/>.
20 from argparse import ArgumentParser
31 def enforce_https(domain):
32 return (re.compile(r'.*[^sS]://[^/]*' + re.escape(domain) + r'(/.*)?'),
33 domain + " URLs should always use https://")
36 enforce_https('github.com'),
37 enforce_https('gitlab.com'),
38 enforce_https('bitbucket.org'),
39 enforce_https('apache.org'),
40 enforce_https('google.com'),
41 enforce_https('svn.code.sf.net'),
45 def forbid_shortener(domain):
46 return (re.compile(r'https?://[^/]*' + re.escape(domain) + r'/.*'),
47 "URL shorteners should not be used")
49 http_url_shorteners = [
50 forbid_shortener('goo.gl'),
51 forbid_shortener('t.co'),
52 forbid_shortener('ur1.ca'),
55 http_checks = https_enforcings + http_url_shorteners + [
56 (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
57 "Appending .git is not necessary"),
58 (re.compile(r'(.*/blob/master/|.*raw\.github.com/[^/]*/[^/]*/master/)'),
59 "Use /HEAD/ instead of /master/ to point at a file in the default branch"),
63 'Web Site': http_checks + [
65 'Source Code': http_checks + [
67 'Repo': https_enforcings + [
69 'Issue Tracker': http_checks + [
70 (re.compile(r'.*github\.com/[^/]+/[^/]+[/]*$'),
71 "/issues is missing"),
73 'Donate': http_checks + [
74 (re.compile(r'.*flattr\.com'),
75 "Flattr donation methods belong in the FlattrID flag"),
77 'Changelog': http_checks + [
80 (re.compile(r'^(|None|Unknown)$'),
81 "No license specified"),
85 "Summary yet to be filled"),
86 (re.compile(r'.*\b(free software|open source)\b.*', re.IGNORECASE),
87 "No need to specify that the app is Free Software"),
88 (re.compile(r'.*((your|for).*android|android.*(app|device|client|port|version))', re.IGNORECASE),
89 "No need to specify that the app is for Android"),
90 (re.compile(r'.*[a-z0-9][.!?]( |$)'),
91 "Punctuation should be avoided"),
94 (re.compile(r'^No description available$'),
95 "Description yet to be filled"),
96 (re.compile(r'\s*[*#][^ .]'),
97 "Invalid bulleted list"),
99 "Unnecessary leading space"),
100 (re.compile(r'.*\s$'),
101 "Unnecessary trailing space"),
102 (re.compile(r'.*([^[]|^)\[[^:[\]]+( |\]|$)'),
103 "Invalid link - use [http://foo.bar Link title] or [http://foo.bar]"),
104 (re.compile(r'.*[^[]https?://[^ ]+'),
105 "Unlinkified link - use [http://foo.bar Link title] or [http://foo.bar]"),
110 def check_regexes(app):
111 for f, checks in regex_checks.iteritems():
118 yield "%s '%s': %s" % (f, v, r)
119 elif type(v) == list:
122 yield "%s at line '%s': %s" % (f, l, r)
124 desc_url = re.compile("[^[]\[([^ ]+)( |\]|$)")
127 def get_lastbuild(builds):
131 if not build['disable']:
132 vercode = int(build['vercode'])
133 if lowest_vercode == -1 or vercode < lowest_vercode:
134 lowest_vercode = vercode
135 if not lastbuild or int(build['vercode']) > int(lastbuild['vercode']):
140 def check_ucm_tags(app):
141 lastbuild = get_lastbuild(app['builds'])
142 if (lastbuild is not None
143 and lastbuild['commit']
144 and app['Update Check Mode'] == 'RepoManifest'
145 and not lastbuild['commit'].startswith('unknown')
146 and lastbuild['vercode'] == app['Current Version Code']
147 and not lastbuild['forcevercode']
148 and any(s in lastbuild['commit'] for s in '.,_-/')):
149 yield "Last used commit '%s' looks like a tag, but Update Check Mode is '%s'" % (
150 lastbuild['commit'], app['Update Check Mode'])
153 def check_char_limits(app):
154 limits = config['char_limits']
156 summ_chars = len(app['Summary'])
157 if summ_chars > limits['Summary']:
158 yield "Summary of length %s is over the %i char limit" % (
159 summ_chars, limits['Summary'])
161 desc_charcount = sum(len(l) for l in app['Description'])
162 if desc_charcount > limits['Description']:
163 yield "Description of length %s is over the %i char limit" % (
164 desc_charcount, limits['Description'])
167 def check_old_links(app):
177 if any(s in app['Repo'] for s in usual_sites):
178 for f in ['Web Site', 'Source Code', 'Issue Tracker', 'Changelog']:
179 if any(s in app[f] for s in old_sites):
180 yield "App is in '%s' but has a link to '%s'" % (app['Repo'], app[f])
183 def check_useless_fields(app):
184 if app['Update Check Name'] == app['id']:
185 yield "Update Check Name is set to the known app id - it can be removed"
187 filling_ucms = re.compile('^(Tags.*|RepoManifest.*)')
190 def check_checkupdates_ran(app):
191 if filling_ucms.match(app['Update Check Mode']):
192 if all(app[f] == metadata.app_defaults[f] for f in [
195 'Current Version Code',
197 yield "UCM is set but it looks like checkupdates hasn't been run yet"
200 def check_empty_fields(app):
201 if not app['Categories']:
202 yield "Categories are not set"
204 all_categories = Set([
215 "Science & Education",
225 def check_categories(app):
226 for categ in app['Categories']:
227 if categ not in all_categories:
228 yield "Category '%s' is not valid" % categ
231 def check_duplicates(app):
232 if app['Web Site'] and app['Source Code']:
233 if app['Web Site'].lower() == app['Source Code'].lower():
234 yield "Website '%s' is just the app's source code link" % app['Web Site']
236 if app['Name'] and app['Name'] == app['Auto Name']:
237 yield "Name '%s' is just the auto name" % app['Name']
239 name = app['Name'] or app['Auto Name']
240 if app['Summary'] and name:
241 if app['Summary'].lower() == name.lower():
242 yield "Summary '%s' is just the app's name" % app['Summary']
244 desc = app['Description']
245 if app['Summary'] and desc and len(desc) == 1:
246 if app['Summary'].lower() == desc[0].lower():
247 yield "Description '%s' is just the app's summary" % app['Summary']
250 for l in app['Description']:
254 yield "Description has a duplicate line"
258 def check_text_wrap(app):
260 for l in app['Description']:
261 if any(l.startswith(c) for c in ['*', '#']):
263 if any(len(w) > maxcols for w in l.split(' ')):
266 yield "Description should be wrapped to 80-120 chars"
270 def check_mediawiki_links(app):
271 for l in app['Description']:
272 for um in desc_url.finditer(l):
274 for m, r in http_checks:
276 yield "URL '%s' in Description: %s" % (url, r)
279 def check_extra_spacing(app):
280 desc = app['Description']
281 if (not desc[0] or not desc[-1]
282 or any(not desc[l - 1] and not desc[l] for l in range(1, len(desc)))):
283 yield "Description has an extra empty line"
286 def check_bulleted_lists(app):
287 validchars = ['*', '#']
290 for l in app['Description']:
295 if l[0] == lchar and l[1] == ' ':
297 if lcount > 2 and lchar not in validchars:
298 yield "Description has a list (%s) but it isn't bulleted (*) nor numbered (#)" % lchar
305 def check_builds(app):
306 for build in app['builds']:
309 for s in ['master', 'origin', 'HEAD', 'default', 'trunk']:
310 if build['commit'] and build['commit'].startswith(s):
311 yield "Branch '%s' used as commit in build '%s'" % (s, build['version'])
312 for srclib in build['srclibs']:
313 ref = srclib.split('@')[1].split('/')[0]
314 if ref.startswith(s):
315 yield "Branch '%s' used as commit in srclib '%s'" % (s, srclib)
320 global config, options
324 # Parse command line...
325 parser = ArgumentParser(usage="%(prog)s [options] [APPID [APPID ...]]")
326 parser.add_argument("appid", nargs='*', help="app-id in the form APPID")
327 parser.add_argument("-v", "--verbose", action="store_true", default=False,
328 help="Spew out even more information than normal")
329 parser.add_argument("-q", "--quiet", action="store_true", default=False,
330 help="Restrict output to warnings and errors")
331 options = parser.parse_args()
333 config = common.read_config(options)
336 allapps = metadata.read_metadata(xref=True)
337 apps = common.read_app_args(options.appid, allapps, False)
339 for appid, app in apps.iteritems():
350 check_checkupdates_ran,
351 check_useless_fields,
356 check_mediawiki_links,
358 check_bulleted_lists,
361 warns += check_func(app)
366 print "%s: %s" % (appid, warn)
372 if __name__ == "__main__":