2 # -*- coding: utf-8 -*-
4 # lint.py - part of the FDroid server tool
5 # Copyright (C) 2013-2014 Daniel Martà <mvdan@mvdan.cc>
7 # This program is free software: you can redistribute it and/or modify
8 # it under the terms of the GNU Affero General Public License as published by
9 # the Free Software Foundation, either version 3 of the License, or
10 # (at your option) any later version.
12 # This program is distributed in the hope that it will be useful,
13 # but WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See th
15 # GNU Affero General Public License for more details.
17 # You should have received a copy of the GNU Affero General Public Licen
18 # along with this program. If not, see <http://www.gnu.org/licenses/>.
20 from optparse import OptionParser
25 from collections import Counter
32 (re.compile(r'.*[^sS]://github\.com/.*'),
33 "github URLs should always use https:// not http://"),
34 # TODO enable in August 2015, when Google Code goes read-only
35 # (re.compile(r'.*://code\.google\.com/.*'),
36 # "code.google.com will be soon switching down, perhaps it moved to github.com?"),
39 (re.compile(r'.*[^sS]://github\.com/.*'),
40 "github URLs should always use https:// (not http://, git://, or git@)"),
41 (re.compile(r'.*[^sS]://dl\.google\.com/.*'),
42 "dl.google.com URLs should always use https:// not http://"),
43 (re.compile(r'.*[^sS]://gitorious\.org/.*'),
44 "gitorious URLs should always use https:// (not http://, git://, or git@)"),
45 # TODO enable in August 2015, when Google Code goes read-only
46 # (re.compile(r'.*://code\.google\.com/.*'),
47 # "code.google.com will be soon switching down, perhaps it moved to github.com?"),
50 (re.compile(r'.*[^sS]://dl\.google\.com/.*'),
51 "dl.google.com URLs should always use https:// not http://"),
52 (re.compile(r'.*[^sS]://github\.com/.*'),
53 "github URLs should always use https:// (not http://, git://, or git@)"),
54 (re.compile(r'.*[^sS]://gitorious\.org/.*'),
55 "gitorious URLs should always use https:// (not http://, git://, or git@)"),
56 (re.compile(r'.*[^sS]://[^.]*\.googlecode\.com/svn/?.*'),
57 "Google Code SVN URLs should always use https:// (not http:// or svn://)"),
58 (re.compile(r'.*[^sS]://svn\.apache\.org/repos/?.*'),
59 "Apache SVN URLs should always use https:// (not http:// or svn://)"),
60 (re.compile(r'.*[^sS]://svn\.code\.sf\.net/.*'),
61 "Sourceforge SVN URLs should always use https:// (not http:// or svn://)"),
62 # TODO enable in August 2015, when Google Code goes read-only
63 # (re.compile(r'.*://code\.google\.com/.*'),
64 # "code.google.com will be soon switching down, perhaps it moved to github.com?"),
67 (re.compile(r'.*github\.com/[^/]+/[^/]+[/]*$'),
68 "/issues is missing"),
69 (re.compile(r'.*[^sS]://github\.com/.*'),
70 "github URLs should always use https:// not http://"),
71 (re.compile(r'.*[^sS]://gitorious\.org/.*'),
72 "gitorious URLs should always use https:// not http://"),
73 # TODO enable in August 2015, when Google Code goes read-only
74 # (re.compile(r'.*://code\.google\.com/.*'),
75 # "code.google.com will be soon switching down, perhaps it moved to github.com?"),
78 (re.compile(r'.*[^sS]://code\.google\.com/.*'),
79 "code.google.com URLs should always use https:// not http://"),
80 (re.compile(r'.*[^sS]://github\.com/.*'),
81 "github URLs should always use https:// not http://"),
82 (re.compile(r'.*[^sS]://gitorious\.org/.*'),
83 "gitorious URLs should always use https:// not http://"),
86 (re.compile(r'^(|None|Unknown)$'),
87 "No license specified"),
91 "Summary yet to be filled"),
92 (re.compile(r'.*\b(free software|open source)\b.*', re.IGNORECASE),
93 "No need to specify that the app is Free Software"),
94 (re.compile(r'.*((your|for).*android|android.*(app|device|client|port|version))', re.IGNORECASE),
95 "No need to specify that the app is for Android"),
98 (re.compile(r'^No description available$'),
99 "Description yet to be filled"),
100 (re.compile(r'\s*[*#][^ .]'),
101 "Invalid bulleted list"),
103 "Unnecessary leading space"),
104 (re.compile(r'.*\s$'),
105 "Unnecessary trailing space"),
111 (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
112 "Appending .git is not necessary"),
115 (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
116 "Appending .git is not necessary"),
119 (re.compile(r'^http://.*'),
120 "use https:// if available"),
121 (re.compile(r'^svn://.*'),
122 "use https:// if available"),
125 (re.compile(r'.*github\.com/[^/]+/[^/]+/issues/.*'),
126 "/issues is often enough on its own"),
129 (re.compile(r'.*[a-z0-9][.!?][ $]'),
130 "Punctuation should be avoided"),
137 global config, options, curid, count
148 print ' %s' % message
155 # Parse command line...
156 parser = OptionParser(usage="Usage: %prog [options] [APPID [APPID ...]]")
157 parser.add_option("-v", "--verbose", action="store_true", default=False,
158 help="Spew out even more information than normal")
159 parser.add_option("-q", "--quiet", action="store_true", default=False,
160 help="Restrict output to warnings and errors")
161 parser.add_option("-p", "--pedantic", action="store_true", default=False,
162 help="Show pedantic warnings that might give false positives")
163 (options, args) = parser.parse_args()
165 config = common.read_config(options)
168 allapps = metadata.read_metadata(xref=False)
169 apps = common.read_app_args(args, allapps, False)
171 for appid, app in apps.iteritems():
176 count['app_total'] += 1
179 for build in app['builds']:
180 if not curbuild or int(build['vercode']) > int(curbuild['vercode']):
183 # Potentially incorrect UCM
184 if (curbuild and curbuild['commit']
185 and app['Update Check Mode'] == 'RepoManifest'
186 and curbuild['commit'] != 'unknown - see disabled'
187 and any(s in curbuild['commit'] for s in '.,_-/')):
188 pwarn("Last used commit '%s' looks like a tag, but Update Check Mode is '%s'" % (
189 curbuild['commit'], app['Update Check Mode']))
191 # Dangerous auto updates
192 if curbuild and app['Auto Update Mode'] != 'None':
193 for flag in ['target', 'srclibs', 'scanignore']:
195 pwarn("Auto Update Mode is enabled but '%s' is manually set at '%s'" % (flag, curbuild[flag]))
198 summ_chars = len(app['Summary'])
199 if summ_chars > config['char_limits']['Summary']:
200 warn("Summary of length %s is over the %i char limit" % (
201 summ_chars, config['char_limits']['Summary']))
204 if app['Web Site'] and app['Source Code']:
205 if app['Web Site'].lower() == app['Source Code'].lower():
206 warn("Website '%s' is just the app's source code link" % app['Web Site'])
208 # "None" still a category
209 if 'None' in app['Categories']:
210 warn("Category 'None' is is still present")
211 elif not app['Categories']:
212 warn("Categories are not set")
214 name = app['Name'] or app['Auto Name']
215 if app['Summary'] and name:
216 if app['Summary'].lower() == name.lower():
217 warn("Summary '%s' is just the app's name" % app['Summary'])
219 desc = app['Description']
220 if app['Summary'] and desc and len(desc) == 1:
221 if app['Summary'].lower() == desc[0].lower():
222 warn("Description '%s' is just the app's summary" % app['Summary'])
224 # Description size limit
225 desc_charcount = sum(len(l) for l in desc)
226 if desc_charcount > config['char_limits']['Description']:
227 warn("Description of length %s is over the %i char limit" % (
228 desc_charcount, config['char_limits']['Description']))
230 if (not desc[0] or not desc[-1]
231 or any(not desc[l - 1] and not desc[l] for l in range(1, len(desc)))):
232 warn("Description has an extra empty line")
234 # Regex checks in all kinds of fields
235 for f in regex_warnings:
236 for m, r in regex_warnings[f]:
237 t = metadata.metafieldtype(f)
240 warn("%s '%s': %s" % (f, app[f], r))
241 elif t == 'multiline':
244 warn("%s at line '%s': %s" % (f, l, r))
246 # Regex pedantic checks in all kinds of fields
248 for f in regex_pedantic:
249 for m, r in regex_pedantic[f]:
251 warn("%s '%s': %s" % (f, app[f], r))
254 for build in app['builds']:
257 for s in ['master', 'origin', 'HEAD', 'default', 'trunk']:
258 if build['commit'] and build['commit'].startswith(s):
259 warn("Branch '%s' used as commit in build '%s'" % (
260 s, build['version']))
261 for srclib in build['srclibs']:
262 ref = srclib.split('@')[1].split('/')[0]
263 if ref.startswith(s):
264 warn("Branch '%s' used as commit in srclib '%s'" % (
266 for s in ['git clone', 'git svn clone', 'svn checkout', 'svn co', 'hg clone']:
267 for flag in ['init', 'prebuild', 'build']:
271 # TODO: This should not be pedantic!
272 pwarn("'%s' used in %s '%s'" % (s, flag, build[flag]))
277 logging.info("Found a total of %i warnings in %i apps out of %i total." % (
278 count['warn'], count['app'], count['app_total']))
280 if __name__ == "__main__":