2 # -*- coding: utf-8 -*-
4 # lint.py - part of the FDroid server tool
5 # Copyright (C) 2013-2014 Daniel Martà <mvdan@mvdan.cc>
7 # This program is free software: you can redistribute it and/or modify
8 # it under the terms of the GNU Affero General Public License as published by
9 # the Free Software Foundation, either version 3 of the License, or
10 # (at your option) any later version.
12 # This program is distributed in the hope that it will be useful,
13 # but WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See th
15 # GNU Affero General Public License for more details.
17 # You should have received a copy of the GNU Affero General Public Licen
18 # along with this program. If not, see <http://www.gnu.org/licenses/>.
20 from optparse import OptionParser
25 from collections import Counter
32 (re.compile(r'.*[^sS]://github\.com/.*'),
33 "github URLs should always use https:// not http://"),
34 (re.compile(r'.*[^sS]://code\.google\.com/.*'),
35 "code.google.com URLs should always use https:// not http://"),
38 (re.compile(r'.*[^sS]://github\.com/.*'),
39 "github URLs should always use https:// (not http://, git://, or git@)"),
40 (re.compile(r'.*code\.google\.com/p/[^/]+[/]*$'),
41 "/source is missing"),
42 (re.compile(r'.*[^sS]://code\.google\.com/.*'),
43 "code.google.com URLs should always use https:// not http://"),
44 (re.compile(r'.*[^sS]://dl\.google\.com/.*'),
45 "dl.google.com URLs should always use https:// not http://"),
46 (re.compile(r'.*[^sS]://gitorious\.org/.*'),
47 "gitorious URLs should always use https:// (not http://, git://, or git@)"),
50 (re.compile(r'.*[^sS]://code\.google\.com/.*'),
51 "code.google.com URLs should always use https:// not http://"),
52 (re.compile(r'.*[^sS]://dl\.google\.com/.*'),
53 "dl.google.com URLs should always use https:// not http://"),
54 (re.compile(r'.*[^sS]://github\.com/.*'),
55 "github URLs should always use https:// (not http://, git://, or git@)"),
56 (re.compile(r'.*[^sS]://gitorious\.org/.*'),
57 "gitorious URLs should always use https:// (not http://, git://, or git@)"),
58 (re.compile(r'.*[^sS]://[^.]*\.googlecode\.com/svn/?.*'),
59 "Google Code SVN URLs should always use https:// (not http:// or svn://)"),
60 (re.compile(r'.*[^sS]://svn\.apache\.org/repos/?.*'),
61 "Apache SVN URLs should always use https:// (not http:// or svn://)"),
62 (re.compile(r'.*[^sS]://svn\.code\.sf\.net/.*'),
63 "Sourceforge SVN URLs should always use https:// (not http:// or svn://)"),
66 (re.compile(r'.*code\.google\.com/p/[^/]+[/]*$'),
67 "/issues is missing"),
68 (re.compile(r'.*[^sS]://code\.google\.com/.*'),
69 "code.google.com URLs should always use https:// not http://"),
70 (re.compile(r'.*github\.com/[^/]+/[^/]+[/]*$'),
71 "/issues is missing"),
72 (re.compile(r'.*[^sS]://github\.com/.*'),
73 "github URLs should always use https:// not http://"),
74 (re.compile(r'.*[^sS]://gitorious\.org/.*'),
75 "gitorious URLs should always use https:// not http://"),
78 (re.compile(r'.*[^sS]://code\.google\.com/.*'),
79 "code.google.com URLs should always use https:// not http://"),
80 (re.compile(r'.*[^sS]://github\.com/.*'),
81 "github URLs should always use https:// not http://"),
82 (re.compile(r'.*[^sS]://gitorious\.org/.*'),
83 "gitorious URLs should always use https:// not http://"),
86 (re.compile(r'^(|None|Unknown)$'),
87 "No license specified"),
91 "Summary yet to be filled"),
94 (re.compile(r'^No description available$'),
95 "Description yet to be filled"),
96 (re.compile(r'\s*[*#][^ .]'),
97 "Invalid bulleted list"),
99 "Unnecessary leading space"),
100 (re.compile(r'.*\s$'),
101 "Unnecessary trailing space"),
107 (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
108 "Appending .git is not necessary"),
109 (re.compile(r'.*code\.google\.com/p/[^/]+/[^w]'),
110 "Possible incorrect path appended to google code project site"),
113 (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
114 "Appending .git is not necessary"),
115 (re.compile(r'.*code\.google\.com/p/[^/]+/source/.*'),
116 "/source is often enough on its own"),
119 (re.compile(r'^http://.*'),
120 "use https:// if available"),
121 (re.compile(r'^svn://.*'),
122 "use https:// if available"),
125 (re.compile(r'.*code\.google\.com/p/[^/]+/issues/.*'),
126 "/issues is often enough on its own"),
127 (re.compile(r'.*github\.com/[^/]+/[^/]+/issues/.*'),
128 "/issues is often enough on its own"),
131 (re.compile(r'.*commit.*', re.IGNORECASE),
132 "Not every commit log is suitable as change log"),
135 (re.compile(r'.*\b(free software|open source)\b.*', re.IGNORECASE),
136 "No need to specify that the app is Free Software"),
137 (re.compile(r'.*[a-z0-9][.,!?][ $]'),
138 "Punctuation should be avoided"),
145 global config, options, curid, count
156 print ' %s' % message
163 # Parse command line...
164 parser = OptionParser(usage="Usage: %prog [options] [APPID [APPID ...]]")
165 parser.add_option("-v", "--verbose", action="store_true", default=False,
166 help="Spew out even more information than normal")
167 parser.add_option("-q", "--quiet", action="store_true", default=False,
168 help="Restrict output to warnings and errors")
169 parser.add_option("-p", "--pedantic", action="store_true", default=False,
170 help="Show pedantic warnings that might give false positives")
171 (options, args) = parser.parse_args()
173 config = common.read_config(options)
176 allapps = metadata.read_metadata(xref=False)
177 apps = common.read_app_args(args, allapps, False)
179 for appid, app in apps.iteritems():
184 count['app_total'] += 1
187 for build in app['builds']:
188 if not curbuild or int(build['vercode']) > int(curbuild['vercode']):
191 # Potentially incorrect UCM
192 if (curbuild and curbuild['commit']
193 and app['Update Check Mode'] == 'RepoManifest' and
194 any(s in curbuild['commit'] for s in '.,_-/')):
195 pwarn("Last used commit '%s' looks like a tag, but Update Check Mode is '%s'" % (
196 curbuild['commit'], app['Update Check Mode']))
198 # Dangerous auto updates
199 if curbuild and app['Auto Update Mode'] != 'None':
200 for flag in ['target', 'srclibs', 'scanignore']:
202 pwarn("Auto Update Mode is enabled but '%s' is manually set at '%s'" % (flag, curbuild[flag]))
205 summ_chars = len(app['Summary'])
206 if summ_chars > config['char_limits']['Summary']:
207 warn("Summary of length %s is over the %i char limit" % (
208 summ_chars, config['char_limits']['Summary']))
211 if app['Web Site'] and app['Source Code']:
212 if app['Web Site'].lower() == app['Source Code'].lower():
213 warn("Website '%s' is just the app's source code link" % app['Web Site'])
216 name = app['Name'] or app['Auto Name']
217 if app['Summary'] and name:
218 if app['Summary'].lower() == name.lower():
219 warn("Summary '%s' is just the app's name" % app['Summary'])
221 if app['Summary'] and app['Description'] and len(app['Description']) == 1:
222 if app['Summary'].lower() == app['Description'][0].lower():
223 warn("Description '%s' is just the app's summary" % app['Summary'])
225 # Description size limit
226 desc_chars = sum(len(l) for l in app['Description'])
227 if desc_chars > config['char_limits']['Description']:
228 warn("Description of length %s is over the %i char limit" % (
229 desc_chars, config['char_limits']['Description']))
231 # Regex checks in all kinds of fields
232 for f in regex_warnings:
233 for m, r in regex_warnings[f]:
234 t = metadata.metafieldtype(f)
237 warn("%s '%s': %s" % (f, app[f], r))
238 elif t == 'multiline':
241 warn("%s at line '%s': %s" % (f, l, r))
243 # Regex pedantic checks in all kinds of fields
245 for f in regex_pedantic:
246 for m, r in regex_pedantic[f]:
248 warn("%s '%s': %s" % (f, app[f], r))
251 for build in app['builds']:
254 for s in ['master', 'origin', 'HEAD', 'default', 'trunk']:
255 if build['commit'] and build['commit'].startswith(s):
256 warn("Branch '%s' used as commit in build '%s'" % (
257 s, build['version']))
258 for srclib in build['srclibs']:
259 ref = srclib.split('@')[1].split('/')[0]
260 if ref.startswith(s):
261 warn("Branch '%s' used as commit in srclib '%s'" % (
263 for s in ['git clone', 'git svn clone', 'svn checkout', 'svn co', 'hg clone']:
264 for flag in ['init', 'prebuild', 'build']:
268 # TODO: This should not be pedantic!
269 pwarn("'%s' used in %s '%s'" % (s, flag, build[flag]))
274 logging.info("Found a total of %i warnings in %i apps out of %i total." % (
275 count['warn'], count['app'], count['app_total']))
277 if __name__ == "__main__":