2 # -*- coding: utf-8 -*-
4 # lint.py - part of the FDroid server tool
5 # Copyright (C) 2013-2014 Daniel Martà <mvdan@mvdan.cc>
7 # This program is free software: you can redistribute it and/or modify
8 # it under the terms of the GNU Affero General Public License as published by
9 # the Free Software Foundation, either version 3 of the License, or
10 # (at your option) any later version.
12 # This program is distributed in the hope that it will be useful,
13 # but WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See th
15 # GNU Affero General Public License for more details.
17 # You should have received a copy of the GNU Affero General Public Licen
18 # along with this program. If not, see <http://www.gnu.org/licenses/>.
20 from argparse import ArgumentParser
33 def enforce_https(domain):
34 return (re.compile(r'.*[^sS]://[^/]*' + re.escape(domain) + r'(/.*)?'),
35 domain + " URLs should always use https://")
38 enforce_https('github.com'),
39 enforce_https('gitlab.com'),
40 enforce_https('bitbucket.org'),
41 enforce_https('apache.org'),
42 enforce_https('google.com'),
43 enforce_https('svn.code.sf.net'),
47 def forbid_shortener(domain):
48 return (re.compile(r'https?://[^/]*' + re.escape(domain) + r'/.*'),
49 "URL shorteners should not be used")
51 http_url_shorteners = [
52 forbid_shortener('goo.gl'),
53 forbid_shortener('t.co'),
54 forbid_shortener('ur1.ca'),
57 http_checks = https_enforcings + http_url_shorteners + [
58 (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
59 "Appending .git is not necessary"),
60 (re.compile(r'.*://[^/]*(github|gitlab|bitbucket|rawgit)[^/]*/([^/]+/){1,3}master'),
61 "Use /HEAD instead of /master to point at a file in the default branch"),
65 'Web Site': http_checks,
66 'Source Code': http_checks,
67 'Repo': https_enforcings,
68 'Issue Tracker': http_checks + [
69 (re.compile(r'.*github\.com/[^/]+/[^/]+[/]*$'),
70 "/issues is missing"),
72 'Donate': http_checks + [
73 (re.compile(r'.*flattr\.com'),
74 "Flattr donation methods belong in the FlattrID flag"),
76 'Changelog': http_checks,
79 "Unnecessary leading space"),
82 (re.compile(r'^(|None|Unknown)$'),
83 "No license specified"),
87 "Summary yet to be filled"),
88 (re.compile(r'.*\b(free software|open source)\b.*', re.IGNORECASE),
89 "No need to specify that the app is Free Software"),
90 (re.compile(r'.*((your|for).*android|android.*(app|device|client|port|version))', re.IGNORECASE),
91 "No need to specify that the app is for Android"),
92 (re.compile(r'.*[a-z0-9][.!?]( |$)'),
93 "Punctuation should be avoided"),
95 "Unnecessary leading space"),
96 (re.compile(r'.*\s$'),
97 "Unnecessary trailing space"),
100 (re.compile(r'^No description available$'),
101 "Description yet to be filled"),
102 (re.compile(r'\s*[*#][^ .]'),
103 "Invalid bulleted list"),
105 "Unnecessary leading space"),
106 (re.compile(r'.*\s$'),
107 "Unnecessary trailing space"),
108 (re.compile(r'.*([^[]|^)\[[^:[\]]+( |\]|$)'),
109 "Invalid link - use [http://foo.bar Link title] or [http://foo.bar]"),
110 (re.compile(r'(^|.* )https?://[^ ]+'),
111 "Unlinkified link - use [http://foo.bar Link title] or [http://foo.bar]"),
116 def check_regexes(app):
117 for f, checks in regex_checks.iteritems():
120 t = metadata.fieldtype(f)
121 if t == metadata.TYPE_MULTILINE:
122 for l in v.splitlines():
124 yield "%s at line '%s': %s" % (f, l, r)
129 yield "%s '%s': %s" % (f, v, r)
132 def get_lastbuild(builds):
136 if not build.disable:
137 vercode = int(build.vercode)
138 if lowest_vercode == -1 or vercode < lowest_vercode:
139 lowest_vercode = vercode
140 if not lastbuild or int(build.vercode) > int(lastbuild.vercode):
145 def check_ucm_tags(app):
146 lastbuild = get_lastbuild(app.builds)
147 if (lastbuild is not None
149 and app.UpdateCheckMode == 'RepoManifest'
150 and not lastbuild.commit.startswith('unknown')
151 and lastbuild.vercode == app.CurrentVersionCode
152 and not lastbuild.forcevercode
153 and any(s in lastbuild.commit for s in '.,_-/')):
154 yield "Last used commit '%s' looks like a tag, but Update Check Mode is '%s'" % (
155 lastbuild.commit, app.UpdateCheckMode)
158 def check_char_limits(app):
159 limits = config['char_limits']
161 if len(app.Summary) > limits['Summary']:
162 yield "Summary of length %s is over the %i char limit" % (
163 len(app.Summary), limits['Summary'])
165 if len(app.Description) > limits['Description']:
166 yield "Description of length %s is over the %i char limit" % (
167 len(app.Description), limits['Description'])
170 def check_old_links(app):
180 if any(s in app.Repo for s in usual_sites):
181 for f in ['Web Site', 'Source Code', 'Issue Tracker', 'Changelog']:
183 if any(s in v for s in old_sites):
184 yield "App is in '%s' but has a link to '%s'" % (app.Repo, v)
187 def check_useless_fields(app):
188 if app.UpdateCheckName == app.id:
189 yield "Update Check Name is set to the known app id - it can be removed"
191 filling_ucms = re.compile(r'^(Tags.*|RepoManifest.*)')
194 def check_checkupdates_ran(app):
195 if filling_ucms.match(app.UpdateCheckMode):
196 if not app.AutoName and not app.CurrentVersion and app.CurrentVersionCode == '0':
197 yield "UCM is set but it looks like checkupdates hasn't been run yet"
200 def check_empty_fields(app):
201 if not app.Categories:
202 yield "Categories are not set"
204 all_categories = Set([
215 "Science & Education",
225 def check_categories(app):
226 for categ in app.Categories:
227 if categ not in all_categories:
228 yield "Category '%s' is not valid" % categ
231 def check_duplicates(app):
232 if app.Name and app.Name == app.AutoName:
233 yield "Name '%s' is just the auto name - remove it" % app.Name
236 for f in ['Source Code', 'Web Site', 'Issue Tracker', 'Changelog']:
242 yield "Duplicate link in '%s': %s" % (f, v)
246 name = app.Name or app.AutoName
247 if app.Summary and name:
248 if app.Summary.lower() == name.lower():
249 yield "Summary '%s' is just the app's name" % app.Summary
251 if app.Summary and app.Description and len(app.Description) == 1:
252 if app.Summary.lower() == app.Description[0].lower():
253 yield "Description '%s' is just the app's summary" % app.Summary
256 for l in app.Description.splitlines():
260 yield "Description has a duplicate line"
264 desc_url = re.compile(r'(^|[^[])\[([^ ]+)( |\]|$)')
267 def check_mediawiki_links(app):
268 wholedesc = ' '.join(app.Description)
269 for um in desc_url.finditer(wholedesc):
271 for m, r in http_checks:
273 yield "URL '%s' in Description: %s" % (url, r)
276 def check_bulleted_lists(app):
277 validchars = ['*', '#']
280 for l in app.Description.splitlines():
285 if l[0] == lchar and l[1] == ' ':
287 if lcount > 2 and lchar not in validchars:
288 yield "Description has a list (%s) but it isn't bulleted (*) nor numbered (#)" % lchar
295 def check_builds(app):
296 for build in app.builds:
299 for s in ['master', 'origin', 'HEAD', 'default', 'trunk']:
300 if build.commit and build.commit.startswith(s):
301 yield "Branch '%s' used as commit in build '%s'" % (s, build.version)
302 for srclib in build.srclibs:
303 ref = srclib.split('@')[1].split('/')[0]
304 if ref.startswith(s):
305 yield "Branch '%s' used as commit in srclib '%s'" % (s, srclib)
306 if build.target and build.method() == 'gradle':
307 yield "target= has no gradle support"
312 global config, options
316 # Parse command line...
317 parser = ArgumentParser(usage="%(prog)s [options] [APPID [APPID ...]]")
318 common.setup_global_opts(parser)
319 parser.add_argument("-f", "--format", action="store_true", default=False,
320 help="Also warn about formatting issues, like rewritemeta -l")
321 parser.add_argument("appid", nargs='*', help="app-id in the form APPID")
322 options = parser.parse_args()
324 config = common.read_config(options)
327 allapps = metadata.read_metadata(xref=True)
328 apps = common.read_app_args(options.appid, allapps, False)
330 for appid, app in apps.iteritems():
341 check_checkupdates_ran,
342 check_useless_fields,
346 check_mediawiki_links,
347 check_bulleted_lists,
350 warns += check_func(app)
353 if not rewritemeta.proper_format(app):
354 warns.append("Run rewritemeta to fix formatting")
359 print("%s: %s" % (appid, warn))
365 if __name__ == "__main__":