2 # -*- coding: utf-8 -*-
4 # lint.py - part of the FDroid server tool
5 # Copyright (C) 2013-2014 Daniel Martà <mvdan@mvdan.cc>
7 # This program is free software: you can redistribute it and/or modify
8 # it under the terms of the GNU Affero General Public License as published by
9 # the Free Software Foundation, either version 3 of the License, or
10 # (at your option) any later version.
12 # This program is distributed in the hope that it will be useful,
13 # but WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See th
15 # GNU Affero General Public License for more details.
17 # You should have received a copy of the GNU Affero General Public Licen
18 # along with this program. If not, see <http://www.gnu.org/licenses/>.
20 from optparse import OptionParser
26 from collections import Counter
33 def enforce_https(domain):
34 return (re.compile(r'.*[^sS]://[^/]*' + re.escape(domain) + r'(/.*)?'),
35 domain + " URLs should always use https://")
38 enforce_https('github.com'),
39 enforce_https('gitlab.com'),
40 enforce_https('bitbucket.org'),
41 enforce_https('gitorious.org'),
42 enforce_https('apache.org'),
43 enforce_https('google.com'),
44 enforce_https('svn.code.sf.net'),
45 enforce_https('googlecode.com'),
49 def forbid_shortener(domain):
50 return (re.compile(r'https?://[^/]*' + re.escape(domain) + r'/.*'),
51 "URL shorteners should not be used")
53 http_url_shorteners = [
54 forbid_shortener('goo.gl'),
55 forbid_shortener('t.co'),
56 forbid_shortener('ur1.ca'),
59 http_warnings = https_enforcings + http_url_shorteners + [
60 (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
61 "Appending .git is not necessary"),
62 (re.compile(r'(.*/blob/master/|.*raw\.github.com/[^/]*/[^/]*/master/)'),
63 "Use /HEAD/ instead of /master/ to point at a file in the default branch"),
67 'Web Site': http_warnings + [
69 'Source Code': http_warnings + [
71 'Repo': https_enforcings + [
73 'Issue Tracker': http_warnings + [
74 (re.compile(r'.*github\.com/[^/]+/[^/]+[/]*$'),
75 "/issues is missing"),
77 'Donate': http_warnings + [
78 (re.compile(r'.*flattr\.com'),
79 "Flattr donation methods belong in the FlattrID flag"),
81 'Changelog': http_warnings + [
84 (re.compile(r'^(|None|Unknown)$'),
85 "No license specified"),
89 "Summary yet to be filled"),
90 (re.compile(r'.*\b(free software|open source)\b.*', re.IGNORECASE),
91 "No need to specify that the app is Free Software"),
92 (re.compile(r'.*((your|for).*android|android.*(app|device|client|port|version))', re.IGNORECASE),
93 "No need to specify that the app is for Android"),
94 (re.compile(r'.*[a-z0-9][.!?]( |$)'),
95 "Punctuation should be avoided"),
98 (re.compile(r'^No description available$'),
99 "Description yet to be filled"),
100 (re.compile(r'\s*[*#][^ .]'),
101 "Invalid bulleted list"),
103 "Unnecessary leading space"),
104 (re.compile(r'.*\s$'),
105 "Unnecessary trailing space"),
106 (re.compile(r'.*([^[]|^)\[[^:[\]]+( |\]|$)'),
107 "Invalid link - use [http://foo.bar Link title] or [http://foo.bar]"),
108 (re.compile(r'.*[^[]https?://[^ ]+'),
109 "Unlinkified link - use [http://foo.bar Link title] or [http://foo.bar]"),
122 "Science & Education",
128 desc_url = re.compile("[^[]\[([^ ]+)( |\]|$)")
133 global config, options, curid, count
144 print ' %s' % message
147 # Parse command line...
148 parser = OptionParser(usage="Usage: %prog [options] [APPID [APPID ...]]")
149 parser.add_option("-v", "--verbose", action="store_true", default=False,
150 help="Spew out even more information than normal")
151 parser.add_option("-q", "--quiet", action="store_true", default=False,
152 help="Restrict output to warnings and errors")
153 (options, args) = parser.parse_args()
155 config = common.read_config(options)
158 allapps = metadata.read_metadata(xref=True)
159 apps = common.read_app_args(args, allapps, False)
161 filling_ucms = re.compile('^(Tags.*|RepoManifest.*)')
163 for appid, app in apps.iteritems():
168 count['app_total'] += 1
173 for build in app['builds']:
174 if not build['disable']:
175 # enabled_builds += 1
176 vercode = int(build['vercode'])
177 if lowest_vercode == -1 or vercode < lowest_vercode:
178 lowest_vercode = vercode
179 if not curbuild or int(build['vercode']) > int(curbuild['vercode']):
183 if (curbuild and curbuild['commit']
184 and app['Update Check Mode'] == 'RepoManifest'
185 and not curbuild['commit'].startswith('unknown')
186 and curbuild['vercode'] == app['Current Version Code']
187 and not curbuild['forcevercode']
188 and any(s in curbuild['commit'] for s in '.,_-/')):
189 warn("Last used commit '%s' looks like a tag, but Update Check Mode is '%s'" % (
190 curbuild['commit'], app['Update Check Mode']))
193 summ_chars = len(app['Summary'])
194 if summ_chars > config['char_limits']['Summary']:
195 warn("Summary of length %s is over the %i char limit" % (
196 summ_chars, config['char_limits']['Summary']))
199 if app['Web Site'] and app['Source Code']:
200 if app['Web Site'].lower() == app['Source Code'].lower():
201 warn("Website '%s' is just the app's source code link" % app['Web Site'])
203 if filling_ucms.match(app['Update Check Mode']):
204 if all(app[f] == metadata.app_defaults[f] for f in [
207 'Current Version Code',
209 warn("UCM is set but it looks like checkupdates hasn't been run yet")
211 if app['Update Check Name'] == appid:
212 warn("Update Check Name is set to the known app id - it can be removed")
214 cvc = int(app['Current Version Code'])
215 if cvc > 0 and cvc < lowest_vercode:
216 warn("Current Version Code is lower than any enabled build")
218 # Missing or incorrect categories
219 if not app['Categories']:
220 warn("Categories are not set")
221 for categ in app['Categories']:
222 if categ not in categories:
223 warn("Category '%s' is not valid" % categ)
225 if app['Name'] and app['Name'] == app['Auto Name']:
226 warn("Name '%s' is just the auto name" % app['Name'])
228 name = app['Name'] or app['Auto Name']
229 if app['Summary'] and name:
230 if app['Summary'].lower() == name.lower():
231 warn("Summary '%s' is just the app's name" % app['Summary'])
233 desc = app['Description']
234 if app['Summary'] and desc and len(desc) == 1:
235 if app['Summary'].lower() == desc[0].lower():
236 warn("Description '%s' is just the app's summary" % app['Summary'])
238 # Description size limit
239 desc_charcount = sum(len(l) for l in desc)
240 if desc_charcount > config['char_limits']['Description']:
241 warn("Description of length %s is over the %i char limit" % (
242 desc_charcount, config['char_limits']['Description']))
245 for l in app['Description']:
246 if any(l.startswith(c) for c in ['*', '#']):
248 if any(len(w) > maxcols for w in l.split(' ')):
251 warn("Description should be wrapped to 80-120 chars")
254 if (not desc[0] or not desc[-1]
255 or any(not desc[l - 1] and not desc[l] for l in range(1, len(desc)))):
256 warn("Description has an extra empty line")
258 # Check for lists using the wrong characters
259 validchars = ['*', '#']
262 for l in app['Description']:
266 for um in desc_url.finditer(l):
268 for m, r in http_warnings:
270 warn("URL '%s' in Description: %s" % (url, r))
272 c = l.decode('utf-8')[0]
275 if lcount > 3 and lchar not in validchars:
276 warn("Description has a list (%s) but it isn't bulleted (*) nor numbered (#)" % lchar)
282 # Regex checks in all kinds of fields
283 for f in regex_warnings:
284 for m, r in regex_warnings[f]:
290 warn("%s '%s': %s" % (f, v, r))
291 elif type(v) == list:
294 warn("%s at line '%s': %s" % (f, l, r))
297 for build in app['builds']:
300 for s in ['master', 'origin', 'HEAD', 'default', 'trunk']:
301 if build['commit'] and build['commit'].startswith(s):
302 warn("Branch '%s' used as commit in build '%s'" % (
303 s, build['version']))
304 for srclib in build['srclibs']:
305 ref = srclib.split('@')[1].split('/')[0]
306 if ref.startswith(s):
307 warn("Branch '%s' used as commit in srclib '%s'" % (
313 if count['warn'] > 0:
314 logging.warn("Found a total of %i warnings in %i apps out of %i total." % (
315 count['warn'], count['app'], count['app_total']))
319 if __name__ == "__main__":