2 # -*- coding: utf-8 -*-
4 # lint.py - part of the FDroid server tool
5 # Copyright (C) 2013-2014 Daniel Martà <mvdan@mvdan.cc>
7 # This program is free software: you can redistribute it and/or modify
8 # it under the terms of the GNU Affero General Public License as published by
9 # the Free Software Foundation, either version 3 of the License, or
10 # (at your option) any later version.
12 # This program is distributed in the hope that it will be useful,
13 # but WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See th
15 # GNU Affero General Public License for more details.
17 # You should have received a copy of the GNU Affero General Public Licen
18 # along with this program. If not, see <http://www.gnu.org/licenses/>.
20 from optparse import OptionParser
25 from collections import Counter
32 (re.compile(r'.*[^sS]://github\.com/.*'),
33 "github URLs should always use https:// not http://"),
34 (re.compile(r'.*[^sS]://code\.google\.com/.*'),
35 "code.google.com URLs should always use https:// not http://"),
38 (re.compile(r'.*[^sS]://github\.com/.*'),
39 "github URLs should always use https:// (not http://, git://, or git@)"),
40 (re.compile(r'.*code\.google\.com/p/[^/]+[/]*$'),
41 "/source is missing"),
42 (re.compile(r'.*[^sS]://code\.google\.com/.*'),
43 "code.google.com URLs should always use https:// not http://"),
44 (re.compile(r'.*[^sS]://dl\.google\.com/.*'),
45 "dl.google.com URLs should always use https:// not http://"),
46 (re.compile(r'.*[^sS]://gitorious\.org/.*'),
47 "gitorious URLs should always use https:// (not http://, git://, or git@)"),
50 (re.compile(r'.*[^sS]://code\.google\.com/.*'),
51 "code.google.com URLs should always use https:// not http://"),
52 (re.compile(r'.*[^sS]://dl\.google\.com/.*'),
53 "dl.google.com URLs should always use https:// not http://"),
54 (re.compile(r'.*[^sS]://github\.com/.*'),
55 "github URLs should always use https:// (not http://, git://, or git@)"),
56 (re.compile(r'.*[^sS]://gitorious\.org/.*'),
57 "gitorious URLs should always use https:// (not http://, git://, or git@)"),
58 (re.compile(r'.*[^sS]://[^.]*\.googlecode\.com/svn/?.*'),
59 "Google Code SVN URLs should always use https:// (not http:// or svn://)"),
60 (re.compile(r'.*[^sS]://svn\.apache\.org/repos/?.*'),
61 "Apache SVN URLs should always use https:// (not http:// or svn://)"),
62 (re.compile(r'.*[^sS]://svn\.code\.sf\.net/.*'),
63 "Sourceforge SVN URLs should always use https:// (not http:// or svn://)"),
66 (re.compile(r'.*code\.google\.com/p/[^/]+[/]*$'),
67 "/issues is missing"),
68 (re.compile(r'.*[^sS]://code\.google\.com/.*'),
69 "code.google.com URLs should always use https:// not http://"),
70 (re.compile(r'.*github\.com/[^/]+/[^/]+[/]*$'),
71 "/issues is missing"),
72 (re.compile(r'.*[^sS]://github\.com/.*'),
73 "github URLs should always use https:// not http://"),
74 (re.compile(r'.*[^sS]://gitorious\.org/.*'),
75 "gitorious URLs should always use https:// not http://"),
78 (re.compile(r'^(|None|Unknown)$'),
79 "No license specified"),
83 "Summary yet to be filled"),
86 (re.compile(r'^No description available$'),
87 "Description yet to be filled"),
88 (re.compile(r'\s*[*#][^ .]'),
89 "Invalid bulleted list"),
91 "Unnecessary leading space"),
92 (re.compile(r'.*\s$'),
93 "Unnecessary trailing space"),
99 (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
100 "Appending .git is not necessary"),
101 (re.compile(r'.*code\.google\.com/p/[^/]+/[^w]'),
102 "Possible incorrect path appended to google code project site"),
105 (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
106 "Appending .git is not necessary"),
107 (re.compile(r'.*code\.google\.com/p/[^/]+/source/.*'),
108 "/source is often enough on its own"),
111 (re.compile(r'^http://.*'),
112 "use https:// if available"),
113 (re.compile(r'^svn://.*'),
114 "use https:// if available"),
117 (re.compile(r'.*code\.google\.com/p/[^/]+/issues/.*'),
118 "/issues is often enough on its own"),
119 (re.compile(r'.*github\.com/[^/]+/[^/]+/issues/.*'),
120 "/issues is often enough on its own"),
123 (re.compile(r'.*\b(free software|open source)\b.*', re.IGNORECASE),
124 "No need to specify that the app is Free Software"),
125 (re.compile(r'.*[a-z0-9][.,!?][ $]'),
126 "Punctuation should be avoided"),
133 global config, options, curid, count
144 print ' %s' % message
151 # Parse command line...
152 parser = OptionParser(usage="Usage: %prog [options] [APPID [APPID ...]]")
153 parser.add_option("-v", "--verbose", action="store_true", default=False,
154 help="Spew out even more information than normal")
155 parser.add_option("-q", "--quiet", action="store_true", default=False,
156 help="Restrict output to warnings and errors")
157 parser.add_option("-p", "--pedantic", action="store_true", default=False,
158 help="Show pedantic warnings that might give false positives")
159 (options, args) = parser.parse_args()
161 config = common.read_config(options)
164 allapps = metadata.read_metadata(xref=False)
165 apps = common.read_app_args(args, allapps, False)
167 for appid, app in apps.iteritems():
172 count['app_total'] += 1
175 for build in app['builds']:
176 if not curbuild or int(build['vercode']) > int(curbuild['vercode']):
179 # Potentially incorrect UCM
180 if (curbuild and curbuild['commit']
181 and app['Update Check Mode'] == 'RepoManifest'
182 and curbuild['commit'] != 'unknown - see disabled'
183 and any(s in curbuild['commit'] for s in '.,_-/')):
184 pwarn("Last used commit '%s' looks like a tag, but Update Check Mode is '%s'" % (
185 curbuild['commit'], app['Update Check Mode']))
187 # Dangerous auto updates
188 if curbuild and app['Auto Update Mode'] != 'None':
189 for flag in ['target', 'srclibs', 'scanignore']:
191 pwarn("Auto Update Mode is enabled but '%s' is manually set at '%s'" % (flag, curbuild[flag]))
194 summ_chars = len(app['Summary'])
195 if summ_chars > config['char_limits']['Summary']:
196 warn("Summary of length %s is over the %i char limit" % (
197 summ_chars, config['char_limits']['Summary']))
200 if app['Web Site'] and app['Source Code']:
201 if app['Web Site'].lower() == app['Source Code'].lower():
202 warn("Website '%s' is just the app's source code link" % app['Web Site'])
205 name = app['Name'] or app['Auto Name']
206 if app['Summary'] and name:
207 if app['Summary'].lower() == name.lower():
208 warn("Summary '%s' is just the app's name" % app['Summary'])
210 if app['Summary'] and app['Description'] and len(app['Description']) == 1:
211 if app['Summary'].lower() == app['Description'][0].lower():
212 warn("Description '%s' is just the app's summary" % app['Summary'])
214 # Description size limit
215 desc_chars = sum(len(l) for l in app['Description'])
216 if desc_chars > config['char_limits']['Description']:
217 warn("Description of length %s is over the %i char limit" % (
218 desc_chars, config['char_limits']['Description']))
220 # Regex checks in all kinds of fields
221 for f in regex_warnings:
222 for m, r in regex_warnings[f]:
223 t = metadata.metafieldtype(f)
226 warn("%s '%s': %s" % (f, app[f], r))
227 elif t == 'multiline':
230 warn("%s at line '%s': %s" % (f, l, r))
232 # Regex pedantic checks in all kinds of fields
234 for f in regex_pedantic:
235 for m, r in regex_pedantic[f]:
237 warn("%s '%s': %s" % (f, app[f], r))
240 for build in app['builds']:
243 for s in ['master', 'origin', 'HEAD', 'default', 'trunk']:
244 if build['commit'] and build['commit'].startswith(s):
245 warn("Branch '%s' used as commit in build '%s'" % (
246 s, build['version']))
247 for srclib in build['srclibs']:
248 ref = srclib.split('@')[1].split('/')[0]
249 if ref.startswith(s):
250 warn("Branch '%s' used as commit in srclib '%s'" % (
252 for s in ['git clone', 'git svn clone', 'svn checkout', 'svn co', 'hg clone']:
253 for flag in ['init', 'prebuild', 'build']:
257 # TODO: This should not be pedantic!
258 pwarn("'%s' used in %s '%s'" % (s, flag, build[flag]))
263 logging.info("Found a total of %i warnings in %i apps out of %i total." % (
264 count['warn'], count['app'], count['app_total']))
266 if __name__ == "__main__":