3 # common.py - part of the FDroid server tools
4 # Copyright (C) 2010-13, Ciaran Gultnieks, ciaran@ciarang.com
5 # Copyright (C) 2013-2014 Daniel Martà <mvdan@mvdan.cc>
7 # This program is free software: you can redistribute it and/or modify
8 # it under the terms of the GNU Affero General Public License as published by
9 # the Free Software Foundation, either version 3 of the License, or
10 # (at your option) any later version.
12 # This program is distributed in the hope that it will be useful,
13 # but WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 # GNU Affero General Public License for more details.
17 # You should have received a copy of the GNU Affero General Public License
18 # along with this program. If not, see <http://www.gnu.org/licenses/>.
20 # common.py is imported by all modules, so do not import third-party
21 # libraries here as they will become a requirement for all commands.
40 import xml.etree.ElementTree as XMLElementTree
42 from binascii import hexlify
43 from datetime import datetime
44 from distutils.version import LooseVersion
45 from queue import Queue
46 from zipfile import ZipFile
48 from pyasn1.codec.der import decoder, encoder
49 from pyasn1_modules import rfc2315
50 from pyasn1.error import PyAsn1Error
52 from distutils.util import strtobool
54 import fdroidserver.metadata
55 from fdroidserver import _
56 from fdroidserver.exception import FDroidException, VCSException, BuildException, VerificationException
57 from .asynchronousfilereader import AsynchronousFileReader
60 # A signature block file with a .DSA, .RSA, or .EC extension
61 CERT_PATH_REGEX = re.compile(r'^META-INF/.*\.(DSA|EC|RSA)$')
62 APK_NAME_REGEX = re.compile(r'^([a-zA-Z][\w.]*)_(-?[0-9]+)_?([0-9a-f]{7})?\.apk')
63 STANDARD_FILE_NAME_REGEX = re.compile(r'^(\w[\w.]*)_(-?[0-9]+)\.\w+')
65 XMLElementTree.register_namespace('android', 'http://schemas.android.com/apk/res/android')
74 'sdk_path': "$ANDROID_HOME",
79 'r12b': "$ANDROID_NDK",
85 'build_tools': "25.0.2",
86 'force_build_tools': False,
91 'accepted_formats': ['txt', 'yml'],
92 'sync_from_local_copy_dir': False,
93 'allow_disabled_algorithms': False,
94 'per_app_repos': False,
95 'make_current_version_link': True,
96 'current_version_name_source': 'Name',
97 'update_stats': False,
101 'stats_to_carbon': False,
103 'build_server_always': False,
104 'keystore': 'keystore.jks',
105 'smartcardoptions': [],
115 'repo_url': "https://MyFirstFDroidRepo.org/fdroid/repo",
116 'repo_name': "My First FDroid Repo Demo",
117 'repo_icon': "fdroid-icon.png",
118 'repo_description': '''
119 This is a repository of apps to be used with FDroid. Applications in this
120 repository are either official binaries built by the original application
121 developers, or are binaries built from source by the admin of f-droid.org
122 using the tools on https://gitlab.com/u/fdroid.
128 def setup_global_opts(parser):
129 parser.add_argument("-v", "--verbose", action="store_true", default=False,
130 help=_("Spew out even more information than normal"))
131 parser.add_argument("-q", "--quiet", action="store_true", default=False,
132 help=_("Restrict output to warnings and errors"))
135 def fill_config_defaults(thisconfig):
136 for k, v in default_config.items():
137 if k not in thisconfig:
140 # Expand paths (~users and $vars)
141 def expand_path(path):
145 path = os.path.expanduser(path)
146 path = os.path.expandvars(path)
151 for k in ['sdk_path', 'ant', 'mvn3', 'gradle', 'keystore', 'repo_icon']:
156 thisconfig[k + '_orig'] = v
158 # find all installed JDKs for keytool, jarsigner, and JAVA[6-9]_HOME env vars
159 if thisconfig['java_paths'] is None:
160 thisconfig['java_paths'] = dict()
162 pathlist += glob.glob('/usr/lib/jvm/j*[6-9]*')
163 pathlist += glob.glob('/usr/java/jdk1.[6-9]*')
164 pathlist += glob.glob('/System/Library/Java/JavaVirtualMachines/1.[6-9].0.jdk')
165 pathlist += glob.glob('/Library/Java/JavaVirtualMachines/*jdk*[6-9]*')
166 if os.getenv('JAVA_HOME') is not None:
167 pathlist.append(os.getenv('JAVA_HOME'))
168 if os.getenv('PROGRAMFILES') is not None:
169 pathlist += glob.glob(os.path.join(os.getenv('PROGRAMFILES'), 'Java', 'jdk1.[6-9].*'))
170 for d in sorted(pathlist):
171 if os.path.islink(d):
173 j = os.path.basename(d)
174 # the last one found will be the canonical one, so order appropriately
176 r'^1\.([6-9])\.0\.jdk$', # OSX
177 r'^jdk1\.([6-9])\.0_[0-9]+.jdk$', # OSX and Oracle tarball
178 r'^jdk1\.([6-9])\.0_[0-9]+$', # Oracle Windows
179 r'^jdk([6-9])-openjdk$', # Arch
180 r'^java-([6-9])-openjdk$', # Arch
181 r'^java-([6-9])-jdk$', # Arch (oracle)
182 r'^java-1\.([6-9])\.0-.*$', # RedHat
183 r'^java-([6-9])-oracle$', # Debian WebUpd8
184 r'^jdk-([6-9])-oracle-.*$', # Debian make-jpkg
185 r'^java-([6-9])-openjdk-[^c][^o][^m].*$', # Debian
187 m = re.match(regex, j)
190 for p in [d, os.path.join(d, 'Contents', 'Home')]:
191 if os.path.exists(os.path.join(p, 'bin', 'javac')):
192 thisconfig['java_paths'][m.group(1)] = p
194 for java_version in ('7', '8', '9'):
195 if java_version not in thisconfig['java_paths']:
197 java_home = thisconfig['java_paths'][java_version]
198 jarsigner = os.path.join(java_home, 'bin', 'jarsigner')
199 if os.path.exists(jarsigner):
200 thisconfig['jarsigner'] = jarsigner
201 thisconfig['keytool'] = os.path.join(java_home, 'bin', 'keytool')
202 break # Java7 is preferred, so quit if found
204 for k in ['ndk_paths', 'java_paths']:
210 thisconfig[k][k2] = exp
211 thisconfig[k][k2 + '_orig'] = v
214 def regsub_file(pattern, repl, path):
215 with open(path, 'rb') as f:
217 text = re.sub(bytes(pattern, 'utf8'), bytes(repl, 'utf8'), text)
218 with open(path, 'wb') as f:
222 def read_config(opts, config_file='config.py'):
223 """Read the repository config
225 The config is read from config_file, which is in the current
226 directory when any of the repo management commands are used. If
227 there is a local metadata file in the git repo, then config.py is
228 not required, just use defaults.
231 global config, options
233 if config is not None:
240 if os.path.isfile(config_file):
241 logging.debug(_("Reading '{config_file}'").format(config_file=config_file))
242 with io.open(config_file, "rb") as f:
243 code = compile(f.read(), config_file, 'exec')
244 exec(code, None, config)
246 logging.warning(_("No 'config.py' found, using defaults."))
248 for k in ('mirrors', 'install_list', 'uninstall_list', 'serverwebroot', 'servergitroot'):
250 if not type(config[k]) in (str, list, tuple):
252 _("'{field}' will be in random order! Use () or [] brackets if order is important!")
255 # smartcardoptions must be a list since its command line args for Popen
256 if 'smartcardoptions' in config:
257 config['smartcardoptions'] = config['smartcardoptions'].split(' ')
258 elif 'keystore' in config and config['keystore'] == 'NONE':
259 # keystore='NONE' means use smartcard, these are required defaults
260 config['smartcardoptions'] = ['-storetype', 'PKCS11', '-providerName',
261 'SunPKCS11-OpenSC', '-providerClass',
262 'sun.security.pkcs11.SunPKCS11',
263 '-providerArg', 'opensc-fdroid.cfg']
265 if any(k in config for k in ["keystore", "keystorepass", "keypass"]):
266 st = os.stat(config_file)
267 if st.st_mode & stat.S_IRWXG or st.st_mode & stat.S_IRWXO:
268 logging.warning(_("unsafe permissions on '{config_file}' (should be 0600)!")
269 .format(config_file=config_file))
271 fill_config_defaults(config)
273 for k in ["repo_description", "archive_description"]:
275 config[k] = clean_description(config[k])
277 if 'serverwebroot' in config:
278 if isinstance(config['serverwebroot'], str):
279 roots = [config['serverwebroot']]
280 elif all(isinstance(item, str) for item in config['serverwebroot']):
281 roots = config['serverwebroot']
283 raise TypeError(_('only accepts strings, lists, and tuples'))
285 for rootstr in roots:
286 # since this is used with rsync, where trailing slashes have
287 # meaning, ensure there is always a trailing slash
288 if rootstr[-1] != '/':
290 rootlist.append(rootstr.replace('//', '/'))
291 config['serverwebroot'] = rootlist
293 if 'servergitmirrors' in config:
294 if isinstance(config['servergitmirrors'], str):
295 roots = [config['servergitmirrors']]
296 elif all(isinstance(item, str) for item in config['servergitmirrors']):
297 roots = config['servergitmirrors']
299 raise TypeError(_('only accepts strings, lists, and tuples'))
300 config['servergitmirrors'] = roots
305 def find_sdk_tools_cmd(cmd):
306 '''find a working path to a tool from the Android SDK'''
309 if config is not None and 'sdk_path' in config and os.path.exists(config['sdk_path']):
310 # try to find a working path to this command, in all the recent possible paths
311 if 'build_tools' in config:
312 build_tools = os.path.join(config['sdk_path'], 'build-tools')
313 # if 'build_tools' was manually set and exists, check only that one
314 configed_build_tools = os.path.join(build_tools, config['build_tools'])
315 if os.path.exists(configed_build_tools):
316 tooldirs.append(configed_build_tools)
318 # no configed version, so hunt known paths for it
319 for f in sorted(os.listdir(build_tools), reverse=True):
320 if os.path.isdir(os.path.join(build_tools, f)):
321 tooldirs.append(os.path.join(build_tools, f))
322 tooldirs.append(build_tools)
323 sdk_tools = os.path.join(config['sdk_path'], 'tools')
324 if os.path.exists(sdk_tools):
325 tooldirs.append(sdk_tools)
326 sdk_platform_tools = os.path.join(config['sdk_path'], 'platform-tools')
327 if os.path.exists(sdk_platform_tools):
328 tooldirs.append(sdk_platform_tools)
329 tooldirs.append('/usr/bin')
331 path = os.path.join(d, cmd)
332 if os.path.isfile(path):
334 test_aapt_version(path)
336 # did not find the command, exit with error message
337 ensure_build_tools_exists(config)
340 def test_aapt_version(aapt):
341 '''Check whether the version of aapt is new enough'''
342 output = subprocess.check_output([aapt, 'version'], universal_newlines=True)
343 if output is None or output == '':
344 logging.error(_("'{path}' failed to execute!").format(path=aapt))
346 m = re.match(r'.*v([0-9]+)\.([0-9]+)[.-]?([0-9.-]*)', output)
351 # the Debian package has the version string like "v0.2-23.0.2"
352 if '.' not in bugfix and LooseVersion('.'.join((major, minor, bugfix))) < LooseVersion('0.2.2166767'):
353 logging.warning(_("'{aapt}' is too old, fdroid requires build-tools-23.0.0 or newer!")
356 logging.warning(_('Unknown version of aapt, might cause problems: ') + output)
359 def test_sdk_exists(thisconfig):
360 if 'sdk_path' not in thisconfig:
361 if 'aapt' in thisconfig and os.path.isfile(thisconfig['aapt']):
362 test_aapt_version(thisconfig['aapt'])
365 logging.error(_("'sdk_path' not set in 'config.py'!"))
367 if thisconfig['sdk_path'] == default_config['sdk_path']:
368 logging.error(_('No Android SDK found!'))
369 logging.error(_('You can use ANDROID_HOME to set the path to your SDK, i.e.:'))
370 logging.error('\texport ANDROID_HOME=/opt/android-sdk')
372 if not os.path.exists(thisconfig['sdk_path']):
373 logging.critical(_("Android SDK path '{path}' does not exist!")
374 .format(path=thisconfig['sdk_path']))
376 if not os.path.isdir(thisconfig['sdk_path']):
377 logging.critical(_("Android SDK path '{path}' is not a directory!")
378 .format(path=thisconfig['sdk_path']))
380 for d in ['build-tools', 'platform-tools', 'tools']:
381 if not os.path.isdir(os.path.join(thisconfig['sdk_path'], d)):
382 logging.critical(_("Android SDK '{path}' does not have '{dirname}' installed!")
383 .format(path=thisconfig['sdk_path'], dirname=d))
388 def ensure_build_tools_exists(thisconfig):
389 if not test_sdk_exists(thisconfig):
390 raise FDroidException(_("Android SDK not found!"))
391 build_tools = os.path.join(thisconfig['sdk_path'], 'build-tools')
392 versioned_build_tools = os.path.join(build_tools, thisconfig['build_tools'])
393 if not os.path.isdir(versioned_build_tools):
394 raise FDroidException(
395 _("Android Build Tools path '{path}' does not exist!")
396 .format(path=versioned_build_tools))
399 def get_local_metadata_files():
400 '''get any metadata files local to an app's source repo
402 This tries to ignore anything that does not count as app metdata,
403 including emacs cruft ending in ~ and the .fdroid.key*pass.txt files.
406 return glob.glob('.fdroid.[a-jl-z]*[a-rt-z]')
409 def read_pkg_args(args, allow_vercodes=False):
411 :param args: arguments in the form of multiple appid:[vc] strings
412 :returns: a dictionary with the set of vercodes specified for each package
420 if allow_vercodes and ':' in p:
421 package, vercode = p.split(':')
423 package, vercode = p, None
424 if package not in vercodes:
425 vercodes[package] = [vercode] if vercode else []
427 elif vercode and vercode not in vercodes[package]:
428 vercodes[package] += [vercode] if vercode else []
433 def read_app_args(args, allapps, allow_vercodes=False):
435 On top of what read_pkg_args does, this returns the whole app metadata, but
436 limiting the builds list to the builds matching the vercodes specified.
439 vercodes = read_pkg_args(args, allow_vercodes)
445 for appid, app in allapps.items():
446 if appid in vercodes:
449 if len(apps) != len(vercodes):
452 logging.critical(_("No such package: %s") % p)
453 raise FDroidException(_("Found invalid appids in arguments"))
455 raise FDroidException(_("No packages specified"))
458 for appid, app in apps.items():
462 app.builds = [b for b in app.builds if b.versionCode in vc]
463 if len(app.builds) != len(vercodes[appid]):
465 allvcs = [b.versionCode for b in app.builds]
466 for v in vercodes[appid]:
468 logging.critical(_("No such versionCode {versionCode} for app {appid}")
469 .format(versionCode=v, appid=appid))
472 raise FDroidException(_("Found invalid versionCodes for some apps"))
477 def get_extension(filename):
478 base, ext = os.path.splitext(filename)
481 return base, ext.lower()[1:]
484 def has_extension(filename, ext):
485 _, f_ext = get_extension(filename)
489 publish_name_regex = re.compile(r"^(.+)_([0-9]+)\.(apk|zip)$")
492 def clean_description(description):
493 'Remove unneeded newlines and spaces from a block of description text'
495 # this is split up by paragraph to make removing the newlines easier
496 for paragraph in re.split(r'\n\n', description):
497 paragraph = re.sub('\r', '', paragraph)
498 paragraph = re.sub('\n', ' ', paragraph)
499 paragraph = re.sub(' {2,}', ' ', paragraph)
500 paragraph = re.sub('^\s*(\w)', r'\1', paragraph)
501 returnstring += paragraph + '\n\n'
502 return returnstring.rstrip('\n')
505 def publishednameinfo(filename):
506 filename = os.path.basename(filename)
507 m = publish_name_regex.match(filename)
509 result = (m.group(1), m.group(2))
510 except AttributeError:
511 raise FDroidException(_("Invalid name for published file: %s") % filename)
515 apk_release_filename = re.compile('(?P<appid>[a-zA-Z0-9_\.]+)_(?P<vercode>[0-9]+)\.apk')
516 apk_release_filename_with_sigfp = re.compile('(?P<appid>[a-zA-Z0-9_\.]+)_(?P<vercode>[0-9]+)_(?P<sigfp>[0-9a-f]{7})\.apk')
519 def apk_parse_release_filename(apkname):
520 """Parses the name of an APK file according the F-Droids APK naming
521 scheme and returns the tokens.
523 WARNING: Returned values don't necessarily represent the APKs actual
524 properties, the are just paresed from the file name.
526 :returns: A triplet containing (appid, versionCode, signer), where appid
527 should be the package name, versionCode should be the integer
528 represion of the APKs version and signer should be the first 7 hex
529 digists of the sha256 signing key fingerprint which was used to sign
532 m = apk_release_filename_with_sigfp.match(apkname)
534 return m.group('appid'), m.group('vercode'), m.group('sigfp')
535 m = apk_release_filename.match(apkname)
537 return m.group('appid'), m.group('vercode'), None
538 return None, None, None
541 def get_release_filename(app, build):
543 return "%s_%s.%s" % (app.id, build.versionCode, get_file_extension(build.output))
545 return "%s_%s.apk" % (app.id, build.versionCode)
548 def get_toolsversion_logname(app, build):
549 return "%s_%s_toolsversion.log" % (app.id, build.versionCode)
552 def getsrcname(app, build):
553 return "%s_%s_src.tar.gz" % (app.id, build.versionCode)
565 return '%s (%s)' % (app.CurrentVersion, app.CurrentVersionCode)
568 def get_build_dir(app):
569 '''get the dir that this app will be built in'''
571 if app.RepoType == 'srclib':
572 return os.path.join('build', 'srclib', app.Repo)
574 return os.path.join('build', app.id)
578 '''checkout code from VCS and return instance of vcs and the build dir'''
579 build_dir = get_build_dir(app)
581 # Set up vcs interface and make sure we have the latest code...
582 logging.debug("Getting {0} vcs interface for {1}"
583 .format(app.RepoType, app.Repo))
584 if app.RepoType == 'git' and os.path.exists('.fdroid.yml'):
588 vcs = getvcs(app.RepoType, remote, build_dir)
589 logging.debug("Using %s" % vcs.clientversion())
591 return vcs, build_dir
594 def getvcs(vcstype, remote, local):
596 return vcs_git(remote, local)
597 if vcstype == 'git-svn':
598 return vcs_gitsvn(remote, local)
600 return vcs_hg(remote, local)
602 return vcs_bzr(remote, local)
603 if vcstype == 'srclib':
604 if local != os.path.join('build', 'srclib', remote):
605 raise VCSException("Error: srclib paths are hard-coded!")
606 return getsrclib(remote, os.path.join('build', 'srclib'), raw=True)
608 raise VCSException("Deprecated vcs type 'svn' - please use 'git-svn' instead")
609 raise VCSException("Invalid vcs type " + vcstype)
612 def getsrclibvcs(name):
613 if name not in fdroidserver.metadata.srclibs:
614 raise VCSException("Missing srclib " + name)
615 return fdroidserver.metadata.srclibs[name]['Repo Type']
620 def __init__(self, remote, local):
622 # svn, git-svn and bzr may require auth
624 if self.repotype() in ('git-svn', 'bzr'):
626 if self.repotype == 'git-svn':
627 raise VCSException("Authentication is not supported for git-svn")
628 self.username, remote = remote.split('@')
629 if ':' not in self.username:
630 raise VCSException(_("Password required with username"))
631 self.username, self.password = self.username.split(':')
635 self.clone_failed = False
636 self.refreshed = False
642 def clientversion(self):
643 versionstr = FDroidPopen(self.clientversioncmd()).output
644 return versionstr[0:versionstr.find('\n')]
646 def clientversioncmd(self):
649 def gotorevision(self, rev, refresh=True):
650 """Take the local repository to a clean version of the given
651 revision, which is specificed in the VCS's native
652 format. Beforehand, the repository can be dirty, or even
653 non-existent. If the repository does already exist locally, it
654 will be updated from the origin, but only once in the lifetime
655 of the vcs object. None is acceptable for 'rev' if you know
656 you are cloning a clean copy of the repo - otherwise it must
657 specify a valid revision.
660 if self.clone_failed:
661 raise VCSException(_("Downloading the repository already failed once, not trying again."))
663 # The .fdroidvcs-id file for a repo tells us what VCS type
664 # and remote that directory was created from, allowing us to drop it
665 # automatically if either of those things changes.
666 fdpath = os.path.join(self.local, '..',
667 '.fdroidvcs-' + os.path.basename(self.local))
668 fdpath = os.path.normpath(fdpath)
669 cdata = self.repotype() + ' ' + self.remote
672 if os.path.exists(self.local):
673 if os.path.exists(fdpath):
674 with open(fdpath, 'r') as f:
675 fsdata = f.read().strip()
680 logging.info("Repository details for %s changed - deleting" % (
684 logging.info("Repository details for %s missing - deleting" % (
687 shutil.rmtree(self.local)
691 self.refreshed = True
694 self.gotorevisionx(rev)
695 except FDroidException as e:
698 # If necessary, write the .fdroidvcs file.
699 if writeback and not self.clone_failed:
700 os.makedirs(os.path.dirname(fdpath), exist_ok=True)
701 with open(fdpath, 'w+') as f:
707 def gotorevisionx(self, rev): # pylint: disable=unused-argument
708 """Derived classes need to implement this.
710 It's called once basic checking has been performed.
712 raise VCSException("This VCS type doesn't define gotorevisionx")
714 # Initialise and update submodules
715 def initsubmodules(self):
716 raise VCSException('Submodules not supported for this vcs type')
718 # Get a list of all known tags
720 if not self._gettags:
721 raise VCSException('gettags not supported for this vcs type')
723 for tag in self._gettags():
724 if re.match('[-A-Za-z0-9_. /]+$', tag):
728 def latesttags(self):
729 """Get a list of all the known tags, sorted from newest to oldest"""
730 raise VCSException('latesttags not supported for this vcs type')
733 """Get current commit reference (hash, revision, etc)"""
734 raise VCSException('getref not supported for this vcs type')
737 """Returns the srclib (name, path) used in setting up the current revision, or None."""
746 def clientversioncmd(self):
747 return ['git', '--version']
750 """If the local directory exists, but is somehow not a git repository,
751 git will traverse up the directory tree until it finds one
752 that is (i.e. fdroidserver) and then we'll proceed to destroy
753 it! This is called as a safety check.
757 p = FDroidPopen(['git', 'rev-parse', '--show-toplevel'], cwd=self.local, output=False)
758 result = p.output.rstrip()
759 if not result.endswith(self.local):
760 raise VCSException('Repository mismatch')
762 def gotorevisionx(self, rev):
763 if not os.path.exists(self.local):
765 p = FDroidPopen(['git', 'clone', self.remote, self.local])
766 if p.returncode != 0:
767 self.clone_failed = True
768 raise VCSException("Git clone failed", p.output)
772 # Discard any working tree changes
773 p = FDroidPopen(['git', 'submodule', 'foreach', '--recursive',
774 'git', 'reset', '--hard'], cwd=self.local, output=False)
775 if p.returncode != 0:
776 raise VCSException(_("Git reset failed"), p.output)
777 # Remove untracked files now, in case they're tracked in the target
778 # revision (it happens!)
779 p = FDroidPopen(['git', 'submodule', 'foreach', '--recursive',
780 'git', 'clean', '-dffx'], cwd=self.local, output=False)
781 if p.returncode != 0:
782 raise VCSException(_("Git clean failed"), p.output)
783 if not self.refreshed:
784 # Get latest commits and tags from remote
785 p = FDroidPopen(['git', 'fetch', 'origin'], cwd=self.local)
786 if p.returncode != 0:
787 raise VCSException(_("Git fetch failed"), p.output)
788 p = FDroidPopen(['git', 'fetch', '--prune', '--tags', 'origin'], cwd=self.local, output=False)
789 if p.returncode != 0:
790 raise VCSException(_("Git fetch failed"), p.output)
791 # Recreate origin/HEAD as git clone would do it, in case it disappeared
792 p = FDroidPopen(['git', 'remote', 'set-head', 'origin', '--auto'], cwd=self.local, output=False)
793 if p.returncode != 0:
794 lines = p.output.splitlines()
795 if 'Multiple remote HEAD branches' not in lines[0]:
796 raise VCSException(_("Git remote set-head failed"), p.output)
797 branch = lines[1].split(' ')[-1]
798 p2 = FDroidPopen(['git', 'remote', 'set-head', 'origin', branch], cwd=self.local, output=False)
799 if p2.returncode != 0:
800 raise VCSException(_("Git remote set-head failed"), p.output + '\n' + p2.output)
801 self.refreshed = True
802 # origin/HEAD is the HEAD of the remote, e.g. the "default branch" on
803 # a github repo. Most of the time this is the same as origin/master.
804 rev = rev or 'origin/HEAD'
805 p = FDroidPopen(['git', 'checkout', '-f', rev], cwd=self.local, output=False)
806 if p.returncode != 0:
807 raise VCSException(_("Git checkout of '%s' failed") % rev, p.output)
808 # Get rid of any uncontrolled files left behind
809 p = FDroidPopen(['git', 'clean', '-dffx'], cwd=self.local, output=False)
810 if p.returncode != 0:
811 raise VCSException(_("Git clean failed"), p.output)
813 def initsubmodules(self):
815 submfile = os.path.join(self.local, '.gitmodules')
816 if not os.path.isfile(submfile):
817 raise VCSException(_("No git submodules available"))
819 # fix submodules not accessible without an account and public key auth
820 with open(submfile, 'r') as f:
821 lines = f.readlines()
822 with open(submfile, 'w') as f:
824 if 'git@github.com' in line:
825 line = line.replace('git@github.com:', 'https://github.com/')
826 if 'git@gitlab.com' in line:
827 line = line.replace('git@gitlab.com:', 'https://gitlab.com/')
830 p = FDroidPopen(['git', 'submodule', 'sync'], cwd=self.local, output=False)
831 if p.returncode != 0:
832 raise VCSException(_("Git submodule sync failed"), p.output)
833 p = FDroidPopen(['git', 'submodule', 'update', '--init', '--force', '--recursive'], cwd=self.local)
834 if p.returncode != 0:
835 raise VCSException(_("Git submodule update failed"), p.output)
839 p = FDroidPopen(['git', 'tag'], cwd=self.local, output=False)
840 return p.output.splitlines()
842 tag_format = re.compile(r'tag: ([^),]*)')
844 def latesttags(self):
846 p = FDroidPopen(['git', 'log', '--tags',
847 '--simplify-by-decoration', '--pretty=format:%d'],
848 cwd=self.local, output=False)
850 for line in p.output.splitlines():
851 for tag in self.tag_format.findall(line):
856 class vcs_gitsvn(vcs):
861 def clientversioncmd(self):
862 return ['git', 'svn', '--version']
865 """If the local directory exists, but is somehow not a git repository,
866 git will traverse up the directory tree until it finds one that
867 is (i.e. fdroidserver) and then we'll proceed to destory it!
868 This is called as a safety check.
871 p = FDroidPopen(['git', 'rev-parse', '--show-toplevel'], cwd=self.local, output=False)
872 result = p.output.rstrip()
873 if not result.endswith(self.local):
874 raise VCSException('Repository mismatch')
876 def gotorevisionx(self, rev):
877 if not os.path.exists(self.local):
879 gitsvn_args = ['git', 'svn', 'clone']
880 if ';' in self.remote:
881 remote_split = self.remote.split(';')
882 for i in remote_split[1:]:
883 if i.startswith('trunk='):
884 gitsvn_args.extend(['-T', i[6:]])
885 elif i.startswith('tags='):
886 gitsvn_args.extend(['-t', i[5:]])
887 elif i.startswith('branches='):
888 gitsvn_args.extend(['-b', i[9:]])
889 gitsvn_args.extend([remote_split[0], self.local])
890 p = FDroidPopen(gitsvn_args, output=False)
891 if p.returncode != 0:
892 self.clone_failed = True
893 raise VCSException("Git svn clone failed", p.output)
895 gitsvn_args.extend([self.remote, self.local])
896 p = FDroidPopen(gitsvn_args, output=False)
897 if p.returncode != 0:
898 self.clone_failed = True
899 raise VCSException("Git svn clone failed", p.output)
903 # Discard any working tree changes
904 p = FDroidPopen(['git', 'reset', '--hard'], cwd=self.local, output=False)
905 if p.returncode != 0:
906 raise VCSException("Git reset failed", p.output)
907 # Remove untracked files now, in case they're tracked in the target
908 # revision (it happens!)
909 p = FDroidPopen(['git', 'clean', '-dffx'], cwd=self.local, output=False)
910 if p.returncode != 0:
911 raise VCSException("Git clean failed", p.output)
912 if not self.refreshed:
913 # Get new commits, branches and tags from repo
914 p = FDroidPopen(['git', 'svn', 'fetch'], cwd=self.local, output=False)
915 if p.returncode != 0:
916 raise VCSException("Git svn fetch failed")
917 p = FDroidPopen(['git', 'svn', 'rebase'], cwd=self.local, output=False)
918 if p.returncode != 0:
919 raise VCSException("Git svn rebase failed", p.output)
920 self.refreshed = True
922 rev = rev or 'master'
924 nospaces_rev = rev.replace(' ', '%20')
925 # Try finding a svn tag
926 for treeish in ['origin/', '']:
927 p = FDroidPopen(['git', 'checkout', treeish + 'tags/' + nospaces_rev], cwd=self.local, output=False)
928 if p.returncode == 0:
930 if p.returncode != 0:
931 # No tag found, normal svn rev translation
932 # Translate svn rev into git format
933 rev_split = rev.split('/')
936 for treeish in ['origin/', '']:
937 if len(rev_split) > 1:
938 treeish += rev_split[0]
939 svn_rev = rev_split[1]
942 # if no branch is specified, then assume trunk (i.e. 'master' branch):
946 svn_rev = svn_rev if svn_rev[0] == 'r' else 'r' + svn_rev
948 p = FDroidPopen(['git', 'svn', 'find-rev', '--before', svn_rev, treeish], cwd=self.local, output=False)
949 git_rev = p.output.rstrip()
951 if p.returncode == 0 and git_rev:
954 if p.returncode != 0 or not git_rev:
955 # Try a plain git checkout as a last resort
956 p = FDroidPopen(['git', 'checkout', rev], cwd=self.local, output=False)
957 if p.returncode != 0:
958 raise VCSException("No git treeish found and direct git checkout of '%s' failed" % rev, p.output)
960 # Check out the git rev equivalent to the svn rev
961 p = FDroidPopen(['git', 'checkout', git_rev], cwd=self.local, output=False)
962 if p.returncode != 0:
963 raise VCSException(_("Git checkout of '%s' failed") % rev, p.output)
965 # Get rid of any uncontrolled files left behind
966 p = FDroidPopen(['git', 'clean', '-dffx'], cwd=self.local, output=False)
967 if p.returncode != 0:
968 raise VCSException(_("Git clean failed"), p.output)
972 for treeish in ['origin/', '']:
973 d = os.path.join(self.local, '.git', 'svn', 'refs', 'remotes', treeish, 'tags')
979 p = FDroidPopen(['git', 'svn', 'find-rev', 'HEAD'], cwd=self.local, output=False)
980 if p.returncode != 0:
982 return p.output.strip()
990 def clientversioncmd(self):
991 return ['hg', '--version']
993 def gotorevisionx(self, rev):
994 if not os.path.exists(self.local):
995 p = FDroidPopen(['hg', 'clone', self.remote, self.local], output=False)
996 if p.returncode != 0:
997 self.clone_failed = True
998 raise VCSException("Hg clone failed", p.output)
1000 p = FDroidPopen(['hg', 'status', '-uS'], cwd=self.local, output=False)
1001 if p.returncode != 0:
1002 raise VCSException("Hg status failed", p.output)
1003 for line in p.output.splitlines():
1004 if not line.startswith('? '):
1005 raise VCSException("Unexpected output from hg status -uS: " + line)
1006 FDroidPopen(['rm', '-rf', line[2:]], cwd=self.local, output=False)
1007 if not self.refreshed:
1008 p = FDroidPopen(['hg', 'pull'], cwd=self.local, output=False)
1009 if p.returncode != 0:
1010 raise VCSException("Hg pull failed", p.output)
1011 self.refreshed = True
1013 rev = rev or 'default'
1016 p = FDroidPopen(['hg', 'update', '-C', rev], cwd=self.local, output=False)
1017 if p.returncode != 0:
1018 raise VCSException("Hg checkout of '%s' failed" % rev, p.output)
1019 p = FDroidPopen(['hg', 'purge', '--all'], cwd=self.local, output=False)
1020 # Also delete untracked files, we have to enable purge extension for that:
1021 if "'purge' is provided by the following extension" in p.output:
1022 with open(os.path.join(self.local, '.hg', 'hgrc'), "a") as myfile:
1023 myfile.write("\n[extensions]\nhgext.purge=\n")
1024 p = FDroidPopen(['hg', 'purge', '--all'], cwd=self.local, output=False)
1025 if p.returncode != 0:
1026 raise VCSException("HG purge failed", p.output)
1027 elif p.returncode != 0:
1028 raise VCSException("HG purge failed", p.output)
1031 p = FDroidPopen(['hg', 'tags', '-q'], cwd=self.local, output=False)
1032 return p.output.splitlines()[1:]
1040 def clientversioncmd(self):
1041 return ['bzr', '--version']
1043 def gotorevisionx(self, rev):
1044 if not os.path.exists(self.local):
1045 p = FDroidPopen(['bzr', 'branch', self.remote, self.local], output=False)
1046 if p.returncode != 0:
1047 self.clone_failed = True
1048 raise VCSException("Bzr branch failed", p.output)
1050 p = FDroidPopen(['bzr', 'clean-tree', '--force', '--unknown', '--ignored'], cwd=self.local, output=False)
1051 if p.returncode != 0:
1052 raise VCSException("Bzr revert failed", p.output)
1053 if not self.refreshed:
1054 p = FDroidPopen(['bzr', 'pull'], cwd=self.local, output=False)
1055 if p.returncode != 0:
1056 raise VCSException("Bzr update failed", p.output)
1057 self.refreshed = True
1059 revargs = list(['-r', rev] if rev else [])
1060 p = FDroidPopen(['bzr', 'revert'] + revargs, cwd=self.local, output=False)
1061 if p.returncode != 0:
1062 raise VCSException("Bzr revert of '%s' failed" % rev, p.output)
1065 p = FDroidPopen(['bzr', 'tags'], cwd=self.local, output=False)
1066 return [tag.split(' ')[0].strip() for tag in
1067 p.output.splitlines()]
1070 def unescape_string(string):
1073 if string[0] == '"' and string[-1] == '"':
1076 return string.replace("\\'", "'")
1079 def retrieve_string(app_dir, string, xmlfiles=None):
1081 if not string.startswith('@string/'):
1082 return unescape_string(string)
1084 if xmlfiles is None:
1087 os.path.join(app_dir, 'res'),
1088 os.path.join(app_dir, 'src', 'main', 'res'),
1090 for root, dirs, files in os.walk(res_dir):
1091 if os.path.basename(root) == 'values':
1092 xmlfiles += [os.path.join(root, x) for x in files if x.endswith('.xml')]
1094 name = string[len('@string/'):]
1096 def element_content(element):
1097 if element.text is None:
1099 s = XMLElementTree.tostring(element, encoding='utf-8', method='text')
1100 return s.decode('utf-8').strip()
1102 for path in xmlfiles:
1103 if not os.path.isfile(path):
1105 xml = parse_xml(path)
1106 element = xml.find('string[@name="' + name + '"]')
1107 if element is not None:
1108 content = element_content(element)
1109 return retrieve_string(app_dir, content, xmlfiles)
1114 def retrieve_string_singleline(app_dir, string, xmlfiles=None):
1115 return retrieve_string(app_dir, string, xmlfiles).replace('\n', ' ').strip()
1118 def manifest_paths(app_dir, flavours):
1119 '''Return list of existing files that will be used to find the highest vercode'''
1121 possible_manifests = \
1122 [os.path.join(app_dir, 'AndroidManifest.xml'),
1123 os.path.join(app_dir, 'src', 'main', 'AndroidManifest.xml'),
1124 os.path.join(app_dir, 'src', 'AndroidManifest.xml'),
1125 os.path.join(app_dir, 'build.gradle')]
1127 for flavour in flavours:
1128 if flavour == 'yes':
1130 possible_manifests.append(
1131 os.path.join(app_dir, 'src', flavour, 'AndroidManifest.xml'))
1133 return [path for path in possible_manifests if os.path.isfile(path)]
1136 def fetch_real_name(app_dir, flavours):
1137 '''Retrieve the package name. Returns the name, or None if not found.'''
1138 for path in manifest_paths(app_dir, flavours):
1139 if not has_extension(path, 'xml') or not os.path.isfile(path):
1141 logging.debug("fetch_real_name: Checking manifest at " + path)
1142 xml = parse_xml(path)
1143 app = xml.find('application')
1146 if "{http://schemas.android.com/apk/res/android}label" not in app.attrib:
1148 label = app.attrib["{http://schemas.android.com/apk/res/android}label"]
1149 result = retrieve_string_singleline(app_dir, label)
1151 result = result.strip()
1156 def get_library_references(root_dir):
1158 proppath = os.path.join(root_dir, 'project.properties')
1159 if not os.path.isfile(proppath):
1161 with open(proppath, 'r', encoding='iso-8859-1') as f:
1163 if not line.startswith('android.library.reference.'):
1165 path = line.split('=')[1].strip()
1166 relpath = os.path.join(root_dir, path)
1167 if not os.path.isdir(relpath):
1169 logging.debug("Found subproject at %s" % path)
1170 libraries.append(path)
1174 def ant_subprojects(root_dir):
1175 subprojects = get_library_references(root_dir)
1176 for subpath in subprojects:
1177 subrelpath = os.path.join(root_dir, subpath)
1178 for p in get_library_references(subrelpath):
1179 relp = os.path.normpath(os.path.join(subpath, p))
1180 if relp not in subprojects:
1181 subprojects.insert(0, relp)
1185 def remove_debuggable_flags(root_dir):
1186 # Remove forced debuggable flags
1187 logging.debug("Removing debuggable flags from %s" % root_dir)
1188 for root, dirs, files in os.walk(root_dir):
1189 if 'AndroidManifest.xml' in files:
1190 regsub_file(r'android:debuggable="[^"]*"',
1192 os.path.join(root, 'AndroidManifest.xml'))
1195 vcsearch_g = re.compile(r'''.*[Vv]ersionCode[ =]+["']*([0-9]+)["']*''').search
1196 vnsearch_g = re.compile(r'.*[Vv]ersionName *=* *(["\'])((?:(?=(\\?))\3.)*?)\1.*').search
1197 psearch_g = re.compile(r'.*(packageName|applicationId) *=* *["\']([^"]+)["\'].*').search
1200 def app_matches_packagename(app, package):
1203 appid = app.UpdateCheckName or app.id
1204 if appid is None or appid == "Ignore":
1206 return appid == package
1209 def parse_androidmanifests(paths, app):
1211 Extract some information from the AndroidManifest.xml at the given path.
1212 Returns (version, vercode, package), any or all of which might be None.
1213 All values returned are strings.
1216 ignoreversions = app.UpdateCheckIgnore
1217 ignoresearch = re.compile(ignoreversions).search if ignoreversions else None
1220 return (None, None, None)
1228 if not os.path.isfile(path):
1231 logging.debug(_("Parsing manifest at '{path}'").format(path=path))
1236 if has_extension(path, 'gradle'):
1237 with open(path, 'r') as f:
1239 if gradle_comment.match(line):
1241 # Grab first occurence of each to avoid running into
1242 # alternative flavours and builds.
1244 matches = psearch_g(line)
1246 s = matches.group(2)
1247 if app_matches_packagename(app, s):
1250 matches = vnsearch_g(line)
1252 version = matches.group(2)
1254 matches = vcsearch_g(line)
1256 vercode = matches.group(1)
1259 xml = parse_xml(path)
1260 if "package" in xml.attrib:
1261 s = xml.attrib["package"]
1262 if app_matches_packagename(app, s):
1264 if "{http://schemas.android.com/apk/res/android}versionName" in xml.attrib:
1265 version = xml.attrib["{http://schemas.android.com/apk/res/android}versionName"]
1266 base_dir = os.path.dirname(path)
1267 version = retrieve_string_singleline(base_dir, version)
1268 if "{http://schemas.android.com/apk/res/android}versionCode" in xml.attrib:
1269 a = xml.attrib["{http://schemas.android.com/apk/res/android}versionCode"]
1270 if string_is_integer(a):
1273 logging.warning(_("Problem with xml at '{path}'").format(path=path))
1275 # Remember package name, may be defined separately from version+vercode
1277 package = max_package
1279 logging.debug("..got package={0}, version={1}, vercode={2}"
1280 .format(package, version, vercode))
1282 # Always grab the package name and version name in case they are not
1283 # together with the highest version code
1284 if max_package is None and package is not None:
1285 max_package = package
1286 if max_version is None and version is not None:
1287 max_version = version
1289 if vercode is not None \
1290 and (max_vercode is None or vercode > max_vercode):
1291 if not ignoresearch or not ignoresearch(version):
1292 if version is not None:
1293 max_version = version
1294 if vercode is not None:
1295 max_vercode = vercode
1296 if package is not None:
1297 max_package = package
1299 max_version = "Ignore"
1301 if max_version is None:
1302 max_version = "Unknown"
1304 if max_package and not is_valid_package_name(max_package):
1305 raise FDroidException(_("Invalid package name {0}").format(max_package))
1307 return (max_version, max_vercode, max_package)
1310 def is_valid_package_name(name):
1311 return re.match("[A-Za-z_][A-Za-z_0-9.]+$", name)
1314 def getsrclib(spec, srclib_dir, subdir=None, basepath=False,
1315 raw=False, prepare=True, preponly=False, refresh=True,
1317 """Get the specified source library.
1319 Returns the path to it. Normally this is the path to be used when
1320 referencing it, which may be a subdirectory of the actual project. If
1321 you want the base directory of the project, pass 'basepath=True'.
1330 name, ref = spec.split('@')
1332 number, name = name.split(':', 1)
1334 name, subdir = name.split('/', 1)
1336 if name not in fdroidserver.metadata.srclibs:
1337 raise VCSException('srclib ' + name + ' not found.')
1339 srclib = fdroidserver.metadata.srclibs[name]
1341 sdir = os.path.join(srclib_dir, name)
1344 vcs = getvcs(srclib["Repo Type"], srclib["Repo"], sdir)
1345 vcs.srclib = (name, number, sdir)
1347 vcs.gotorevision(ref, refresh)
1354 libdir = os.path.join(sdir, subdir)
1355 elif srclib["Subdir"]:
1356 for subdir in srclib["Subdir"]:
1357 libdir_candidate = os.path.join(sdir, subdir)
1358 if os.path.exists(libdir_candidate):
1359 libdir = libdir_candidate
1365 remove_signing_keys(sdir)
1366 remove_debuggable_flags(sdir)
1370 if srclib["Prepare"]:
1371 cmd = replace_config_vars(srclib["Prepare"], build)
1373 p = FDroidPopen(['bash', '-x', '-c', cmd], cwd=libdir)
1374 if p.returncode != 0:
1375 raise BuildException("Error running prepare command for srclib %s"
1381 return (name, number, libdir)
1384 gradle_version_regex = re.compile(r"[^/]*'com\.android\.tools\.build:gradle:([^\.]+\.[^\.]+).*'.*")
1387 def prepare_source(vcs, app, build, build_dir, srclib_dir, extlib_dir, onserver=False, refresh=True):
1388 """ Prepare the source code for a particular build
1390 :param vcs: the appropriate vcs object for the application
1391 :param app: the application details from the metadata
1392 :param build: the build details from the metadata
1393 :param build_dir: the path to the build directory, usually 'build/app.id'
1394 :param srclib_dir: the path to the source libraries directory, usually 'build/srclib'
1395 :param extlib_dir: the path to the external libraries directory, usually 'build/extlib'
1397 Returns the (root, srclibpaths) where:
1398 :param root: is the root directory, which may be the same as 'build_dir' or may
1399 be a subdirectory of it.
1400 :param srclibpaths: is information on the srclibs being used
1403 # Optionally, the actual app source can be in a subdirectory
1405 root_dir = os.path.join(build_dir, build.subdir)
1407 root_dir = build_dir
1409 # Get a working copy of the right revision
1410 logging.info("Getting source for revision " + build.commit)
1411 vcs.gotorevision(build.commit, refresh)
1413 # Initialise submodules if required
1414 if build.submodules:
1415 logging.info(_("Initialising submodules"))
1416 vcs.initsubmodules()
1418 # Check that a subdir (if we're using one) exists. This has to happen
1419 # after the checkout, since it might not exist elsewhere
1420 if not os.path.exists(root_dir):
1421 raise BuildException('Missing subdir ' + root_dir)
1423 # Run an init command if one is required
1425 cmd = replace_config_vars(build.init, build)
1426 logging.info("Running 'init' commands in %s" % root_dir)
1428 p = FDroidPopen(['bash', '-x', '-c', cmd], cwd=root_dir)
1429 if p.returncode != 0:
1430 raise BuildException("Error running init command for %s:%s" %
1431 (app.id, build.versionName), p.output)
1433 # Apply patches if any
1435 logging.info("Applying patches")
1436 for patch in build.patch:
1437 patch = patch.strip()
1438 logging.info("Applying " + patch)
1439 patch_path = os.path.join('metadata', app.id, patch)
1440 p = FDroidPopen(['patch', '-p1', '-i', os.path.abspath(patch_path)], cwd=build_dir)
1441 if p.returncode != 0:
1442 raise BuildException("Failed to apply patch %s" % patch_path)
1444 # Get required source libraries
1447 logging.info("Collecting source libraries")
1448 for lib in build.srclibs:
1449 srclibpaths.append(getsrclib(lib, srclib_dir, build, preponly=onserver,
1450 refresh=refresh, build=build))
1452 for name, number, libpath in srclibpaths:
1453 place_srclib(root_dir, int(number) if number else None, libpath)
1455 basesrclib = vcs.getsrclib()
1456 # If one was used for the main source, add that too.
1458 srclibpaths.append(basesrclib)
1460 # Update the local.properties file
1461 localprops = [os.path.join(build_dir, 'local.properties')]
1463 parts = build.subdir.split(os.sep)
1466 cur = os.path.join(cur, d)
1467 localprops += [os.path.join(cur, 'local.properties')]
1468 for path in localprops:
1470 if os.path.isfile(path):
1471 logging.info("Updating local.properties file at %s" % path)
1472 with open(path, 'r', encoding='iso-8859-1') as f:
1476 logging.info("Creating local.properties file at %s" % path)
1477 # Fix old-fashioned 'sdk-location' by copying
1478 # from sdk.dir, if necessary
1480 sdkloc = re.match(r".*^sdk.dir=(\S+)$.*", props,
1481 re.S | re.M).group(1)
1482 props += "sdk-location=%s\n" % sdkloc
1484 props += "sdk.dir=%s\n" % config['sdk_path']
1485 props += "sdk-location=%s\n" % config['sdk_path']
1486 ndk_path = build.ndk_path()
1487 # if for any reason the path isn't valid or the directory
1488 # doesn't exist, some versions of Gradle will error with a
1489 # cryptic message (even if the NDK is not even necessary).
1490 # https://gitlab.com/fdroid/fdroidserver/issues/171
1491 if ndk_path and os.path.exists(ndk_path):
1493 props += "ndk.dir=%s\n" % ndk_path
1494 props += "ndk-location=%s\n" % ndk_path
1495 # Add java.encoding if necessary
1497 props += "java.encoding=%s\n" % build.encoding
1498 with open(path, 'w', encoding='iso-8859-1') as f:
1502 if build.build_method() == 'gradle':
1503 flavours = build.gradle
1506 n = build.target.split('-')[1]
1507 regsub_file(r'compileSdkVersion[ =]+[0-9]+',
1508 r'compileSdkVersion %s' % n,
1509 os.path.join(root_dir, 'build.gradle'))
1511 # Remove forced debuggable flags
1512 remove_debuggable_flags(root_dir)
1514 # Insert version code and number into the manifest if necessary
1515 if build.forceversion:
1516 logging.info("Changing the version name")
1517 for path in manifest_paths(root_dir, flavours):
1518 if not os.path.isfile(path):
1520 if has_extension(path, 'xml'):
1521 regsub_file(r'android:versionName="[^"]*"',
1522 r'android:versionName="%s"' % build.versionName,
1524 elif has_extension(path, 'gradle'):
1525 regsub_file(r"""(\s*)versionName[\s'"=]+.*""",
1526 r"""\1versionName '%s'""" % build.versionName,
1529 if build.forcevercode:
1530 logging.info("Changing the version code")
1531 for path in manifest_paths(root_dir, flavours):
1532 if not os.path.isfile(path):
1534 if has_extension(path, 'xml'):
1535 regsub_file(r'android:versionCode="[^"]*"',
1536 r'android:versionCode="%s"' % build.versionCode,
1538 elif has_extension(path, 'gradle'):
1539 regsub_file(r'versionCode[ =]+[0-9]+',
1540 r'versionCode %s' % build.versionCode,
1543 # Delete unwanted files
1545 logging.info(_("Removing specified files"))
1546 for part in getpaths(build_dir, build.rm):
1547 dest = os.path.join(build_dir, part)
1548 logging.info("Removing {0}".format(part))
1549 if os.path.lexists(dest):
1550 if os.path.islink(dest):
1551 FDroidPopen(['unlink', dest], output=False)
1553 FDroidPopen(['rm', '-rf', dest], output=False)
1555 logging.info("...but it didn't exist")
1557 remove_signing_keys(build_dir)
1559 # Add required external libraries
1561 logging.info("Collecting prebuilt libraries")
1562 libsdir = os.path.join(root_dir, 'libs')
1563 if not os.path.exists(libsdir):
1565 for lib in build.extlibs:
1567 logging.info("...installing extlib {0}".format(lib))
1568 libf = os.path.basename(lib)
1569 libsrc = os.path.join(extlib_dir, lib)
1570 if not os.path.exists(libsrc):
1571 raise BuildException("Missing extlib file {0}".format(libsrc))
1572 shutil.copyfile(libsrc, os.path.join(libsdir, libf))
1574 # Run a pre-build command if one is required
1576 logging.info("Running 'prebuild' commands in %s" % root_dir)
1578 cmd = replace_config_vars(build.prebuild, build)
1580 # Substitute source library paths into prebuild commands
1581 for name, number, libpath in srclibpaths:
1582 libpath = os.path.relpath(libpath, root_dir)
1583 cmd = cmd.replace('$$' + name + '$$', libpath)
1585 p = FDroidPopen(['bash', '-x', '-c', cmd], cwd=root_dir)
1586 if p.returncode != 0:
1587 raise BuildException("Error running prebuild command for %s:%s" %
1588 (app.id, build.versionName), p.output)
1590 # Generate (or update) the ant build file, build.xml...
1591 if build.build_method() == 'ant' and build.androidupdate != ['no']:
1592 parms = ['android', 'update', 'lib-project']
1593 lparms = ['android', 'update', 'project']
1596 parms += ['-t', build.target]
1597 lparms += ['-t', build.target]
1598 if build.androidupdate:
1599 update_dirs = build.androidupdate
1601 update_dirs = ant_subprojects(root_dir) + ['.']
1603 for d in update_dirs:
1604 subdir = os.path.join(root_dir, d)
1606 logging.debug("Updating main project")
1607 cmd = parms + ['-p', d]
1609 logging.debug("Updating subproject %s" % d)
1610 cmd = lparms + ['-p', d]
1611 p = SdkToolsPopen(cmd, cwd=root_dir)
1612 # Check to see whether an error was returned without a proper exit
1613 # code (this is the case for the 'no target set or target invalid'
1615 if p.returncode != 0 or p.output.startswith("Error: "):
1616 raise BuildException("Failed to update project at %s" % d, p.output)
1617 # Clean update dirs via ant
1619 logging.info("Cleaning subproject %s" % d)
1620 p = FDroidPopen(['ant', 'clean'], cwd=subdir)
1622 return (root_dir, srclibpaths)
1625 def getpaths_map(build_dir, globpaths):
1626 """Extend via globbing the paths from a field and return them as a map from original path to resulting paths"""
1630 full_path = os.path.join(build_dir, p)
1631 full_path = os.path.normpath(full_path)
1632 paths[p] = [r[len(build_dir) + 1:] for r in glob.glob(full_path)]
1634 raise FDroidException("glob path '%s' did not match any files/dirs" % p)
1638 def getpaths(build_dir, globpaths):
1639 """Extend via globbing the paths from a field and return them as a set"""
1640 paths_map = getpaths_map(build_dir, globpaths)
1642 for k, v in paths_map.items():
1649 return [int(sp) if sp.isdigit() else sp for sp in re.split(r'(\d+)', s)]
1653 """permanent store of existing APKs with the date they were added
1655 This is currently the only way to permanently store the "updated"
1660 '''Load filename/date info about previously seen APKs
1662 Since the appid and date strings both will never have spaces,
1663 this is parsed as a list from the end to allow the filename to
1664 have any combo of spaces.
1667 self.path = os.path.join('stats', 'known_apks.txt')
1669 if os.path.isfile(self.path):
1670 with open(self.path, 'r', encoding='utf8') as f:
1672 t = line.rstrip().split(' ')
1674 self.apks[t[0]] = (t[1], None)
1677 date = datetime.strptime(t[-1], '%Y-%m-%d')
1678 filename = line[0:line.rfind(appid) - 1]
1679 self.apks[filename] = (appid, date)
1680 self.changed = False
1682 def writeifchanged(self):
1683 if not self.changed:
1686 if not os.path.exists('stats'):
1690 for apk, app in self.apks.items():
1692 line = apk + ' ' + appid
1694 line += ' ' + added.strftime('%Y-%m-%d')
1697 with open(self.path, 'w', encoding='utf8') as f:
1698 for line in sorted(lst, key=natural_key):
1699 f.write(line + '\n')
1701 def recordapk(self, apkName, app, default_date=None):
1703 Record an apk (if it's new, otherwise does nothing)
1704 Returns the date it was added as a datetime instance
1706 if apkName not in self.apks:
1707 if default_date is None:
1708 default_date = datetime.utcnow()
1709 self.apks[apkName] = (app, default_date)
1711 _, added = self.apks[apkName]
1714 def getapp(self, apkname):
1715 """Look up information - given the 'apkname', returns (app id, date added/None).
1717 Or returns None for an unknown apk.
1719 if apkname in self.apks:
1720 return self.apks[apkname]
1723 def getlatest(self, num):
1724 """Get the most recent 'num' apps added to the repo, as a list of package ids with the most recent first"""
1726 for apk, app in self.apks.items():
1730 if apps[appid] > added:
1734 sortedapps = sorted(apps.items(), key=operator.itemgetter(1))[-num:]
1735 lst = [app for app, _ignored in sortedapps]
1740 def get_file_extension(filename):
1741 """get the normalized file extension, can be blank string but never None"""
1742 if isinstance(filename, bytes):
1743 filename = filename.decode('utf-8')
1744 return os.path.splitext(filename)[1].lower()[1:]
1747 def get_apk_debuggable_aapt(apkfile):
1748 p = SdkToolsPopen(['aapt', 'dump', 'xmltree', apkfile, 'AndroidManifest.xml'],
1750 if p.returncode != 0:
1751 raise FDroidException(_("Failed to get APK manifest information"))
1752 for line in p.output.splitlines():
1753 if 'android:debuggable' in line and not line.endswith('0x0'):
1758 def get_apk_debuggable_androguard(apkfile):
1760 from androguard.core.bytecodes.apk import APK
1762 raise FDroidException("androguard library is not installed and aapt not present")
1764 apkobject = APK(apkfile)
1765 if apkobject.is_valid_APK():
1766 debuggable = apkobject.get_element("application", "debuggable")
1767 if debuggable is not None:
1768 return bool(strtobool(debuggable))
1772 def isApkAndDebuggable(apkfile):
1773 """Returns True if the given file is an APK and is debuggable
1775 :param apkfile: full path to the apk to check"""
1777 if get_file_extension(apkfile) != 'apk':
1780 if SdkToolsPopen(['aapt', 'version'], output=False):
1781 return get_apk_debuggable_aapt(apkfile)
1783 return get_apk_debuggable_androguard(apkfile)
1786 def get_apk_id_aapt(apkfile):
1787 """Extrat identification information from APK using aapt.
1789 :param apkfile: path to an APK file.
1790 :returns: triplet (appid, version code, version name)
1792 r = re.compile("package: name='(?P<appid>.*)' versionCode='(?P<vercode>.*)' versionName='(?P<vername>.*)' platformBuildVersionName='.*'")
1793 p = SdkToolsPopen(['aapt', 'dump', 'badging', apkfile], output=False)
1794 for line in p.output.splitlines():
1797 return m.group('appid'), m.group('vercode'), m.group('vername')
1798 raise FDroidException(_("Reading packageName/versionCode/versionName failed, APK invalid: '{apkfilename}'")
1799 .format(apkfilename=apkfile))
1804 self.returncode = None
1808 def SdkToolsPopen(commands, cwd=None, output=True):
1810 if cmd not in config:
1811 config[cmd] = find_sdk_tools_cmd(commands[0])
1812 abscmd = config[cmd]
1814 raise FDroidException(_("Could not find '{command}' on your system").format(command=cmd))
1816 test_aapt_version(config['aapt'])
1817 return FDroidPopen([abscmd] + commands[1:],
1818 cwd=cwd, output=output)
1821 def FDroidPopenBytes(commands, cwd=None, envs=None, output=True, stderr_to_stdout=True):
1823 Run a command and capture the possibly huge output as bytes.
1825 :param commands: command and argument list like in subprocess.Popen
1826 :param cwd: optionally specifies a working directory
1827 :param envs: a optional dictionary of environment variables and their values
1828 :returns: A PopenResult.
1833 set_FDroidPopen_env()
1835 process_env = env.copy()
1836 if envs is not None and len(envs) > 0:
1837 process_env.update(envs)
1840 cwd = os.path.normpath(cwd)
1841 logging.debug("Directory: %s" % cwd)
1842 logging.debug("> %s" % ' '.join(commands))
1844 stderr_param = subprocess.STDOUT if stderr_to_stdout else subprocess.PIPE
1845 result = PopenResult()
1848 p = subprocess.Popen(commands, cwd=cwd, shell=False, env=process_env,
1849 stdout=subprocess.PIPE, stderr=stderr_param)
1850 except OSError as e:
1851 raise BuildException("OSError while trying to execute " +
1852 ' '.join(commands) + ': ' + str(e))
1854 if not stderr_to_stdout and options.verbose:
1855 stderr_queue = Queue()
1856 stderr_reader = AsynchronousFileReader(p.stderr, stderr_queue)
1858 while not stderr_reader.eof():
1859 while not stderr_queue.empty():
1860 line = stderr_queue.get()
1861 sys.stderr.buffer.write(line)
1866 stdout_queue = Queue()
1867 stdout_reader = AsynchronousFileReader(p.stdout, stdout_queue)
1870 # Check the queue for output (until there is no more to get)
1871 while not stdout_reader.eof():
1872 while not stdout_queue.empty():
1873 line = stdout_queue.get()
1874 if output and options.verbose:
1875 # Output directly to console
1876 sys.stderr.buffer.write(line)
1882 result.returncode = p.wait()
1883 result.output = buf.getvalue()
1885 # make sure all filestreams of the subprocess are closed
1886 for streamvar in ['stdin', 'stdout', 'stderr']:
1887 if hasattr(p, streamvar):
1888 stream = getattr(p, streamvar)
1894 def FDroidPopen(commands, cwd=None, envs=None, output=True, stderr_to_stdout=True):
1896 Run a command and capture the possibly huge output as a str.
1898 :param commands: command and argument list like in subprocess.Popen
1899 :param cwd: optionally specifies a working directory
1900 :param envs: a optional dictionary of environment variables and their values
1901 :returns: A PopenResult.
1903 result = FDroidPopenBytes(commands, cwd, envs, output, stderr_to_stdout)
1904 result.output = result.output.decode('utf-8', 'ignore')
1908 gradle_comment = re.compile(r'[ ]*//')
1909 gradle_signing_configs = re.compile(r'^[\t ]*signingConfigs[ \t]*{[ \t]*$')
1910 gradle_line_matches = [
1911 re.compile(r'^[\t ]*signingConfig [^ ]*$'),
1912 re.compile(r'.*android\.signingConfigs\.[^{]*$'),
1913 re.compile(r'.*\.readLine\(.*'),
1917 def remove_signing_keys(build_dir):
1918 for root, dirs, files in os.walk(build_dir):
1919 if 'build.gradle' in files:
1920 path = os.path.join(root, 'build.gradle')
1922 with open(path, "r", encoding='utf8') as o:
1923 lines = o.readlines()
1929 with open(path, "w", encoding='utf8') as o:
1930 while i < len(lines):
1933 while line.endswith('\\\n'):
1934 line = line.rstrip('\\\n') + lines[i]
1937 if gradle_comment.match(line):
1942 opened += line.count('{')
1943 opened -= line.count('}')
1946 if gradle_signing_configs.match(line):
1951 if any(s.match(line) for s in gradle_line_matches):
1959 logging.info("Cleaned build.gradle of keysigning configs at %s" % path)
1962 'project.properties',
1964 'default.properties',
1965 'ant.properties', ]:
1966 if propfile in files:
1967 path = os.path.join(root, propfile)
1969 with open(path, "r", encoding='iso-8859-1') as o:
1970 lines = o.readlines()
1974 with open(path, "w", encoding='iso-8859-1') as o:
1976 if any(line.startswith(s) for s in ('key.store', 'key.alias')):
1983 logging.info("Cleaned %s of keysigning configs at %s" % (propfile, path))
1986 def set_FDroidPopen_env(build=None):
1988 set up the environment variables for the build environment
1990 There is only a weak standard, the variables used by gradle, so also set
1991 up the most commonly used environment variables for SDK and NDK. Also, if
1992 there is no locale set, this will set the locale (e.g. LANG) to en_US.UTF-8.
1994 global env, orig_path
1998 orig_path = env['PATH']
1999 for n in ['ANDROID_HOME', 'ANDROID_SDK']:
2000 env[n] = config['sdk_path']
2001 for k, v in config['java_paths'].items():
2002 env['JAVA%s_HOME' % k] = v
2004 missinglocale = True
2005 for k, v in env.items():
2006 if k == 'LANG' and v != 'C':
2007 missinglocale = False
2009 missinglocale = False
2011 env['LANG'] = 'en_US.UTF-8'
2013 if build is not None:
2014 path = build.ndk_path()
2015 paths = orig_path.split(os.pathsep)
2016 if path not in paths:
2017 paths = [path] + paths
2018 env['PATH'] = os.pathsep.join(paths)
2019 for n in ['ANDROID_NDK', 'NDK', 'ANDROID_NDK_HOME']:
2020 env[n] = build.ndk_path()
2023 def replace_build_vars(cmd, build):
2024 cmd = cmd.replace('$$COMMIT$$', build.commit)
2025 cmd = cmd.replace('$$VERSION$$', build.versionName)
2026 cmd = cmd.replace('$$VERCODE$$', build.versionCode)
2030 def replace_config_vars(cmd, build):
2031 cmd = cmd.replace('$$SDK$$', config['sdk_path'])
2032 cmd = cmd.replace('$$NDK$$', build.ndk_path())
2033 cmd = cmd.replace('$$MVN3$$', config['mvn3'])
2034 cmd = cmd.replace('$$QT$$', config['qt_sdk_path'] or '')
2035 if build is not None:
2036 cmd = replace_build_vars(cmd, build)
2040 def place_srclib(root_dir, number, libpath):
2043 relpath = os.path.relpath(libpath, root_dir)
2044 proppath = os.path.join(root_dir, 'project.properties')
2047 if os.path.isfile(proppath):
2048 with open(proppath, "r", encoding='iso-8859-1') as o:
2049 lines = o.readlines()
2051 with open(proppath, "w", encoding='iso-8859-1') as o:
2054 if line.startswith('android.library.reference.%d=' % number):
2055 o.write('android.library.reference.%d=%s\n' % (number, relpath))
2060 o.write('android.library.reference.%d=%s\n' % (number, relpath))
2063 apk_sigfile = re.compile(r'META-INF/[0-9A-Za-z]+\.(SF|RSA|DSA|EC)')
2066 def signer_fingerprint_short(sig):
2067 """Obtain shortened sha256 signing-key fingerprint for pkcs7 signature.
2069 Extracts the first 7 hexadecimal digits of sha256 signing-key fingerprint
2070 for a given pkcs7 signature.
2072 :param sig: Contents of an APK signing certificate.
2073 :returns: shortened signing-key fingerprint.
2075 return signer_fingerprint(sig)[:7]
2078 def signer_fingerprint(sig):
2079 """Obtain sha256 signing-key fingerprint for pkcs7 signature.
2081 Extracts hexadecimal sha256 signing-key fingerprint string
2082 for a given pkcs7 signature.
2084 :param: Contents of an APK signature.
2085 :returns: shortened signature fingerprint.
2087 cert_encoded = get_certificate(sig)
2088 return hashlib.sha256(cert_encoded).hexdigest()
2091 def apk_signer_fingerprint(apk_path):
2092 """Obtain sha256 signing-key fingerprint for APK.
2094 Extracts hexadecimal sha256 signing-key fingerprint string
2097 :param apkpath: path to APK
2098 :returns: signature fingerprint
2101 with zipfile.ZipFile(apk_path, 'r') as apk:
2102 certs = [n for n in apk.namelist() if CERT_PATH_REGEX.match(n)]
2105 logging.error("Found no signing certificates on %s" % apk_path)
2108 logging.error("Found multiple signing certificates on %s" % apk_path)
2111 cert = apk.read(certs[0])
2112 return signer_fingerprint(cert)
2115 def apk_signer_fingerprint_short(apk_path):
2116 """Obtain shortened sha256 signing-key fingerprint for APK.
2118 Extracts the first 7 hexadecimal digits of sha256 signing-key fingerprint
2119 for a given pkcs7 APK.
2121 :param apk_path: path to APK
2122 :returns: shortened signing-key fingerprint
2124 return apk_signer_fingerprint(apk_path)[:7]
2127 def metadata_get_sigdir(appid, vercode=None):
2128 """Get signature directory for app"""
2130 return os.path.join('metadata', appid, 'signatures', vercode)
2132 return os.path.join('metadata', appid, 'signatures')
2135 def metadata_find_developer_signature(appid, vercode=None):
2136 """Tires to find the developer signature for given appid.
2138 This picks the first signature file found in metadata an returns its
2141 :returns: sha256 signing key fingerprint of the developer signing key.
2142 None in case no signature can not be found."""
2144 # fetch list of dirs for all versions of signatures
2147 appversigdirs.append(metadata_get_sigdir(appid, vercode))
2149 appsigdir = metadata_get_sigdir(appid)
2150 if os.path.isdir(appsigdir):
2151 numre = re.compile('[0-9]+')
2152 for ver in os.listdir(appsigdir):
2153 if numre.match(ver):
2154 appversigdir = os.path.join(appsigdir, ver)
2155 appversigdirs.append(appversigdir)
2157 for sigdir in appversigdirs:
2158 sigs = glob.glob(os.path.join(sigdir, '*.DSA')) + \
2159 glob.glob(os.path.join(sigdir, '*.EC')) + \
2160 glob.glob(os.path.join(sigdir, '*.RSA'))
2162 raise FDroidException('ambiguous signatures, please make sure there is only one signature in \'{}\'. (The signature has to be the App maintainers signature for version of the APK.)'.format(sigdir))
2164 with open(sig, 'rb') as f:
2165 return signer_fingerprint(f.read())
2169 def metadata_find_signing_files(appid, vercode):
2170 """Gets a list of singed manifests and signatures.
2172 :param appid: app id string
2173 :param vercode: app version code
2174 :returns: a list of triplets for each signing key with following paths:
2175 (signature_file, singed_file, manifest_file)
2178 sigdir = metadata_get_sigdir(appid, vercode)
2179 sigs = glob.glob(os.path.join(sigdir, '*.DSA')) + \
2180 glob.glob(os.path.join(sigdir, '*.EC')) + \
2181 glob.glob(os.path.join(sigdir, '*.RSA'))
2182 extre = re.compile('(\.DSA|\.EC|\.RSA)$')
2184 sf = extre.sub('.SF', sig)
2185 if os.path.isfile(sf):
2186 mf = os.path.join(sigdir, 'MANIFEST.MF')
2187 if os.path.isfile(mf):
2188 ret.append((sig, sf, mf))
2192 def metadata_find_developer_signing_files(appid, vercode):
2193 """Get developer signature files for specified app from metadata.
2195 :returns: A triplet of paths for signing files from metadata:
2196 (signature_file, singed_file, manifest_file)
2198 allsigningfiles = metadata_find_signing_files(appid, vercode)
2199 if allsigningfiles and len(allsigningfiles) == 1:
2200 return allsigningfiles[0]
2205 def apk_strip_signatures(signed_apk, strip_manifest=False):
2206 """Removes signatures from APK.
2208 :param signed_apk: path to apk file.
2209 :param strip_manifest: when set to True also the manifest file will
2210 be removed from the APK.
2212 with tempfile.TemporaryDirectory() as tmpdir:
2213 tmp_apk = os.path.join(tmpdir, 'tmp.apk')
2214 os.rename(signed_apk, tmp_apk)
2215 with ZipFile(tmp_apk, 'r') as in_apk:
2216 with ZipFile(signed_apk, 'w') as out_apk:
2217 for f in in_apk.infolist():
2218 if not apk_sigfile.match(f.filename):
2220 if f.filename != 'META-INF/MANIFEST.MF':
2221 buf = in_apk.read(f.filename)
2222 out_apk.writestr(f.filename, buf)
2224 buf = in_apk.read(f.filename)
2225 out_apk.writestr(f.filename, buf)
2228 def apk_implant_signatures(apkpath, signaturefile, signedfile, manifest):
2229 """Implats a signature from metadata into an APK.
2231 Note: this changes there supplied APK in place. So copy it if you
2232 need the original to be preserved.
2234 :param apkpath: location of the apk
2236 # get list of available signature files in metadata
2237 with tempfile.TemporaryDirectory() as tmpdir:
2238 # orig_apk = os.path.join(tmpdir, 'orig.apk')
2239 # os.rename(apkpath, orig_apk)
2240 apkwithnewsig = os.path.join(tmpdir, 'newsig.apk')
2241 with ZipFile(apkpath, 'r') as in_apk:
2242 with ZipFile(apkwithnewsig, 'w') as out_apk:
2243 for sig_file in [signaturefile, signedfile, manifest]:
2244 out_apk.write(sig_file, arcname='META-INF/' +
2245 os.path.basename(sig_file))
2246 for f in in_apk.infolist():
2247 if not apk_sigfile.match(f.filename):
2248 if f.filename != 'META-INF/MANIFEST.MF':
2249 buf = in_apk.read(f.filename)
2250 out_apk.writestr(f.filename, buf)
2252 p = SdkToolsPopen(['zipalign', '-v', '4', apkwithnewsig, apkpath])
2253 if p.returncode != 0:
2254 raise BuildException("Failed to align application")
2257 def apk_extract_signatures(apkpath, outdir, manifest=True):
2258 """Extracts a signature files from APK and puts them into target directory.
2260 :param apkpath: location of the apk
2261 :param outdir: folder where the extracted signature files will be stored
2262 :param manifest: (optionally) disable extracting manifest file
2264 with ZipFile(apkpath, 'r') as in_apk:
2265 for f in in_apk.infolist():
2266 if apk_sigfile.match(f.filename) or \
2267 (manifest and f.filename == 'META-INF/MANIFEST.MF'):
2268 newpath = os.path.join(outdir, os.path.basename(f.filename))
2269 with open(newpath, 'wb') as out_file:
2270 out_file.write(in_apk.read(f.filename))
2273 def verify_apks(signed_apk, unsigned_apk, tmp_dir):
2274 """Verify that two apks are the same
2276 One of the inputs is signed, the other is unsigned. The signature metadata
2277 is transferred from the signed to the unsigned apk, and then jarsigner is
2278 used to verify that the signature from the signed apk is also varlid for
2279 the unsigned one. If the APK given as unsigned actually does have a
2280 signature, it will be stripped out and ignored.
2282 There are two SHA1 git commit IDs that fdroidserver includes in the builds
2283 it makes: fdroidserverid and buildserverid. Originally, these were inserted
2284 into AndroidManifest.xml, but that makes the build not reproducible. So
2285 instead they are included as separate files in the APK's META-INF/ folder.
2286 If those files exist in the signed APK, they will be part of the signature
2287 and need to also be included in the unsigned APK for it to validate.
2289 :param signed_apk: Path to a signed apk file
2290 :param unsigned_apk: Path to an unsigned apk file expected to match it
2291 :param tmp_dir: Path to directory for temporary files
2292 :returns: None if the verification is successful, otherwise a string
2293 describing what went wrong.
2296 if not os.path.isfile(signed_apk):
2297 return 'can not verify: file does not exists: {}'.format(signed_apk)
2299 if not os.path.isfile(unsigned_apk):
2300 return 'can not verify: file does not exists: {}'.format(unsigned_apk)
2302 with ZipFile(signed_apk, 'r') as signed:
2303 meta_inf_files = ['META-INF/MANIFEST.MF']
2304 for f in signed.namelist():
2305 if apk_sigfile.match(f) \
2306 or f in ['META-INF/fdroidserverid', 'META-INF/buildserverid']:
2307 meta_inf_files.append(f)
2308 if len(meta_inf_files) < 3:
2309 return "Signature files missing from {0}".format(signed_apk)
2311 tmp_apk = os.path.join(tmp_dir, 'sigcp_' + os.path.basename(unsigned_apk))
2312 with ZipFile(unsigned_apk, 'r') as unsigned:
2313 # only read the signature from the signed APK, everything else from unsigned
2314 with ZipFile(tmp_apk, 'w') as tmp:
2315 for filename in meta_inf_files:
2316 tmp.writestr(signed.getinfo(filename), signed.read(filename))
2317 for info in unsigned.infolist():
2318 if info.filename in meta_inf_files:
2319 logging.warning('Ignoring %s from %s',
2320 info.filename, unsigned_apk)
2322 if info.filename in tmp.namelist():
2323 return "duplicate filename found: " + info.filename
2324 tmp.writestr(info, unsigned.read(info.filename))
2326 verified = verify_apk_signature(tmp_apk)
2329 logging.info("...NOT verified - {0}".format(tmp_apk))
2330 return compare_apks(signed_apk, tmp_apk, tmp_dir,
2331 os.path.dirname(unsigned_apk))
2333 logging.info("...successfully verified")
2337 def verify_jar_signature(jar):
2338 """Verifies the signature of a given JAR file.
2340 jarsigner is very shitty: unsigned JARs pass as "verified"! So
2341 this has to turn on -strict then check for result 4, since this
2342 does not expect the signature to be from a CA-signed certificate.
2344 :raises: VerificationException() if the JAR's signature could not be verified
2348 if subprocess.call([config['jarsigner'], '-strict', '-verify', jar]) != 4:
2349 raise VerificationException(_("The repository's index could not be verified."))
2352 def verify_apk_signature(apk, min_sdk_version=None):
2353 """verify the signature on an APK
2355 Try to use apksigner whenever possible since jarsigner is very
2356 shitty: unsigned APKs pass as "verified"! Warning, this does
2357 not work on JARs with apksigner >= 0.7 (build-tools 26.0.1)
2359 :returns: boolean whether the APK was verified
2361 if set_command_in_config('apksigner'):
2362 args = [config['apksigner'], 'verify']
2364 args += ['--min-sdk-version=' + min_sdk_version]
2365 return subprocess.call(args + [apk]) == 0
2367 logging.warning("Using Java's jarsigner, not recommended for verifying APKs! Use apksigner")
2369 verify_jar_signature(apk)
2376 def verify_old_apk_signature(apk):
2377 """verify the signature on an archived APK, supporting deprecated algorithms
2379 F-Droid aims to keep every single binary that it ever published. Therefore,
2380 it needs to be able to verify APK signatures that include deprecated/removed
2381 algorithms. For example, jarsigner treats an MD5 signature as unsigned.
2383 jarsigner passes unsigned APKs as "verified"! So this has to turn
2384 on -strict then check for result 4.
2386 :returns: boolean whether the APK was verified
2389 _java_security = os.path.join(os.getcwd(), '.java.security')
2390 with open(_java_security, 'w') as fp:
2391 fp.write('jdk.jar.disabledAlgorithms=MD2, RSA keySize < 1024')
2393 return subprocess.call([config['jarsigner'], '-J-Djava.security.properties=' + _java_security,
2394 '-strict', '-verify', apk]) == 4
2397 apk_badchars = re.compile('''[/ :;'"]''')
2400 def compare_apks(apk1, apk2, tmp_dir, log_dir=None):
2403 Returns None if the apk content is the same (apart from the signing key),
2404 otherwise a string describing what's different, or what went wrong when
2405 trying to do the comparison.
2411 absapk1 = os.path.abspath(apk1)
2412 absapk2 = os.path.abspath(apk2)
2414 if set_command_in_config('diffoscope'):
2415 logfilename = os.path.join(log_dir, os.path.basename(absapk1))
2416 htmlfile = logfilename + '.diffoscope.html'
2417 textfile = logfilename + '.diffoscope.txt'
2418 if subprocess.call([config['diffoscope'],
2419 '--max-report-size', '12345678', '--max-diff-block-lines', '100',
2420 '--html', htmlfile, '--text', textfile,
2421 absapk1, absapk2]) != 0:
2422 return("Failed to unpack " + apk1)
2424 apk1dir = os.path.join(tmp_dir, apk_badchars.sub('_', apk1[0:-4])) # trim .apk
2425 apk2dir = os.path.join(tmp_dir, apk_badchars.sub('_', apk2[0:-4])) # trim .apk
2426 for d in [apk1dir, apk2dir]:
2427 if os.path.exists(d):
2430 os.mkdir(os.path.join(d, 'jar-xf'))
2432 if subprocess.call(['jar', 'xf',
2433 os.path.abspath(apk1)],
2434 cwd=os.path.join(apk1dir, 'jar-xf')) != 0:
2435 return("Failed to unpack " + apk1)
2436 if subprocess.call(['jar', 'xf',
2437 os.path.abspath(apk2)],
2438 cwd=os.path.join(apk2dir, 'jar-xf')) != 0:
2439 return("Failed to unpack " + apk2)
2441 if set_command_in_config('apktool'):
2442 if subprocess.call([config['apktool'], 'd', os.path.abspath(apk1), '--output', 'apktool'],
2444 return("Failed to unpack " + apk1)
2445 if subprocess.call([config['apktool'], 'd', os.path.abspath(apk2), '--output', 'apktool'],
2447 return("Failed to unpack " + apk2)
2449 p = FDroidPopen(['diff', '-r', apk1dir, apk2dir], output=False)
2450 lines = p.output.splitlines()
2451 if len(lines) != 1 or 'META-INF' not in lines[0]:
2452 if set_command_in_config('meld'):
2453 p = FDroidPopen([config['meld'], apk1dir, apk2dir], output=False)
2454 return("Unexpected diff output - " + p.output)
2456 # since everything verifies, delete the comparison to keep cruft down
2457 shutil.rmtree(apk1dir)
2458 shutil.rmtree(apk2dir)
2460 # If we get here, it seems like they're the same!
2464 def set_command_in_config(command):
2465 '''Try to find specified command in the path, if it hasn't been
2466 manually set in config.py. If found, it is added to the config
2467 dict. The return value says whether the command is available.
2470 if command in config:
2473 tmp = find_command(command)
2475 config[command] = tmp
2480 def find_command(command):
2481 '''find the full path of a command, or None if it can't be found in the PATH'''
2484 return os.path.isfile(fpath) and os.access(fpath, os.X_OK)
2486 fpath, fname = os.path.split(command)
2491 for path in os.environ["PATH"].split(os.pathsep):
2492 path = path.strip('"')
2493 exe_file = os.path.join(path, command)
2494 if is_exe(exe_file):
2501 '''generate a random password for when generating keys'''
2502 h = hashlib.sha256()
2503 h.update(os.urandom(16)) # salt
2504 h.update(socket.getfqdn().encode('utf-8'))
2505 passwd = base64.b64encode(h.digest()).strip()
2506 return passwd.decode('utf-8')
2509 def genkeystore(localconfig):
2511 Generate a new key with password provided in :param localconfig and add it to new keystore
2512 :return: hexed public key, public key fingerprint
2514 logging.info('Generating a new key in "' + localconfig['keystore'] + '"...')
2515 keystoredir = os.path.dirname(localconfig['keystore'])
2516 if keystoredir is None or keystoredir == '':
2517 keystoredir = os.path.join(os.getcwd(), keystoredir)
2518 if not os.path.exists(keystoredir):
2519 os.makedirs(keystoredir, mode=0o700)
2522 'FDROID_KEY_STORE_PASS': localconfig['keystorepass'],
2523 'FDROID_KEY_PASS': localconfig['keypass'],
2525 p = FDroidPopen([config['keytool'], '-genkey',
2526 '-keystore', localconfig['keystore'],
2527 '-alias', localconfig['repo_keyalias'],
2528 '-keyalg', 'RSA', '-keysize', '4096',
2529 '-sigalg', 'SHA256withRSA',
2530 '-validity', '10000',
2531 '-storepass:env', 'FDROID_KEY_STORE_PASS',
2532 '-keypass:env', 'FDROID_KEY_PASS',
2533 '-dname', localconfig['keydname']], envs=env_vars)
2534 if p.returncode != 0:
2535 raise BuildException("Failed to generate key", p.output)
2536 os.chmod(localconfig['keystore'], 0o0600)
2537 if not options.quiet:
2538 # now show the lovely key that was just generated
2539 p = FDroidPopen([config['keytool'], '-list', '-v',
2540 '-keystore', localconfig['keystore'],
2541 '-alias', localconfig['repo_keyalias'],
2542 '-storepass:env', 'FDROID_KEY_STORE_PASS'], envs=env_vars)
2543 logging.info(p.output.strip() + '\n\n')
2544 # get the public key
2545 p = FDroidPopenBytes([config['keytool'], '-exportcert',
2546 '-keystore', localconfig['keystore'],
2547 '-alias', localconfig['repo_keyalias'],
2548 '-storepass:env', 'FDROID_KEY_STORE_PASS']
2549 + config['smartcardoptions'],
2550 envs=env_vars, output=False, stderr_to_stdout=False)
2551 if p.returncode != 0 or len(p.output) < 20:
2552 raise BuildException("Failed to get public key", p.output)
2554 fingerprint = get_cert_fingerprint(pubkey)
2555 return hexlify(pubkey), fingerprint
2558 def get_cert_fingerprint(pubkey):
2560 Generate a certificate fingerprint the same way keytool does it
2561 (but with slightly different formatting)
2563 digest = hashlib.sha256(pubkey).digest()
2564 ret = [' '.join("%02X" % b for b in bytearray(digest))]
2565 return " ".join(ret)
2568 def get_certificate(certificate_file):
2570 Extracts a certificate from the given file.
2571 :param certificate_file: file bytes (as string) representing the certificate
2572 :return: A binary representation of the certificate's public key, or None in case of error
2574 content = decoder.decode(certificate_file, asn1Spec=rfc2315.ContentInfo())[0]
2575 if content.getComponentByName('contentType') != rfc2315.signedData:
2577 content = decoder.decode(content.getComponentByName('content'),
2578 asn1Spec=rfc2315.SignedData())[0]
2580 certificates = content.getComponentByName('certificates')
2581 cert = certificates[0].getComponentByName('certificate')
2583 logging.error("Certificates not found.")
2585 return encoder.encode(cert)
2588 def load_stats_fdroid_signing_key_fingerprints():
2589 """Load list of signing-key fingerprints stored by fdroid publish from file.
2591 :returns: list of dictionanryies containing the singing-key fingerprints.
2593 jar_file = os.path.join('stats', 'publishsigkeys.jar')
2594 if not os.path.isfile(jar_file):
2596 cmd = [config['jarsigner'], '-strict', '-verify', jar_file]
2597 p = FDroidPopen(cmd, output=False)
2598 if p.returncode != 4:
2599 raise FDroidException("Signature validation of '{}' failed! "
2600 "Please run publish again to rebuild this file.".format(jar_file))
2602 jar_sigkey = apk_signer_fingerprint(jar_file)
2603 repo_key_sig = config.get('repo_key_sha256')
2605 if jar_sigkey != repo_key_sig:
2606 raise FDroidException("Signature key fingerprint of file '{}' does not match repo_key_sha256 in config.py (found fingerprint: '{}')".format(jar_file, jar_sigkey))
2608 logging.warning("repo_key_sha256 not in config.py, setting it to the signature key fingerprint of '{}'".format(jar_file))
2609 config['repo_key_sha256'] = jar_sigkey
2610 write_to_config(config, 'repo_key_sha256')
2612 with zipfile.ZipFile(jar_file, 'r') as f:
2613 return json.loads(str(f.read('publishsigkeys.json'), 'utf-8'))
2616 def write_to_config(thisconfig, key, value=None, config_file=None):
2617 '''write a key/value to the local config.py
2619 NOTE: only supports writing string variables.
2621 :param thisconfig: config dictionary
2622 :param key: variable name in config.py to be overwritten/added
2623 :param value: optional value to be written, instead of fetched
2624 from 'thisconfig' dictionary.
2627 origkey = key + '_orig'
2628 value = thisconfig[origkey] if origkey in thisconfig else thisconfig[key]
2629 cfg = config_file if config_file else 'config.py'
2631 # load config file, create one if it doesn't exist
2632 if not os.path.exists(cfg):
2633 open(cfg, 'a').close()
2634 logging.info("Creating empty " + cfg)
2635 with open(cfg, 'r', encoding="utf-8") as f:
2636 lines = f.readlines()
2638 # make sure the file ends with a carraige return
2640 if not lines[-1].endswith('\n'):
2643 # regex for finding and replacing python string variable
2644 # definitions/initializations
2645 pattern = re.compile('^[\s#]*' + key + '\s*=\s*"[^"]*"')
2646 repl = key + ' = "' + value + '"'
2647 pattern2 = re.compile('^[\s#]*' + key + "\s*=\s*'[^']*'")
2648 repl2 = key + " = '" + value + "'"
2650 # If we replaced this line once, we make sure won't be a
2651 # second instance of this line for this key in the document.
2654 with open(cfg, 'w', encoding="utf-8") as f:
2656 if pattern.match(line) or pattern2.match(line):
2658 line = pattern.sub(repl, line)
2659 line = pattern2.sub(repl2, line)
2670 def parse_xml(path):
2671 return XMLElementTree.parse(path).getroot()
2674 def string_is_integer(string):
2682 def get_per_app_repos():
2683 '''per-app repos are dirs named with the packageName of a single app'''
2685 # Android packageNames are Java packages, they may contain uppercase or
2686 # lowercase letters ('A' through 'Z'), numbers, and underscores
2687 # ('_'). However, individual package name parts may only start with
2688 # letters. https://developer.android.com/guide/topics/manifest/manifest-element.html#package
2689 p = re.compile('^([a-zA-Z][a-zA-Z0-9_]*(\\.[a-zA-Z][a-zA-Z0-9_]*)*)?$')
2692 for root, dirs, files in os.walk(os.getcwd()):
2694 print('checking', root, 'for', d)
2695 if d in ('archive', 'metadata', 'repo', 'srclibs', 'tmp'):
2696 # standard parts of an fdroid repo, so never packageNames
2699 and os.path.exists(os.path.join(d, 'fdroid', 'repo', 'index.jar')):
2705 def is_repo_file(filename):
2706 '''Whether the file in a repo is a build product to be delivered to users'''
2707 if isinstance(filename, str):
2708 filename = filename.encode('utf-8', errors="surrogateescape")
2709 return os.path.isfile(filename) \
2710 and not filename.endswith(b'.asc') \
2711 and not filename.endswith(b'.sig') \
2712 and os.path.basename(filename) not in [
2714 b'index_unsigned.jar',