From f217aeada7db1c360b983853ce81f8041749506f Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Wed, 29 Dec 2021 12:29:56 +0000 Subject: [PATCH] Suppress some warnings about ignoring stderr write errors MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Eg, servexec.c:239:5: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] These are calls made while we are bombing out anyway. Signed-off-by: Ian Jackson --- client.c | 8 +++++--- servexec.c | 4 +++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/client.c b/client.c index 788b507..3e43cf2 100644 --- a/client.c +++ b/client.c @@ -140,15 +140,17 @@ static void blocksignals(int how) { sigset_t set; static const char blockerrmsg[]= "userv: failed to [un]block signals: "; const char *str; + int unused; sigemptyset(&set); sigaddset(&set,SIGCHLD); sigaddset(&set,SIGALRM); if (sigprocmask(how,&set,0)) { str= strerror(errno); - write(2,blockerrmsg,sizeof(blockerrmsg)-1); - write(2,str,strlen(str)); - write(2,"\n",1); + unused= write(2,blockerrmsg,sizeof(blockerrmsg)-1); + unused= write(2,str,strlen(str)); + unused= write(2,"\n",1); + (void)unused; exit(-1); } } diff --git a/servexec.c b/servexec.c index 6b55ea7..71c63cf 100644 --- a/servexec.c +++ b/servexec.c @@ -228,6 +228,7 @@ void execservice(const int synchsocket[], int clientfd) { 0 }; int fd, realfd, holdfd, newfd, r, envvarbufsize=0, targ, nargs, i, l, fdflags; + int unused; char *envvarbuf=0; const char **args, *const *cpp; char *const *pp; @@ -236,7 +237,8 @@ void execservice(const int synchsocket[], int clientfd) { if (dup2(fdarray[2].realfd,2)<0) { static const char duperrmsg[]= "uservd(service): cannot dup2 for stderr\n"; - write(fdarray[2].realfd,duperrmsg,sizeof(duperrmsg)-1); + unused= write(fdarray[2].realfd,duperrmsg,sizeof(duperrmsg)-1); + (void)unused; _exit(-1); } serv_resetsignal(SIGPIPE); -- 2.30.2