X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?p=userv-utils.git;a=blobdiff_plain;f=www-cgi%2Fucgi.c;h=845eb444b891b9ff3e8ade47350d8161704b57f4;hp=980bec5ca518e09183d9d2a59ac7dc24d3bf535f;hb=0cd9d59dfadf1a9abbef4428ff4f90bf32c01bd4;hpb=aa0bce91c04ffd1923a623819e5bbe1ccf609a81 diff --git a/www-cgi/ucgi.c b/www-cgi/ucgi.c index 980bec5..845eb44 100644 --- a/www-cgi/ucgi.c +++ b/www-cgi/ucgi.c @@ -57,7 +57,7 @@ struct buildargs { }; static void addarg(struct buildargs *args, const char *a) { - if (args->n > args->max) error("too many arguments"); + if (args->n > args->max) error("too many arguments", 500); args->v[args->n++]= a; } @@ -67,7 +67,8 @@ static void add_userv_var(const char *fulln, size_t l; char *a; - l= strlen(ev); if (l > MAX_ENVVAR_VALUE) error("environment variable too long"); + l= strlen(ev); + if (l > MAX_ENVVAR_VALUE) error("environment variable too long", 500); a= xmalloc(strlen(en)+l+6); sprintf(a,"-DE_%s=%s",en,ev); addarg(args, a); @@ -92,7 +93,7 @@ int main(int argc, const char **argv) { D( printf(";;; UCGI\n"); ) } - if (argc > MAX_ARGS) error("too many arguments"); + if (argc > MAX_ARGS) error("too many arguments", 500); ev= getenv("UCGI_ENV_FILTER"); if (ev) @@ -101,21 +102,24 @@ int main(int argc, const char **argv) { envok= load_filters(0, "/etc/userv/ucgi.env-filter", LF_END); pathi= getenv("PATH_INFO"); - if (!pathi) error("PATH_INFO not found"); + if (!pathi) error("PATH_INFO not found", 500); D( if (debugmode) { printf(";; find user name...\n" ";; initial PATH_INFO = `%s'\n", pathi); } ) - if (pathi[0] != '/' || pathi[1] != '~') error("PATH_INFO must start with /~"); - slash2= strchr(pathi+2,'/'); if (!slash2) error("PATH_INFO must have more than one /"); + if (pathi[0] != '/' || pathi[1] != '~') + error("PATH_INFO must start with /~", 400); + slash2= strchr(pathi+2,'/'); + if (!slash2) error("PATH_INFO must have more than one /", 400); usernamelen= slash2-(pathi+2); - if (usernamelen > MAX_USERNAME_LEN) error("PATH_INFO username too long"); + if (usernamelen > MAX_USERNAME_LEN) error("PATH_INFO username too long", 400); username= xmalloc(usernamelen+1); memcpy(username,pathi+2,usernamelen); username[usernamelen]= 0; D( if (debugmode) printf(";; user = `%s'; tail = `%s'\n", username, slash2); ) - if (!isalpha(username[0])) error("username 1st character is not alphabetic"); + if (!isalpha(username[0])) + error("username 1st character is not alphabetic", 400); xsetenv("PATH_INFO",slash2,1); args.n= 0; args.max= argc + MAX_ENVVARS + 10;