git-daemon: no need for a special configuration variable namespace

[userv-utils.git] / git-daemon / git-daemon.pl

diff --git a/git-daemon/git-daemon.pl b/git-daemon/git-daemon.pl
index 5458c08fcd2c77036fcf34261d900640fbbb010e..68d816270700991087a1f1495ece023e96852069 100755 (executable)
--- a/git-daemon/git-daemon.pl
+++ b/git-daemon/git-daemon.pl
@@ -2,10 +2,6 @@
 #
 # A git daemon with an added userv security boundary.
 #
-# This reads the first packet-line of the protocol, checks the syntax
-# of the pathname and hostname, then uses userv to invoke the
-# git-upload-pack as the target user with safe arguments.
-#
 # This was written by Tony Finch <dot@dotat.at>
 # You may do anything with it, at your own risk.
 # http://creativecommons.org/publicdomain/zero/1.0/
@@ -17,29 +13,19 @@ use POSIX;
 use Socket;
 use Sys::Syslog;
 
-use vars qw{ %vhost_default_user %vhost_user_from_tilde
-             $TILDE $REPO $HOSTNAME };
-
-use lib '/etc/userv';
-require 'git-daemon-vhosts.pl';
-
-my $peer = getpeername STDIN;
-my ($port,$addr);
-if (defined $peer) {
-    ($port,$addr) = sockaddr_in $peer;
+sub ntoa {
+    my $sockaddr = shift;
+    return ('[?.?.?.?]:?') unless defined $sockaddr;
+    my ($port,$addr) = sockaddr_in $sockaddr;
     $addr = inet_ntoa $addr;
-    $peer = "[$addr]:$port";
-} else {
-    $peer = "[?.?.?.?]:?";
-    undef $!;
+    return ("[$addr]:$port",$addr,$port);
 }
+our ($client,$client_addr,$client_port) = ::ntoa(getpeername(STDIN));
+our ($server,$server_addr,$server_port) = ::ntoa(getsockname(STDIN));
+our ($service,$path,$host,$uri,$user);
 
 openlog 'userv-git-daemon', 'pid', 'daemon';
-
-sub fail {
-    syslog 'err', "$peer @_";
-    exit;
-}
+sub fail { syslog 'err', "$client @_"; exit }
 
 sub xread {
     my $length = shift;
@@ -51,31 +37,31 @@ sub xread {
         fail "short read: expected $length bytes, got " . length $buffer
                             if defined $ret and $ret == 0;
         fail "read: $!" if not defined $ret and $! != EINTR and $! != EAGAIN;
-        $ret = 0        if not defined $ret;
     }
     alarm 0;
     return $buffer;
 }
 
 my $len_hex = xread 4;
-fail "non-hexadecimal packet length" unless $len_hex =~ m{^[0-9a-zA-Z]{4}$};
+fail "non-hex packet length" unless $len_hex =~ m{^[0-9a-fA-F]{4}$};
 my $line = xread hex $len_hex;
-unless ($line =~ m{^git-upload-pack (?:~($TILDE)/)?($REPO[.]git)\0host=($HOSTNAME)\0$}) {
-    $line =~ s/[^ -~]+/ /g;
+if ($line !~ m{^(git-[a-z-]+) /*([!-~]+)\0host=([!-~]+)\0$}) {
+    $line =~ s|[^ -~]+| |g;
     fail "could not parse \"$line\""
 }
-my ($tilde,$repo,$host) = ($1,$2,$3);
-my $url = $tilde ? "git://$host/~$tilde/$repo" : "git://$host/$repo";
+($service,$path,$host) = ($1,$2,$3);
+$_ = $uri = "git://$host/$path";
+for my $cf (@ARGV) { do $cf }
+
+fail "no user configured for $uri" unless defined $user;
+syslog 'info', "$client $service $uri";
 
-my $user = $vhost_user_from_tilde{$host} ? $tilde : $vhost_default_user{$host};
-fail "no user configuration for $url" unless defined $user;
-syslog 'info', "$peer $user $url";
+my @opts = map "-D$_=${$main::{$_}}",
+        grep defined ${$main::{$_}} && /^[a-z]+$/,
+             sort keys %main::;
 
-my @opts = ("-DHOST=$host", "-DREPO=$repo");
-push @opts, "-DTILDE=$tilde" if defined $tilde;
-push @opts, "-DCLIENT=$addr" if defined $addr;
+my @cmd = ('userv', @opts, $user, $service);
 no warnings; # suppress errors to stderr
-exec 'userv', @opts, $user, 'git-upload-pack'
-    or fail "exec userv: $!";
+exec @cmd or fail "exec @cmd: $!";
 
 # end