From ff91d2d78d96441893acd1b1099726346e7f84cf Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Wed, 30 Dec 2015 23:53:36 +0000 Subject: [PATCH] rect: Fix compiler errors about uninitialized use of variables error: 'r2.x' may be used uninitialized in this function Its happening when using gcc 5.3 with musl C library. its considering the case when case falls into default and immediately after exiting this there is a check if (r1.h > 0 && r1.w > 0) where r1 element is used but not assigned anything. GCC is not noticing the control flow where the initilization will always work due to assertion call can be a function call from libc Signed-off-by: Khem Raj --- rect.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rect.c b/rect.c index 55667c0..fa3a786 100644 --- a/rect.c +++ b/rect.c @@ -1317,7 +1317,8 @@ static char *new_game_desc(const game_params *params_in, random_state *rs, if (ndirs > 0) { int which, dir; struct rect r1, r2; - + memset(&r1, 0, sizeof(struct rect)); + memset(&r2, 0, sizeof(struct rect)); which = random_upto(rs, ndirs); dir = dirs[which]; -- 2.30.2