From 3e55608636ee89cfa6894539f179d33a46174fab Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Sat, 27 Sep 2014 15:01:05 +0100 Subject: [PATCH] udp: Introduce some `us' convenience variables, etc. * Introduce appropriate `struct udpsock *us' in a few places, and use them as appropriate. We are going to make a few more places where these are used and this avoids some repetition. * Introduce an `af' variable for the intended destination address family at one point. We are going to want to reuse this. * Add a comment on a line `} else {' distant from its `if (..) {'. No functional change. Signed-off-by: Ian Jackson --- udp.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/udp.c b/udp.c index 4cf1958..3979183 100644 --- a/udp.c +++ b/udp.c @@ -73,10 +73,11 @@ static void udp_socks_afterpoll(void *state, struct pollfd *fds, int nfds) struct commcommon *cc=&uc->cc; for (i=0; in_socks; i++) { + struct udpsock *us=&socks->socks[i]; if (i>=nfds) continue; if (!(fds[i].revents & POLLIN)) continue; - assert(fds[i].fd == socks->socks[i].fd); - int fd=socks->socks[i].fd; + assert(fds[i].fd == us->fd); + int fd=us->fd; do { FILLZERO(from); fromlen=sizeof(from); @@ -125,7 +126,7 @@ static void udp_socks_afterpoll(void *state, struct pollfd *fds, int nfds) BUF_FREE(cc->rbuf); } BUF_ASSERT_FREE(cc->rbuf); - } else { + } else { /* rv<=0 */ BUF_FREE(cc->rbuf); } } while (rv>=0); @@ -141,6 +142,7 @@ static bool_t udp_sendmsg(void *commst, struct buffer_if *buf, uint8_t *sa; if (uc->use_proxy) { + struct udpsock *us=&socks->socks[0]; sa=buf_prepend(buf,8); if (dest->ia.sa.sa_family != AF_INET) { Message(M_INFO, @@ -151,17 +153,19 @@ static bool_t udp_sendmsg(void *commst, struct buffer_if *buf, memcpy(sa,&dest->ia.sin.sin_addr,4); memset(sa+4,0,4); memcpy(sa+6,&dest->ia.sin.sin_port,2); - sendto(socks->socks[0].fd,sa,buf->size+8,0,(struct sockaddr *)&uc->proxy, + sendto(us->fd,sa,buf->size+8,0,(struct sockaddr *)&uc->proxy, sizeof(uc->proxy)); buf_unprepend(buf,8); } else { int i,r; bool_t allunsupported=True; + int af=dest->ia.sa.sa_family; for (i=0; in_socks; i++) { - if (dest->ia.sa.sa_family != socks->socks[i].addr.sa.sa_family) + struct udpsock *us=&socks->socks[i]; + if (us->addr.sa.sa_family != af) /* no point even trying */ continue; - r=sendto(socks->socks[i].fd, buf->start, buf->size, 0, + r=sendto(us->fd, buf->start, buf->size, 0, &dest->ia.sa, iaddr_socklen(&dest->ia)); if (!r) return True; if (!(errno==EAFNOSUPPORT || errno==ENETUNREACH)) -- 2.30.2