From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Fri, 19 Sep 2014 22:35:06 +0000 (+0100)
Subject: ipaddr_to_string: SECURITY: Do not allocate
X-Git-Tag: v0.3.3~3
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?p=secnet.git;a=commitdiff_plain;h=5540bab74ca1a39639a098d15e87daf45d83b7ec;hp=5540bab74ca1a39639a098d15e87daf45d83b7ec

ipaddr_to_string: SECURITY: Do not allocate

ipaddr_to_string is used in many places including runtime logging.
Handling its memory allocation is annoyingly fiddly.  Indeed there is
at least one possible memory leak, which represents a potential denial
of service bug.

None of the callers keep the answers for any length of time.

So make it return the next one of a series of round-robin buffers,
instead, and remove all the freeing at all the call sites.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---