chiark / gitweb /
slip: Remove an incorrect XXX comment
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Sat, 27 Sep 2014 13:28:20 +0000 (14:28 +0100)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Tue, 21 Oct 2014 00:07:09 +0000 (01:07 +0100)
There is no need to strdup anything before calling exec (or exit, of
course).

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
slip.c

diff --git a/slip.c b/slip.c
index 4c0cac1..e555f47 100644 (file)
--- a/slip.c
+++ b/slip.c
@@ -273,8 +273,6 @@ static void userv_entry(void *sst)
     dup2(st->out,1);
 
     setsid();
-    /* XXX We really should strdup() all of argv[] but because we'll just
-       exit anyway if execvp() fails it doesn't seem worth bothering. */
     execvp(st->path,(char *const*)st->argv);
     perror("userv-entry: execvp()");
     exit(1);