chiark / gitweb /
Fix bizarre `if (!consttime_memeq(X, Y, N)!=0)' idioms.
authorMark Wooding <mdw@distorted.org.uk>
Thu, 19 Sep 2019 20:01:22 +0000 (20:01 +0000)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Sat, 21 Sep 2019 09:57:12 +0000 (10:57 +0100)
commit30ba82a584441fc730ad733081805d15fd07bd09
tree2e318625380adfae40fa0dcbf4a708f68f249a51
parentbdc4c1f98661ec308337b90b8e3134c5c5947904
Fix bizarre `if (!consttime_memeq(X, Y, N)!=0)' idioms.

Clang thinks the `!' is in the wrong place.  I think the `!=0' isn't
doing any work, so I've deleted it.

This stems from 5ad34db2ccbb "memcmp: Introduce and use
consttime_memeq",

  -    if (memcmp(m->nR,st->remoteN,NONCELEN)!=0) {
  +    if (!consttime_memeq(m->nR,st->remoteN,NONCELEN)!=0) {

at which time the !=0 was already redundant and became more confusing.

Signed-off-by: Mark Wooding <mdw@distorted.org.uk>
Acked-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
site.c
transform-cbcmac.c