X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?p=secnet.git;a=blobdiff_plain;f=rsa.c;h=81fb1b5cd7ea5587502043fd938409e652d8d2c3;hp=d1107a952ef1a0e0ce9198a66ee17e0a6e61c31e;hb=3454dce4c6909648b711a59b57c5a527036b2a8e;hpb=2fe58dfd10216a37f1ece081f926971882de112e

diff --git a/rsa.c b/rsa.c
index d1107a9..81fb1b5 100644
--- a/rsa.c
+++ b/rsa.c
@@ -62,6 +62,10 @@ static string_t rsa_sign(void *sst, uint8_t *data, uint32_t datalen)
 
     msize=mpz_sizeinbase(&st->n, 16);
 
+    if (datalen*2+4>=msize) {
+	fatal("rsa_sign: message too big\n");
+    }
+
     strcpy(buff,"0001");
 
     for (i=0; i<datalen; i++) {
@@ -69,7 +73,7 @@ static string_t rsa_sign(void *sst, uint8_t *data, uint32_t datalen)
 	buff[5+i*2]=hexchars[data[i]&0xf];
     }
     buff[4+datalen*2]=0;
-
+    
     for (i=datalen*2+4; i<msize; i++)
 	buff[i]='f';
 
@@ -228,8 +232,15 @@ static list_t *rsapriv_apply(closure_t *self, struct cloc loc, dict_t *context,
 
     f=fopen(filename,"rb");
     if (!f) {
-	fatal_perror("rsa-private (%s:%d): cannot open file \"%s\"",
-		     loc.file,loc.line,filename);
+	if (just_check_config) {
+	    Message(M_WARNING,"rsa-private (%s:%d): cannot open keyfile "
+		    "\"%s\"; assuming it's valid while we check the "
+		    "rest of the configuration\n",loc.file,loc.line,filename);
+	    goto assume_valid;
+	} else {
+	    fatal_perror("rsa-private (%s:%d): cannot open file \"%s\"",
+			 loc.file,loc.line,filename);
+	}
     }
 
     /* Check that the ID string is correct */
@@ -310,23 +321,30 @@ static list_t *rsapriv_apply(closure_t *self, struct cloc loc, dict_t *context,
 
     /* Now do trial signature/check to make sure it's a real keypair:
        sign the comment string! */
-    mpz_init(&sig);
-    mpz_init(&plain);
-    mpz_init(&check);
-    read_mpbin(&plain,c,strlen(c));
-    mpz_powm(&sig, &plain, &st->d, &st->n);
-    mpz_powm(&check, &sig, &e, &st->n);
-    if (mpz_cmp(&plain,&check)!=0) {
-	cfgfatal(loc,"rsa-private","file \"%s\" does not contain a "
-		 "valid RSA key!\n",filename);
+    i=list_elem(args,1);
+    if (i && i->type==t_bool && i->data.bool==False) {
+	Message(M_INFO,"rsa-private (%s:%d): skipping RSA key validity "
+		"check\n",loc.file,loc.line);
+    } else {
+	mpz_init(&sig);
+	mpz_init(&plain);
+	mpz_init(&check);
+	read_mpbin(&plain,c,strlen(c));
+	mpz_powm(&sig, &plain, &st->d, &st->n);
+	mpz_powm(&check, &sig, &e, &st->n);
+	if (mpz_cmp(&plain,&check)!=0) {
+	    cfgfatal(loc,"rsa-private","file \"%s\" does not contain a "
+		     "valid RSA key!\n",filename);
+	}
+	mpz_clear(&sig);
+	mpz_clear(&plain);
+	mpz_clear(&check);
     }
-    mpz_clear(&sig);
-    mpz_clear(&plain);
-    mpz_clear(&check);
 
     free(c);
     mpz_clear(&e);
 
+assume_valid:
     return new_closure(&st->cl);
 }