DIMBITS compromise

[moebius2.git] / energy.c

diff --git a/energy.c b/energy.c
index f28135a3bf4d2bc02ce9f700c89d0d6c77dfba20..d673c14ea2820fd7e8e59b45678f486a842572a0 100644 (file)
--- a/energy.c
+++ b/energy.c
@@ -17,11 +17,9 @@ static double noncircular_rim_cost(const Vertices vertices);
 
 static void compute_vertex_areas(const Vertices vertices, double areas[N]);
 static double best_energy= DBL_MAX;
-static void flushoutput(void);
-static void diee(const char *what) { perror(what); exit(16); }
 
-static void cost(double *energy, double tweight, double tcost);
-#define COST(weight, compute) cost(&energy, (weight), (compute))
+static void addcost(double *energy, double tweight, double tcost);
+#define COST(weight, compute) addcost(&energy, (weight), (compute))
 
 /*---------- main energy computation and subroutines ----------*/
 
@@ -32,9 +30,9 @@ static double compute_energy(const Vertices vertices) {
   energy= 0;
   printf("cost > energy |");
 
-  COST(1000.0, edgewise_vertex_displacement_cost(vertices));
-  COST(1.0,    graph_layout_cost(vertices,vertex_areas));
-  COST(1e3,    noncircular_rim_cost(vertices));
+  COST(1e4, edgewise_vertex_displacement_cost(vertices));
+  COST(1e2, graph_layout_cost(vertices,vertex_areas));
+  COST(1e4, noncircular_rim_cost(vertices));
   
   printf("| total %# e |", energy);
   if (energy < best_energy) {
@@ -44,9 +42,11 @@ static double compute_energy(const Vertices vertices) {
     printf(" BEST");
     
     best_f= fopen(BEST_F ".new","wb");  if (!best_f) diee("fopen new best");
-    r= fwrite(vertices,sizeof(vertices),1,best_f); if (r!=1) diee("fwrite");
+    r= fwrite(vertices,sizeof(Vertices),1,best_f); if (r!=1) diee("fwrite");
     if (fclose(best_f)) diee("fclose new best");
     if (rename(BEST_F ".new", BEST_F)) diee("rename install new best");
+
+    best_energy= energy;
   }
   putchar('\n');
   flushoutput();
@@ -54,16 +54,12 @@ static double compute_energy(const Vertices vertices) {
   return energy;
 }    
 
-static void cost(double *energy, double tweight, double tcost) {
+static void addcost(double *energy, double tweight, double tcost) {
   double tenergy= tweight * tcost;
   printf(" %# e > %# e |", tcost, tenergy);
   *energy += tenergy;
 }
 
-static void flushoutput(void) {
-  if (fflush(stdout) || ferror(stdout)) diee("stdout");
-}
-
 static void compute_vertex_areas(const Vertices vertices, double areas[N]) {
   int v0,v1,v2, e1,e2, k;
   
@@ -115,17 +111,10 @@ static void compute_vertex_areas(const Vertices vertices, double areas[N]) {
    * coordinates.  Hopefully this won't be too slow ...
    */
 
-static void gsldie(const char *what, int status) {
-  fprintf(stderr,"gsl function failed: %s: %s\n", what, gsl_strerror(status));
-  exit(-1);
-}
-
 static gsl_multimin_fminimizer *minimiser;
 
 static const double stop_epsilon= 1e-4;
 
-#define DIM (N*D3)
-
 static double minfunc_f(const gsl_vector *x, void *params) {
   assert(x->size == DIM);
   assert(x->stride == 1);
@@ -138,7 +127,7 @@ int main(int argc, const char *const *argv) {
   Vertices initial, step_size;
   FILE *initial_f;
   gsl_vector initial_gsl, step_size_gsl;
-  int r, v, vx,vy, k;
+  int r, v, k;
   
   if (argc>1) { fputs("takes no arguments\n",stderr); exit(8); }
 
@@ -161,26 +150,25 @@ int main(int argc, const char *const *argv) {
   initial_gsl.owner= 0;
   step_size_gsl= initial_gsl;
 
-  initial_gsl.data= (double*)initial;
-  step_size_gsl.data= (double*)step_size;
+  initial_gsl.data= &initial[0][0];
+  step_size_gsl.data= &step_size[0][0];
 
   FOR_VERTEX(v)
-    K step_size[v][k]= 1e-3;
-  FOR_RIM_VERTEX(vx,vy,v)
-    step_size[v][3] *= 0.1;
+    K step_size[v][k]= 0.01;
+//int vx,vy;
+//  FOR_RIM_VERTEX(vx,vy,v)
+//    step_size[v][3] *= 0.1;
 
-  r= gsl_multimin_fminimizer_set(minimiser, &multimin_function,
-                                &initial_gsl, &step_size_gsl);
-  if (r) { gsldie("fminimizer_set",r); }
+  GA( gsl_multimin_fminimizer_set(minimiser, &multimin_function,
+                                 &initial_gsl, &step_size_gsl) );
   
   for (;;) {
-    r= gsl_multimin_fminimizer_iterate(minimiser);
-    if (r) { gsldie("fminimizer_iterate",r); }
+    GA( gsl_multimin_fminimizer_iterate(minimiser) );
 
     size= gsl_multimin_fminimizer_size(minimiser);
     r= gsl_multimin_test_size(size, stop_epsilon);
 
-    printf("size %# e, r=%d\n", size, r);
+    printf("%*s size %# e, r=%d\n", 135,"", size, r);
     flushoutput();
 
     if (r==GSL_SUCCESS) break;
@@ -257,13 +245,11 @@ static double edgewise_vertex_displacement_cost(const Vertices vertices) {
   static const double l3_epsilon= 1e-6;
 
   int pi,e,qi,ri,si, k;
-  double m[D3], mprime[D3], b, d2, l, sigma_bd2_l3;
+  double m[D3], mprime[D3], b, d2, l, sigma_bd2_l3=0;
 
   FOR_EDGE(pi,e,qi) {
     ri= EDGE_END2(pi,(e+1)%V6); if (ri<0) continue;
     si= EDGE_END2(pi,(e+5)%V6); if (si<0) continue;
-    assert(ri == EDGE_END2(qi,(e+2)%V6));
-    assert(si == EDGE_END2(qi,(e+4)%V6));
     
     K m[k]= (vertices[pi][k] + vertices[qi][k]) * 0.5;
     K mprime[k]= (vertices[ri][k] + vertices[si][k]) * 0.5;