X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?p=inn-innduct.git;a=blobdiff_plain;f=backends%2Finnduct.c;h=b9460ed598a62a205ef865608cbab2151815bc49;hp=57eb9dba3e99e11b76ad94f4e19c8285038dfad3;hb=2092e752db3c70a7f576390ce8744d0618df088b;hpb=16b062df83f3b4c969c5fcb605b0e3094e56f0ee diff --git a/backends/innduct.c b/backends/innduct.c index 57eb9db..b9460ed 100644 --- a/backends/innduct.c +++ b/backends/innduct.c @@ -15,28 +15,38 @@ * or might be blanked out * .... * - * site.name_duct.lock lock preventing multiple ducts - * holder of this lock is "duct" * F site.name main feed file * opened/created, then written, by innd * read by duct * unlinked by duct * tokens blanked out by duct when processed - * D site.name_duct temporary feed file during flush (or crash) + * site.name_lock lock preventing multiple ducts + * to hold lock must open,F_SETLK[W] + * and then stat to check that locked file + * still has name site.name_lock + * holder of this lock is "duct" + * (only) lockholder may remove the lockfile + * D site.name_flushing temporary feed file during flush (or crash) * hardlink created by duct * unlinked by duct - * site.name_duct.defer 431'd articles, still being written, + * site.name_defer 431'd articles, still being written, * created, written, used by duct - * site.name_backlog.lock lock taken out by innxmit wrapper - * holder and its child are "xmit" - * site.name_backlog_. + * + * site.name_backlog.. * 431'd articles, ready for innxmit or duct * created (link/mv) by duct - * site.name_backlog_ eg - * site.name_backlog_manual + * site.name_backlog (where does not + * contain '#' or '~') eg + * site.name_backlog.manual * anything the sysadmin likes (eg, feed files * from old feeds to be merged into this one) * created (link/mv) by admin + * may be symlinks (in which case links + * may be written through, but only links + * will be removed. + * + * It is safe to remove backlog files manually, + * if it's desired to throw away the backlog. * * Backlog files are also processed by innduct. We find the oldest * backlog file which is at least a certain amount old, and feed it @@ -46,33 +56,20 @@ * If we don't have a backlog file that we're reading, we close the * defer file that we're writing and make it into a backlog file at * the first convenient opportunity. + * -8<- OVERALL STATES: START | - check D, F - | - <--------------------------------------'| - Nothing F, D both ENOENT | - F: ENOENT | - D: ENOENT | - duct: not not reading anything | - | | - |`---------------------. | - | | duct times out waiting for F | - V innd creates F | duct exits | - | V | - Noduct GO TO Dropped | - F: innd writing | - D: ENOENT | - duct: not running or not reading anything | - | | - | | - ,-->--+ <---------------------------------'| - | | duct opens F F exists | - | | D ENOENT | + ,-->--. check F, D + | | | + | | | + | | <----------------<---------------------------------'| + | | F exists | + | | D ENOENT | + | | duct opens F | | V | | Normal | | F: innd writing, duct reading | @@ -86,31 +83,35 @@ | F == D: innd writing, duct reading both exist | ^ | | | | duct unlinks F | - | V | - | Moved <----+------------<--'| - | F: ENOENT | F ENOENT | - | D: innd writing, duct reading | D exists | - | | | | - | | duct requests flush of feed | | - | | (others can too, harmlessly) | | - | V | | - | Flushing | | - | F: ENOENT | | - | D: innd flushing, duct reading | | - | | | | - | | inndcomm flush fails | | - | |`-------------------------->---------' | - | | | + | | <-----------<-------------<--'| + | | open D F ENOENT | + | | if exists | + | | | + | V <---------------------. | + | Moved | | + | F: ENOENT | | + | D: innd writing, duct reading; or ENOENT | | + | | | | + | | duct requests flush of feed | | + | | (others can too, harmlessly) | | + | V | | + | Flushing | | + | F: ENOENT | | + | D: innd flushing, duct; or ENOENT | | + | | | | + | | inndcomm flush fails | | + | |`-------------------------->------------------' | + | | | | | inndcomm reports no such site | | |`---------------------------------------------------- | -. - | | | | + | | | | | | innd finishes writing D, creates F | | | | inndcomm reports flush successful | | | | | | | V | | | Separated <----------------' | | F: innd writing F!=D / - | D: duct reading both exist / + | D: duct reading; or ENOENT both exist / | | / | | duct gets to the end of D / | | duct opens F too / @@ -135,7 +136,12 @@ "duct reading" means innduct is reading the file but also overwriting processed tokens. + * ->8- -^L- * + * rune for printing diagrams: + +perl -ne 'print if m/-8\<-/..m/-\>8-/; print "\f" if m/-\^L-/' backends/innduct.c |a2ps -R -B -ops + * */ @@ -249,7 +255,6 @@ typedef struct InputFile { void *readable_callback_user; int fd; - const char *path; /* ptr copy of path_ or feedfile */ struct Filemon_Perfile *filemon; oop_read *rd; @@ -257,17 +262,28 @@ typedef struct InputFile { off_t offset; Counts counts; + char path[]; } InputFile; +#define SMS_LIST(X) \ + X(NORMAL) \ + X(FLUSHING) \ + X(FLUSHFAILED) \ + X(SEPARATED) \ + X(DROPPING) \ + X(DROPPED) + typedef enum { - sm_WAITING, - sm_NORMAL, - sm_FLUSHING, - sm_FLUSHFAIL, - sm_SEPARATED, - sm_DROPPING, +#define SMS_DEF_ENUM(s) sm_##s, + SMS_LIST(SMS_DEF_ENUM) } StateMachineState; +static const char *sms_names[]= { +#define SMS_DEF_NAME(s) #s , + SMS_LIST(SMS_DEF_NAME) + 0 +}; + struct Conn { ISNODE(Conn); int fd, max_queue, stream; @@ -281,19 +297,18 @@ struct Conn { /*----- operational variables -----*/ -static int since_connect_attempt; static int nconns; static LIST(Conn) idle, working, full; static LIST(Article) *queue; -static char *path_ductlock, *path_duct, *path_ductdefer; +static char *path_lock, *path_flushing, *path_defer; #define SMS(newstate, periods, why) \ (statemc_setstate(sm_##newstate,(periods),#newstate,(why))) static StateMachineState sms; static FILE *defer; -static InputFile *main_input_file, *old_input_file, *backlog_input_file; +static InputFile *main_input_file, *flushing_input_file, *backlog_input_file; static int sm_period_counter; @@ -363,6 +378,11 @@ static int xwaitpid(pid_t *pid, const char *what) { return status; } +static void xunlink(const char *path, const char *what) { + int r= unlink(path); + if (r) sysdie("can't unlink %s %s", path, what); +} + static void check_isreg(const struct stat *stab, const char *path, const char *what) { if (!S_ISREG(stab->st_mode)) @@ -452,6 +472,7 @@ logwrap(warn, " warning", LOG_WARN, -1, 0); logwrap(notice, "", LOG_NOTICE, -1, 0); logwrap(info, " info", LOG_INFO, -1, 0); +logwrap(debug, " debug", LOG_DEBUG, -1, 0); /*========== making new connections ==========*/ @@ -928,11 +949,14 @@ static Article *article_reply_check(Connection *conn, const char *response, static void update_nocheck(int accepted) { accept_proportion *= accept_decay; accept_proportion += accepted; - nocheck= accept_proportion >= nocheck_thresh; - if (nocheck && !nocheck_reported) { + int new_nocheck= accept_proportion >= nocheck_thresh; + if (new_nocheck && !nocheck_reported) { notice("entering nocheck mode for the first time"); nocheck_reported= 1; + } else if (new_nocheck != nockech) { + debug("nocheck mode %s", new_nocheck ? "start" : "stop"); } + nocheck= new_nocheck; } static void article_done(Connection *conn, Article *art, int whichcount) { @@ -963,8 +987,8 @@ static void article_done(Connection *conn, Article *art, int whichcount) { ipf->inprogress--; assert(ipf->inprogress >= 0); - if (!ipf->inprogress) - loop->on_time(loop, OOP_TIME_NOW, statemc_check_input_done, ipf); + if (!ipf->inprogress && ipf != main_input_file) + queue_check_input_done(); free(art); } @@ -1058,7 +1082,7 @@ static void *peer_rd_ok(oop_source *lp, oop_read *oread, oop_event ev, open_defer(); if (fprintf(defer, "%s %s\n", TokenToText(art->token), art->messageid) <0 || fflush(defer)) - sysfatal("write to defer file %s",path_ductdefer); + sysfatal("write to defer file %s",path_defer); article_done(conn, art, RC_deferred); break; @@ -1074,26 +1098,20 @@ static void *peer_rd_ok(oop_source *lp, oop_read *oread, oop_event ev, static void feedfile_eof(InputFile *ipf) { assert(ipf != main_input_file); /* promised by tailing_try_read */ - inputfile_tailing_stop(ipf); - - if (ipf == backlog_input_file) { - assert(ipf->fd >= 0); - if (close(ipf->fd)) sysdie("could not close backlog file %s", ipf->path); - ipf->fd= -1; - return; - } - - assert(ipf == old_input_file); - inputfile_tailing_stop(ipf); assert(ipf->fd >= 0); if (close(ipf->fd)) sysdie("could not close input file %s", ipf->path); ipf->fd= -1; - assert(sms==sm_SEPARATED || sms==sm_DROPPING); - - if (main_input_file) - inputfile_tailing_start(main_input_file); + if (ipf == flushing_input_file) { + assert(sms==sm_SEPARATED || sms==sm_DROPPING); + if (main_input_file) inputfile_tailing_start(main_input_file); + statemc_check_flushing_done(); + } else if (ipf == backlog_input_file) { + statemc_check_backlog_done(); + } else { + abort(); /* supposed to wait rather than get EOF on main input file */ + } } static InputFile *open_input_file(const char *path) { @@ -1103,7 +1121,7 @@ static InputFile *open_input_file(const char *path) { sysfatal("unable to open input file %s", path); } - InputFile *ipf= xmalloc(sizeof(InputFile)); + InputFile *ipf= xmalloc(sizeof(*ipf) + strlen(path) + 1); memset(ipf,0,sizeof(*ipf)); ipf->readable.on_readable= tailing_on_readable; @@ -1111,7 +1129,7 @@ static InputFile *open_input_file(const char *path) { ipf->readable.try_read= tailing_try_read; ipf->fd= fd; - ipf->path= path; + strcpy(ipf->path, path); return ipf; } @@ -1124,10 +1142,6 @@ static void close_input_file(InputFile *ipf) { if (ipf->fd >= 0) if (close(ipf->fd)) sysdie("could not close input file %s", ipf->path); - - fixme maybe free ipf->path; - - free(ipf); } @@ -1167,24 +1181,31 @@ typedef void *feedfile_got_article(oop_source *lp, oop_read *rd, } ipf->offset += recsz + 1; - if (sms==sm_NORMAL && ipf->offset >= flush_threshold) { - notice("starting flush (%lu >= %lu)", - (unsigned long)ipf->offset, (unsigned long)flush_threshold); + if (sms==sm_NORMAL && ipf==main_input_file && + ipf->offset >= flush_threshold) + statemc_start_flush("feed file size"); - int r= link(feedfile, duct_path); - if (r) sysdie("link feedfile %s to ductfile %s", feedfile, dut_path); - /* => Hardlinked */ + check_master_queue(); +} - r= unlink(feedfile); - if (r) sysdie("unlink old feedfile link %s", feedfile); - /* => Moved */ +static void statemc_start_flush(const char *why) { /* Normal => Flushing */ + assert(sms == sm_NORMAL); - spawn_inndcomm_flush(); /* => Flushing, sets sms to sm_FLUSHING */ - } + debug("starting flush (%s) (%lu >= %lu) (%d)", + why, + (unsigned long)ipf->offset, (unsigned long)flush_threshold, + sm_period_counter); - check_master_queue(); -} + int r= link(feedfile, duct_path); + if (r) sysdie("link feedfile %s to flushing file %s", feedfile, + path_duct); + /* => Hardlinked */ + xunlink(feedfile, "old feedfile link"); + /* => Moved */ + + spawn_inndcomm_flush(why); /* => Flushing FLUSHING */ +} /*========== tailing input file ==========*/ @@ -1221,6 +1242,12 @@ static void on_cancel(struct oop_readable *rable) { ipf->readable_callback= 0; } +static void tailing_queue_readable(InputFile *ipf) { + /* lifetime of ipf here is OK because destruction will cause + * on_cancel which will cancel this callback */ + loop->on_time(loop, OOP_TIME_NOW, tailing_rable_call_time, ipf); +} + static int tailing_on_readable(struct oop_readable *rable, oop_readable_call *cb, void *user) { InputFile *ipf= (void*)rable; @@ -1230,7 +1257,7 @@ static int tailing_on_readable(struct oop_readable *rable, ipf->readable_callback_user= user; filemon_startfile(ipf); - loop->on_time(loop, OOP_TIME_NOW, tailing_rable_call_time, ipf); + tailing_queue_readable(ipf); return 0; } @@ -1247,7 +1274,7 @@ static ssize_t tailing_try_read(struct oop_readable *rable, void *buffer, if (ipf==main_input_file) { errno=EAGAIN; return -1; - } else if (ipf==old_input_file) { + } else if (ipf==flushing_input_file) { assert(ipf->fd>=0); assert(sms==sm_SEPARATED || sms==sm_DROPPING); } else if (ipf==backlog_input_file) { @@ -1291,11 +1318,15 @@ static void filemon_method_startfile(InputFile *ipf, Filemon_Perfile *pf) { assert(!filemon_inotify_wd2ipf[wd]); filemon_inotify_wd2ipf[wd]= ipf; + debug("filemon inotify startfile %p wd=%d wdmax=%d", + ipf, wd, filemon_inotify_wdmax); + pf->wd= wd; } static void filemon_method_stopfile(InputFile *ipf, Filemon_Perfile *pf) { int wd= pf->wd; + debug("filemon inotify stopfile %p wd=%d", ipf, wd); int r= inotify_rm_watch(filemon_inotify_fd, filemon_inotify_wd); if (r) sysdie("inotify_rm_watch"); filemon_inotify_wd2ipf[wd]= 0; @@ -1315,6 +1346,7 @@ static void *filemon_inotify_readable(oop_source *lp, int fd, die("inotify read %d bytes wanted struct of %d", r, (int)sizeof(iev)); } InputFile *ipf= filemon_inotify_wd2ipf[iev.wd]; + debug("filemon inotify readable read %p wd=%p", iev.wd, ipf); filemon_callback(ipf); } return OOP_CONTINUE; @@ -1329,6 +1361,7 @@ static int filemon_method_init(void) { set nonblock; loop->on_fd(loop, filemon_inotify_fd, OOP_READ, filemon_inotify_readable); + debug("filemon inotify init filemon_inotify_fd=%d", filemon_inotify_fd); return 1; } @@ -1386,99 +1419,114 @@ static void inputfile_tailing_stop(InputFile *ipf) { /* See official state diagram at top of file. We implement * this as follows: - - ================ - WAITING - [Nothing/Noduct] - poll for F - ================ - | - | TIMEOUT and no defer, no backlog - |`--------------------------. - | | - | OPEN F SUCCEEDS | exit - ,--------->| V - | V ========= - | ======== (ESRCH) - | NORMAL [Dropped] - | [Normal] ========= - | main F tail - | ======== - | | - | | F IS SO BIG WE SHOULD FLUSH - ^ | hardlink F to D - | [Hardlinked] - | | unlink F - | | our handle onto F is now onto D - | [Moved] - | | - | |<---------------------------------------------------. + * -8<- + + .=======. + ||START|| + `=======' + | + | open F + | + | F ENOENT + |`---------------------------------------------------. + F OPEN OK | | + |`---------------- - - - | + D ENOENT | D EXISTS see OVERALL STATES diagram | + | for full startup logic | + ,--------->| | + | V | + | ============ try to | + | NORMAL open D | + | [Normal] | + | main F tail | + | ============ V + | | | + | | F IS SO BIG WE SHOULD FLUSH, OR TIMEOUT | + ^ | hardlink F to D | + | [Hardlinked] | + | | unlink F | + | | our handle onto F is now onto D | + | [Moved] | + | | | + | |<-------------------<---------------------<---------+ | | | | | spawn inndcomm flush | | V | - | ========== | - | FLUSHING | + | ================== | + | FLUSHING[-ABSENT] | | [Flushing] | - | main D tail | - | ========== | + | main D tail/none | + | ================== | | | | | | INNDCOMM FLUSH FAILS ^ | |`----------------------->----------. | | | | | | | NO SUCH SITE V | - ^ |`--------------->----. =========== | - | | \ FLUSHFAIL | - | | \ [Moved] | - | | \ main D tail | - | | \ =========== | + ^ |`--------------->----. ==================== | + | | \ FLUSHFAILED[-ABSENT] | + | | \ [Moved] | + | | FLUSH OK \ main D tail/none | + | | open F \ ==================== | | | \ | | | | \ | TIME TO RETRY | - | | \ `----------------' - | | FLUSH OK \ - | | open F \ - | V V - | ============= ============ - | SEPARATED/ DROPPING/ - | old->fd>=0 old->fd>=0 - | [Separated] [Dropping] - | main F idle main none - | old D tail old D tail - | ============= ============ - | | | - ^ | EOF ON D | EOF ON D - | V V - | =============== =============== - | SEPARATED/ DROPPING/ - | old->fd==-1 old->fd==-1 - | [Finishing] [Dropping] - | main F tail main none - | old D closed old D closed - | =============== =============== - | | | - | | ALL D PROCESSED | ALL D PROCESSED - | V install defer as backlog V install defer as backlog - ^ | close D | close D - | | unlink D | unlink D - | | | exit - `----------' V - ========== - (ESRCH) - [Droppped] - ========== + | |`------->----. ,---<---'\ `----------------' + | | D NONE | | D NONE `----. + | V | | V + | ============= V V ============ + | SEPARATED-1 | | DROPPING-1 + | flsh->fd>=0 | | flsh->fd>=0 + | [Separated] | | [Dropping] + | main F idle | | main none + | old D tail | | old D tail + | ============= | | ============ + | | | | install | + ^ | EOF ON D | | defer | EOF ON D + | V | | V + | =============== | | =============== + | SEPARATED-2 | | DROPPING-2 + | flsh->fd==-1 | V flsh->fd==-1 + | [Finishing] | | [Dropping] + | main F tail | `. main none + | old D closed | `. old D closed + | =============== V `. =============== + | | `. | + | | ALL D PROCESSED `. | ALL D PROCESSED + | V install defer as backlog `. | install defer + ^ | close D `. | close D + | | unlink D `. | unlink D + | | | | + | | V V + `----------' ============== + DROPPED + [Dropped] + main none + old none + some backlog + ============== + | + | ALL BACKLOG DONE + | + | unlink lock + | exit + V + ========== + (ESRCH) + [Droppped] + ========== + * ->8- */ static void statemc_init(void) { struct stat stab, stabf; - int noent; - path_ductlock= xasprintf("%s_duct.lock", feedfile); - path_duct= xasprintf("%s_duct", feedfile); - path_ductdefer= xasprintf("%s_duct.defer", feedfile); - globpat_backlog= xasprintf("%s_backlog_*", feedfile); + path_lock= xasprintf("%s_lock", feedfile); + path_flushing= xasprintf("%s_flushing", feedfile); + path_defer= xasprintf("%s_defer", feedfile); + globpat_backlog= xasprintf("%s_backlog*", feedfile); for (;;) { - int lockfd= open(path_ductlock, O_CREAT|O_RDWR, 0600); - if (lockfd<0) sysfatal("open lockfile %s", path_ductlock); + int lockfd= open(path_lock, O_CREAT|O_RDWR, 0600); + if (lockfd<0) sysfatal("open lockfile %s", path_lock); struct flock fl; memset(&fl,0,sizeof(fl)); @@ -1490,24 +1538,26 @@ static void statemc_init(void) { if (quiet_if_locked) exit(0); fatal("another duct holds the lockfile"); } - sysdie("fcntl F_SETLK lockfile %s", path_ductlock); + sysdie("fcntl F_SETLK lockfile %s", path_lock); } xfstat_isreg(lockfd, &stabf, "lockfile"); - xlstat_isreg(path_ductlock, &stab, &noent, "lockfile"); + int lock_noent; + xlstat_isreg(path_lock, &stab, &lock_noent, "lockfile"); - if (!noent && samefile(&stab, &stabf)) + if (!lock_noent && samefile(&stab, &stabf)) break; if (close(lockfd)) - sysdie("could not close stale lockfile %s", path_ductlock); + sysdie("could not close stale lockfile %s", path_lock); } debug("startup: locked"); search_backlog_file(); - xlstat_isreg(path_ductdefer, &stab, &noent, "defer file"); - if (noent) { + int defer_noent; + xlstat_isreg(path_defer, &stab, &defer_noent, "defer file"); + if (defer_noent) { debug("startup: ductdefer ENOENT"); } else { debug("startup: ductdefer nlink=%ld", (long)stab.st_nlink); @@ -1516,9 +1566,8 @@ static void statemc_init(void) { open_defer(); /* so that we will later close it and rename it */ break; case 2: - if (unlink(path_defer)) - sysdie("could not unlink stale defer file link %s (presumably" - " hardlink to backlog file)", path_defer); + xunlink(path_defer, "stale defer file link" + " (presumably hardlink to backlog file)"); break; default: die("defer file %s has unexpected link count %d", @@ -1526,133 +1575,148 @@ static void statemc_init(void) { } } - InputFile *file_d= open_input_file(path_duct); + struct stat stab_f, stab_d; + int noent_f; - if (file_d) { - struct stat stab_f, stab_d; + InputFile *file_d= open_input_file(path_flushing); + if (file_d) xfstat_isreg(file_d->fd, &stab_d, "flushing file"); - xlstat_isreg(feedfile, &stab_f, &noent, "feed file"); - if (noent) { - debug("startup: D exists, F ENOENT => Moved"); - goto found_moved; - } + xlstat_isreg(feedfile, &stab_f, &noent_f, "feedfile"); - debug("startup: F and D both exist"); - - xfstat_isreg(file_d->fd, &stab_d, "ductfile"); + if (!noent_f && file_d && samefile(&stab_f, &stab_d)) { + debug("startup: F==D => Hardlinked"); + xunlink(feedfile, "feed file (during startup)"); /* => Moved */ + noent_f= 1; + } - if (samefile(&stab_d, &stab_f)) { - debug("startup: F==D => Hardlinked"); - r= unlink(path_duct); - if (r) sysdie("unlink feed file %s during startup", feedfile); - found_moved: - debug(" => Moved"); + if (noent_f) { + debug("startup: F ENOENT => Moved"); + if (file_d) startup_set_input_file(file_d); + spawn_inndcomm_flush("feedfile missing at startup"); + /* => Flushing, sms:=FLUSHING */ + } else { + if (file_d) { + debug("startup: F!=D => Separated"); startup_set_input_file(file_d); - spawn_inndcomm_flush(); /* => Flushing, sets sms to sm_FLUSHING */ - } else { - debug("F!=D => Separated"); SMS(SEPARATED, 0, "found both old and current feed files"); - startup_set_input_file(file_d); + } else { + debug("startup: F exists, D ENOENT => Normal"); + FILE *file_f= open_input_file(feedfile); + if (!file_f) die("feed file vanished during startup"); + startup_set_input_file(file_f); + SMS(NORMAL, flushfail_retry_periods, "normal startup"); } - } else { - debug("startup: D ENOENT => Nothing"); - SMS(WAITING, open_wait_periods, "no feed file currently exists"); } } -static void statemc_poll(void) { - if (sms==sm_WAITING) { statemc_waiting_poll(); return; } - +static void statemc_period_poll(void) { if (!sm_period_counter) return; sm_period_counter--; assert(sm_period_counter>=0); if (sm_period_counter) return; switch (sms) { - case sm_WAITING: - fatal("timed out waiting for innd to create feed file %s", feedfile); - case sm_FLUSHFAIL: - spawn_inndcomm_flush(void); + case sm_NORMAL: + statemc_start_flush("periodic"); /* Normal => Flushing; => FLUSHING */ + break; + case sm_FLUSHFAILED: + spawn_inndcomm_flush("retry"); /* Moved => Flushing; => FLUSHING */ break; default: abort(); } } -static void statemc_waiting_poll(void) { - InputFile *file_f= open_input_file(feedfile); - if (!file_f) return; - startup_set_input_file(file_d); - SMS(NORMAL, 0, "found and opened feed file"); -} - static void startup_set_input_file(InputFile *f) { assert(!main_input_file); main_input_file= f; inputfile_tailing_start(f); } -static void *statemc_check_input_done(oop_source *lp, - struct timeval now, void *ipf_v) { - InputFile *ipf= ipf_v; - struct stat stab; - - if (ipf->inprogress) return; /* new article in the meantime */ - if (ipf->fd >= 0); return; /* not had EOF */ - - if (ipf == backlog_input_file) { - notice_processed(ipf,"backlog file",ipf->path); - close_input_file(ipf); - if (unlink(ipf->path)) { - if (errno != ENOENT) - sysdie("could not unlink processed backlog file %s", ipf->path); - warn("backlog file %s vanished while we were reading it" - " so we couldn't remove it (but it's done now, anyway)", - ipf->path); - } - backlog_input_file= 0; - search_backlog_file(); - return; +static int inputfile_is_done(InputFile *ipf) { + if (!ipf) return 0; + if (ipf->inprogress) return 0; /* new article in the meantime */ + if (ipf->fd >= 0); return 0; /* not had EOF */ + return 1; +} + +static void statemc_check_backlog_done(void) { + InputFile *ipf= backlog_input_file(); + if (!inputfile_is_done(ipf)) return; + + notice_processed(ipf,"backlog file",ipf->path); + close_input_file(ipf); + if (unlink(ipf->path)) { + if (errno != ENOENT) + sysdie("could not unlink processed backlog file %s", ipf->path); + warn("backlog file %s vanished while we were reading it" + " so we couldn't remove it (but it's done now, anyway)", + ipf->path); } + free(ipf); + backlog_input_file= 0; + search_backlog_file(); + return; +} + +static void statemc_check_flushing_done(void) { + InputFile *ipf= flushing_input_file; + if (!inputfile_is_done(ipf)) return; - assert(ipf == old_input_file); assert(sms==sm_SEPARATED || sms==sm_DROPPING); notice_processed(ipf,"feed file",0); close_defer(); - if (unlink(path_duct)) - sysdie("could not unlink old duct file %s", path_duct); + xunlink(path_flushing, "old flushing file"); - if (sms==sm_DROPPING) { - if (search_backlog_file()) { - debug("feed dropped but still backlogs to process"); - return; - } - notice("feed dropped and our work is complete"); - r= unlink(path_ductlock); - if (r) sysdie("unlink lock file for old feed %s", path_ductlock); - exit(0); - } + close_input_file(flushing_input_file); + free(flushing_input_file); + flushing_input_file= 0; - open_defer(); + if (sms==sm_SEPARATED) { + notice("flush complete"); + SMS(NORMAL, 0, "flush complete"); + } else if (sms==sm_DROPPING) { + SMS(DROPPED, 0, "old flush complete"); + search_backlog_file(); + notice("feed dropped, but will continue until backlog is finished"); + } +} - close_input_file(old_input_file); - old_input_file= 0; +static void *statemc_check_input_done(oop_source *lp, struct timeval now, + void *u) { + assert(!inputfile_is_done(main_input_file)); + statemc_check_flushing_done(); + statemc_check_backlog_done(); + return OOP_CONTINUE; +} - notice("flush complete"); - SMS(NORMAL, 0, "flush complete"); +static void queue_check_input_done(void) { + loop->on_time(loop, OOP_TIME_NOW, statemc_check_input_done, 0); } static void statemc_setstate(StateMachineState newsms, int periods, const char *forlog, const char *why) { sms= newsms; sm_period_counter= periods; + + const char *xtra= ""; + switch (sms) { + case sm_FLUSHING: sm_FLUSHFAILED: + if (!main_input_file) xtra= "-ABSENT"; + break; + case sm_SEPARATED: case sm_DROPPING: + xtra= flushing_input_file->fd >= 0 ? "-1" : "-2"; + break; + default:; + } + if (periods) { - info("%s[%d] %s",periods,forlog,why); + info("%s%s[%d] %s",forlog,xtra,periods,why); } else { - info("%s %s",forlog,why); + info("%s%s %s",forlog,xtra,why); } } @@ -1663,15 +1727,15 @@ static void open_defer(void) { if (defer) return; - defer= fopen(path_ductdefer, "a+"); - if (!defer) sysfatal("could not open defer file %s", path_ductdefer); + defer= fopen(path_defer, "a+"); + if (!defer) sysfatal("could not open defer file %s", path_defer); /* truncate away any half-written records */ xfstat_isreg(fileno(defer), &stab, "newly opened defer file"); if (stab.st_size > LONG_MAX) - die("defer file %s size is far too large", path_ductdefer); + die("defer file %s size is far too large", path_defer); if (!stab.st_size) return; @@ -1681,14 +1745,14 @@ static void open_defer(void) { for (;;) { if (!truncto) break; /* was only (if anything) one half-truncated record */ if (fseek(defer, truncto-1, SEEK_SET) < 0) - sysdie("seek in defer file %s while truncating partial", path_ductdefer); + sysdie("seek in defer file %s while truncating partial", path_defer); r= getc(defer); if (r==EOF) { if (ferror(defer)) - sysdie("failed read from defer file %s", path_ductdefer); + sysdie("failed read from defer file %s", path_defer); else - die("defer file %s shrank while we were checking it!", path_ductdefer); + die("defer file %s shrank while we were checking it!", path_defer); } if (r=='\n') break; truncto--; @@ -1697,19 +1761,19 @@ static void open_defer(void) { if (stab.st_size != truncto) { warn("truncating half-record at end of defer file %s -" " shrinking by %ld bytes from %ld to %ld", - path_ductdefer, orgsize - truncto, orgsize, truncto); + path_defer, orgsize - truncto, orgsize, truncto); if (fflush(defer)) - sysfatal("could not flush defer file %s", path_ductdefer); + sysfatal("could not flush defer file %s", path_defer); if (ftruncate(fileno(defer), truncto)) - sysdie("could not truncate defer file %s", path_ductdefer); + sysdie("could not truncate defer file %s", path_defer); } else { info("continuing existing defer file %s (%ld bytes)", - path_ductdefer, orgsize); + path_defer, orgsize); } if (fseek(defer, truncto, SEEK_SET)) - sysdie("could not seek to new end of defer file %s", path_ductdefer); + sysdie("could not seek to new end of defer file %s", path_defer); } static void close_defer(void) { @@ -1731,18 +1795,18 @@ static void close_defer(void) { sysdie("could not unlink old defer link %s to backlog file %s", path_defer, backlog); - if (backlog_nextscan_periods < 0 || - backlog_nextscan_periods > backlog_retry_minperiods + 1) - backlog_nextscan_periods= backlog_retry_minperiods + 1; + if (until_backlog_nextscan < 0 || + until_backlog_nextscan > backlog_retry_minperiods + 1) + until_backlog_nextscan= backlog_retry_minperiods + 1; } static void poll_backlog_file(void) { - if (backlog_nextscan_periods < 0) return; - if (backlog_nextscan_periods-- > 0) return; + if (until_backlog_nextscan < 0) return; + if (until_backlog_nextscan-- > 0) return; search_backlog_file(); } -static int search_backlog_file(void) { +static void search_backlog_file(void) { /* returns non-0 iff there are any backlog files */ glob_t gl; @@ -1765,6 +1829,11 @@ static int search_backlog_file(void) { case 0: for (i=0; i= 0 && - backlog_nextscan_periods > backlog_spontaneous_rescan_periods) - backlog_nextscan_periods= backlog_spontaneous_rescan_periods; + until_backlog_nextscan > backlog_spontaneous_rescan_periods) + until_backlog_nextscan= backlog_spontaneous_rescan_periods; debug("backlog scan: young age=%f deficiency=%ld nextscan=%d oldest=%s", - age, age_deficiency, backlog_nextscan_periods, oldest_path); + age, age_deficiency, until_backlog_nextscan, oldest_path); return 2; } @@ -1833,7 +1908,7 @@ static void *inndcomm_event(oop_source *lp, int fd, oop_event e, void *u) { loop->cancel_fd(fd); close(fd); - assert(!old_input_file); + assert(!flushing_input_file); if (WIFEXITED(status)) { switch (WEXITSTATUS(status)) { @@ -1843,17 +1918,38 @@ static void *inndcomm_event(oop_source *lp, int fd, oop_event e, void *u) { case INNDCOMMCHILD_ESTATUS_NONESUCH: warn("feed has been dropped by innd, finishing up"); - old_input_file= main_input_file; + flushing_input_file= main_input_file; + tailing_queue_readable(flushing_input_file); + /* we probably previously returned EAGAIN from our fake read method + * when in fact we were at EOF, so signal another readable event + * so we actually see the EOF */ + main_input_file= 0; - SMS(DROPPING, 0, "dropped by innd"); + + if (flushing_input_file) { + SMS(DROPPING, 0, "feed dropped by innd, but must finish last flush"); + } else { + close_defer(); + SMS(DROPPED, 0, "feed dropped by innd"); + search_backlog_file(); + } return OOP_CONTINUE; case 0: - old_input_file= main_input_file; + /* as above */ + flushing_input_file= main_input_file; + tailing_queue_readable(flushing_input_file); + main_input_file= open_input_file(feedfile); if (!main_input_file) die("flush succeeded but feedfile %s does not exist!", feedfile); - SMS(SEPARATED, 0, "feed file missing"); + + if (flushing_input_file) { + SMS(SEPARATED, spontaneous_flush_periods, "recovery flush complete"); + } else { + close_defer(); + SMS(NORMAL, spontaneous_flush_periods, "flush complete"); + } return OOP_CONTINUE; default: @@ -1869,7 +1965,7 @@ static void *inndcomm_event(oop_source *lp, int fd, oop_event e, void *u) { } failed: - SMS(FLUSHFAIL, flushfail_retry_periods, "flush failed, will retry"); + SMS(FLUSHFAILED, flushfail_retry_periods, "flush failed, will retry"); } static void inndcommfail(const char *what) { @@ -1877,10 +1973,12 @@ static void inndcommfail(const char *what) { exit(INNDCOMMCHILD_ESTATUS_FAIL); } -void spawn_inndcomm_flush(void) { +void spawn_inndcomm_flush(const char *why) { /* Moved => Flushing */ int pipefds[2]; - assert(sms==sm_NORMAL || sms==sm_FLUSHFAIL); + notice("flushing %s",why); + + assert(sms==sm_NORMAL || sms==sm_FLUSHFAILED); assert(!inndcomm_child); if (pipe(pipefds)) sysdie("create pipe for inndcomm child sentinel"); @@ -1907,7 +2005,7 @@ void spawn_inndcomm_flush(void) { int sentinel_fd= pipefds[0]; on_fd_read_except(sentinel_fd, inndcomm_event); - SMS(FLUSHING, 0, "flush is in progress"); + SMS(FLUSHING, 0, why); } /*========== main program ==========*/ @@ -1936,7 +2034,7 @@ static void postfork(const char *what) { sysdie("%s child: failed to reset SIGPIPE"); postfork_inputfile(main_input_file); - postfork_inputfile(old_input_file); + postfork_inputfile(flushing_input_file); postfork_conns(idle.head); postfork_conns(working.head); postfork_conns(full.head); @@ -1959,11 +2057,34 @@ EVERY(filepoll, {5,0}, { filemon_callback(main_input_file); }); +#define DEBUGF_IPF(wh) " " #wh "=%p/%s:ip=%ld,off=%ld,fd=%d%s" \ +#define DEBUG_IPF(sh) \ + wh##_input_file, debug_ipf_path(wh##_input_file), \ + wh##_input_file->inprogress, (long)wh##_input_file->offset, \ + wh##_input_file->fd, wh##_input_file->rd ? "+" : "" +static const char *debug_ipf_path(InputFile *ipf) { + char *slash= strrchr(ipf->path,'/'); + return slash ? slash+1 : ipf->path; +} + EVERY(period, {PERIOD_SECONDS,0}, { + debug("PERIOD" + " sms=%s[%d] queue=%d connect_delay=%d" + " input_files" DEBUGF_IPF(main) DEBUGF_IPF(old) DEBUGF_FMT(flushing) + " conns idle=%d working=%d full=%d" + " children connecting=%ld inndcomm_child" + , + sms_names[sms], sm_period_counter, queue.count, connect_delay, + DEBUG_IPF(main), DEBUG_IPF(flushing), DEBUG_IPF(flushing), + idle.count, working.count, full.count, + (long)connecting_child, (long)inndcomm_child + ); + if (connect_delay) connect_delay--; + poll_backlog_file(); if (!backlog_input_file) close_defer(); /* want to start on a new backlog */ - statemc_poll(); + statemc_period_poll(); check_master_queue(); }); @@ -2065,7 +2186,6 @@ static const Option options[]= { { 0, "max-queue-size", &max_queue_per_conn op_integer }, { 0, "reconnect-interval", &reconnect_delay_periods, op_periods_rndup }, { 0, "flush-retry-interval", &flushfail_retry_periods, op_periods_rndup }, -{ 0, "feedfile-open-timeout", &open_wait_periods, op_periods_rndup }, { 0, "connection-timeout", &connection_timeout, op_seconds }, { 0, "inndcomm-timeout", &inndcomm_flush_timeout, op_seconds }, }; @@ -2121,9 +2241,15 @@ int main(int argc, char **argv) { } if (!arg) badusage("need site name argument"); - if (*++argv) badusage("too many non-option arguments"); sitename= arg; + if ((arg= *++argv)) { + if (remote_host) badusage("must not specify -h and also host as argument"); + remote_host= arg; + } + + if (*++argv) badusage("too many non-option arguments"); + if (nocheck_thresh_pct < 0 || nocheck_thresh_pct > 100) badusage("nocheck threshold percentage must be between 0..100"); nocheck_thresh= nocheck_thresh_pct * 0.01; @@ -2141,11 +2267,11 @@ int main(int argc, char **argv) { else if (feedfile[strlen(feedfile)-1]=='/') feedfile= xasprintf("%s%s",feedfile,sitename); - const char *feedfile_forbidden= "?*["; + const char *feedfile_forbidden= "?*[~#"; int c; while ((c= *feedfile_forbidden++)) if (strchr(feedfile, c)) - badusage("feed filename may not contain glob metacharacter %c",c); + badusage("feed filename may not contain metacharacter %c",c); if (signal(SIGPIPE, SIG_IGN) == SIG_ERR) sysdie("could not ignore SIGPIPE");