X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?p=hippotat.git;a=blobdiff_plain;f=client;h=e6ea8edfb1b81442e14a7f1adcf21a3269f7c9cc;hp=c08b5fc9a63bcd80d382fcf82abfeb112b2d2c1f;hb=697be73ae820a076f6803820038c830dec3c966d;hpb=47191df1e45fed6fc6ec1c37f741a4a6a8588671;ds=sidebyside

diff --git a/client b/client
index c08b5fc..e6ea8ed 100755
--- a/client
+++ b/client
@@ -45,7 +45,10 @@ def process_cfg():
                     ('peer',  'server'),
                     ('rnets', 'routes')))
 
-outstanding = 0
+outstanding = { }
+
+def log_outstanding():
+  log_debug(DBG.CTRL_DUMP, 'OS %s' % outstanding)
 
 def start_client():
   global queue
@@ -58,63 +61,114 @@ def outbound(packet, saddr, daddr):
   queue.append(packet)
   check_outbound()
 
-class ResponseConsumer(twisted.internet.protocol.Protocol):
-  def __init__(self, req):
+class GeneralResponseConsumer(twisted.internet.protocol.Protocol):
+  def __init__(self, req, desc):
     self._req = req
-    self._ssd = SlipStreamDecoder(queue_inbound)
-    self._log(DBG.HTTP_CTRL, '__init__')
+    self._desc = desc
 
   def _log(self, dflag, msg, **kwargs):
-    log_debug(dflag, 'RC ' + msg, idof=self._req, **kwargs)
+    log_debug(dflag, '%s: %s' % (self._desc, msg), idof=self._req, **kwargs)
+
+  def connectionMade(self):
+    self._log(DBG.HTTP_CTRL, 'connectionMade')
+
+class ResponseConsumer(GeneralResponseConsumer):
+  def __init__(self, req):
+    super().__init__(req, 'RC')
+    ssddesc = '[%s] %s' % (id(req), self._desc)
+    self._ssd = SlipStreamDecoder(ssddesc, queue_inbound)
+    self._log(DBG.HTTP_CTRL, '__init__')
 
   def dataReceived(self, data):
     self._log(DBG.HTTP_CTRL, 'dataReceived', d=data)
     try:
-      self._ssd.inputdata(mime_translate(data))
+      self._ssd.inputdata(data)
     except Exception as e:
-      self._asyncfailure(e)
-
-  def connectionMade(self):
-    self._log(DBG.HTTP_CTRL, 'connectionMade')
+      self._handleexception()
 
   def connectionLost(self, reason):
     self._log(DBG.HTTP_CTRL, 'connectionLost ' + str(reason))
-    if reason.check(twisted.web.client.ResponseDone):
-      try: self._ssd.flush()
-      except Exception as e:
-        self._asyncfailure(e)
-    else:
-      self._asyncfailure(reason)
-
-  def _asyncfailure(self, reason):
+    if not reason.check(twisted.web.client.ResponseDone):
+      self.latefailure()
+      return
+    try:
+      self._ssd.flush()
+      req_fin(req)
+    except Exception as e:
+      self._handleexception()
+
+  def _handleexception(self):
+    self._latefailure(traceback.format_exc())
+
+  def _latefailure(self, reason):
     self._log(DBG.HTTP_CTRL, '_asyncFailure ' + str(reason))
-    global outstanding
-    outstanding += 1
     req_err(self._req, reason)
 
+class ErrorResponseConsumer(twisted.internet.protocol.Protocol):
+  def __init__(self, req, resp):
+    super().__init__(req, 'ERROR-RC')
+    self._resp = resp
+    self._m = b''
+    try:
+      self._phrase = resp.phrase.decode('utf-8')
+    except Exception:
+      self._phrase = repr(resp.phrase)
+    self._log(DBG.HTTP_CTRL, '__init__ %d %s' % (resp.code, self._phrase))
+
+  def dataReceived(self, data):
+    self._log(DBG.HTTP_CTRL, 'dataReceived ' + repr(data))
+    self._m += data
+
+  def connectionLost(self, reason):
+    try:
+      mbody = self._m.decode('utf-8')
+    except Exception:
+      mbody = repr(self._m)
+    if not reason.check(twisted.web.client.ResponseDone):
+      mbody += ' || ' + str(reason)
+    req_err(self._req,
+            "FAILED %d %s | %s"
+            % (self._resp.code, self._phrase, mbody))
+
 def req_ok(req, resp):
-  log_debug(DBG.HTTP_CTRL, 'req_ok ' + str(resp), idof=req)
-  rc = ResponseConsumer(req)
+  log_debug(DBG.HTTP_CTRL,
+            'req_ok %d %s %s' % (resp.code, repr(resp.phrase), str(resp)),
+            idof=req)
+  if resp.code == 200:
+    rc = ResponseConsumer(req)
+  else:
+    rc = ErrorResponseConsumer(req, resp)
+
   resp.deliverBody(rc)
-  req_fin(req)
+  # now rc is responsible for calling req_fin
 
 def req_err(req, err):
-  log_debug(DBG.HTTP_CTRL, 'req_err ' + str(err), idof=req)
-  print(err, file=sys.stderr)
-  reactor.callLater(c.http_retry, (lambda: req_fin(req)))
+  # called when the Deferred fails, or (if it completes),
+  # later, by ResponsConsumer or ErrorResponsConsumer
+  try:
+    log_debug(DBG.HTTP_CTRL, 'req_err ' + str(err), idof=req)
+    if isinstance(err, twisted.python.failure.Failure):
+      err = err.getTraceback()
+    print('[%#x] %s' % (id(req), err), file=sys.stderr)
+    if not isinstance(outstanding[req], int):
+      raise RuntimeError('[%#x] previously %s' % (id(req), outstanding[req]))
+    outstanding[req] = err
+    log_outstanding()
+    reactor.callLater(c.http_retry, (lambda: req_fin(req)))
+  except Exception as e:
+    crash(traceback.format_exc() + '\n----- handling -----\n' + err)
 
 def req_fin(req):
-  log_debug(DBG.HTTP_CTRL, 'req_fin', idof=req)
-  global outstanding
-  outstanding -= 1
+  del outstanding[req]
+  log_debug(DBG.HTTP_CTRL, 'req_fin OS=%d' % len(outstanding), idof=req)
   check_outbound()
 
 def check_outbound():
   global outstanding
 
   while True:
-    if                          outstanding >= c.max_outstanding   : break
-    if not queue.nonempty() and outstanding >= c.target_outstanding: break
+    if                          len(outstanding) >= c.max_outstanding   : break
+    if not queue.nonempty() and len(outstanding) >= c.target_outstanding: break
 
     d = b''
     def moredata(s): nonlocal d; d += s
@@ -159,11 +213,13 @@ def check_outbound():
                         twisted.web.client.Headers(hh),
                         producer)
 
-    log_debug(DBG.HTTP_CTRL, 'request', idof=req, d=d)
+    outstanding[req] = len(d)
+    log_debug(DBG.HTTP_CTRL, 'request OS=%d' % len(outstanding), idof=req, d=d)
     req.addTimeout(c.http_timeout, reactor)
     req.addCallback((lambda resp: req_ok(req, resp)))
     req.addErrback((lambda err: req_err(req, err)))
-    outstanding += 1
+
+  log_outstanding()
 
 common_startup()
 process_cfg()