ResponseConsumer: move _resp initialisation to superclass constructor (nfc)

[hippotat.git] / hippotat

diff --git a/hippotat b/hippotat
index a6ec7aec06405b8315d1120d50e70be83776eeb2..abe1caeb88b891f92f4c925e51d0c4c41030b95a 100755 (executable)
--- a/hippotat
+++ b/hippotat
@@ -30,9 +30,10 @@ import twisted.web.client
 import io
 
 class GeneralResponseConsumer(twisted.internet.protocol.Protocol):
-  def __init__(self, cl, req, desc):
+  def __init__(self, cl, req, resp, desc):
     self._cl = cl
     self._req = req
+    self._resp = resp
     self._desc = desc
 
   def _log(self, dflag, msg, **kwargs):
@@ -42,8 +43,8 @@ class GeneralResponseConsumer(twisted.internet.protocol.Protocol):
     self._log(DBG.HTTP_CTRL, 'connectionMade')
 
 class ResponseConsumer(GeneralResponseConsumer):
-  def __init__(self, cl, req):
-    super().__init__(cl, req, 'RC')
+  def __init__(self, cl, req, resp):
+    super().__init__(cl, req, resp, 'RC')
     ssddesc = '[%s] %s' % (id(req), self._desc)
     self._ssd = SlipStreamDecoder(ssddesc, partial(queue_inbound, cl.ipif))
     self._log(DBG.HTTP_CTRL, '__init__')
@@ -56,9 +57,10 @@ class ResponseConsumer(GeneralResponseConsumer):
       self._handleexception()
 
   def connectionLost(self, reason):
-    self._log(DBG.HTTP_CTRL, 'connectionLost ' + str(reason))
+    reason_msg = 'connectionLost ' + str(reason)
+    self._log(DBG.HTTP_CTRL, reason_msg)
     if not reason.check(twisted.web.client.ResponseDone):
-      self.latefailure()
+      self._latefailure(reason_msg)
       return
     try:
       self._log(DBG.HTTP, 'ResponseDone')
@@ -77,8 +79,7 @@ class ResponseConsumer(GeneralResponseConsumer):
 
 class ErrorResponseConsumer(GeneralResponseConsumer):
   def __init__(self, cl, req, resp):
-    super().__init__(cl, req, 'ERROR-RC')
-    self._resp = resp
+    super().__init__(cl, req, resp, 'ERROR-RC')
     self._m = b''
     try:
       self._phrase = resp.phrase.decode('utf-8')
@@ -138,7 +139,7 @@ class Client():
             'req_ok %d %s %s' % (resp.code, repr(resp.phrase), str(resp)),
             idof=req)
     if resp.code == 200:
-      rc = ResponseConsumer(cl, req)
+      rc = ResponseConsumer(cl, req, resp)
     else:
       rc = ErrorResponseConsumer(cl, req, resp)
 
@@ -150,6 +151,7 @@ class Client():
     # later, by ResponsConsumer or ErrorResponsConsumer
     try:
       cl.log(DBG.HTTP_CTRL, 'req_err ' + str(err), idof=req)
+      cl.running_reported = False
       if isinstance(err, twisted.python.failure.Failure):
         err = err.getTraceback()
       print('%s[%#x] %s' % (cl.desc, id(req), err.strip('\n').replace('\n',' / ')),