chiark / gitweb /
gpg: Don't assume that strtoul interprets "" as 0.
authorNeal H. Walfield <neal@g10code.com>
Thu, 2 Feb 2017 14:48:45 +0000 (15:48 +0100)
committerDaniel Kahn Gillmor <dkg@fifthhorseman.net>
Tue, 14 Feb 2017 00:29:34 +0000 (00:29 +0000)
commit2fb59ae3cf54472db52bbbc44760e768e310593e
treece9842348eadcb5568b638b9c43e0330a5ac9b7c
parent9c0bc558d70e770aadef789a259a6bb43ed26563
gpg: Don't assume that strtoul interprets "" as 0.

* g10/tofu.c (show_statistics): If there are not records, return 0
instead of NULL.

--
Signed-off-by: Neal H. Walfield <neal@g10code.com>
GnuPG-bug-id: 2853

According to SUSv3:

  If the subject sequence is empty or does not have the expected form,
  no conversion is performed
  ...
  If no conversion could be performed, 0 is returned and errno may be
  set to [EINVAL].

  http://pubs.opengroup.org/onlinepubs/007908799/xsh/strtol.html

It appears that MacOS X sets errno to EINVAL, but glibc doesn't.
Hence, we map NULL to 0 explicitly.

(cherry picked from commit 407f5f9baea5591f148974240a87dfb43e5efef3)

Gbp-Pq: Name 0025-gpg-Don-t-assume-that-strtoul-interprets-as-0.patch
g10/tofu.c