prefork-interp: increase check interval quite a bit

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: fix namespace (NULL was being strange)

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: fixes and tests

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: fixes and tests

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: fixes and tests

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: fixes and tests

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: fixes and tests

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: fix non-script-arg case

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip testing

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip testing

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: enable build

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: gitignore

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: Add missing symbols

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: Fix an uninitialised variable

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip compile

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip use stdio

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip compile

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip compile

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip compile

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

common.h: Add some more decls (useful for prefork-interp)

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip args

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork: Insist on script (separately) with combined options

cgi-fcgi-interp always insists on this anyway, but prefork-interp
won't and ought to check this.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork: Provide PREFORK_CMDINFOS

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork: Make socket finding etc. stuff static

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork: Move garbage handling back cgi-fcgi-interp

prefork-interp wants to do this differently.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork: Allow script not to be set

Do the check in cgi-fcgi-interp.  prefork-interp is going to want this
to be optional.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork: Have process_opts not return script, just set a global

This is going to be more convenient.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork: Have process_opts update argv and not take argc

This will let us do further option processing after process_opts.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork: Remove a wrong check

This is just not true at all.  Perhaps it was to check for malloc
failure?  Anyway, split_argv comes from split_argv and shbang_opts
never sets it to zero.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: define what our invocation looks like

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

cgi-fcgi-interp: Write down the usages

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork: Move STAGE2_VAR back to cgi-fcgi-interp

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

cgi-fcgi-interp: prefork: Make name variable

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: temporary symlink for testing

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork: split off lock_path etc.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

prefork-interp: wip

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

cprogs: add FILLZERO

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Break much of cgi-fcgi-interp.c out into prefork.[ch]

We are going to want to reuse most of this for prefork-interp.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

cgi-fcgi-interp: Drop a spurious duplicate comment

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Merge remote-tracking branch 'dgit/dgit/sid'

Incorporate NMU

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

really: Fix a preprocessor #endif

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: Fix "insufficiently dense" message

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: provide --rename-only

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: tidy docs and exit status

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: clean up old .rm

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: break out do_rm and rename to .rm

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: add missing $ to filename regexp

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: report and implement oldest first

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: compensate for insufficient density

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: break out $use->()

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: Set $|=1 to clarify output order

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: include #0 too

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Revert "expire-iso8601: Use date(1)"

It's not faster.

With DateTime::Format::Strptime, whole program runtime on my
test case:
  real    0m1.371s
  user    0m1.254s
  sys     0m0.117s

With date(1):
  real    0m5.408s
  user    0m1.834s
  sys     0m3.683s

This reverts commit 2d3da03e893d0c59e236224f049215fab8e81e8e.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: Use date(1)

-davenant:~> time perl -e 'use DateTime::Format::Strptime;'

real    0m1.269s
user    0m1.175s
sys     0m0.093s

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: Fix a dependency

Actually this is huge so make it Recommends.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-iso8601: Fix a dependency

This is just a perl lib so ask for it.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

changelog: document expire-8601 changes

expire-iso8601: Replace with new implementation

This fixes the design problem and is also much more maintainable and
comprehensible.

Closes: #862897
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-8601: new version fixes

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-8601: new version seems good now

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-8601: wip new version, err on other side

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-8601: wip new version, sort of works, need adj

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-8601: wip new version

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-8601: wip new version

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-8601: wip new version

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-8601: wip new version

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-8601: wip new version

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

expire-8601: wip new version

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

packaging: bump debhelper compat to 13

Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>

changelog: document changes and finalise 6.1.2

Ready for upload, which will involve wearing also my other hat.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

git-cache-proxy: Do not update timestamp due to housekeeping gc

Otherwise gc will always reset the timestamp and nothing will be
cleaned up.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

changelog: Start ~citrix3~

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

git-cache-proxy: Tolerate failure to write gc stamp

This can happen if the directory no longer exists.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

git-cache-proxy: Recheck gc timestamp after taking lock

Otherwise we can repeatedly gc the same thing.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

git-cache-proxy: gc: Break out $gccheck

No functional change.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

changelog: Document changes and finalise 6.1.2~citrix2~

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

git-cache-proxy: Use open-coded fork/exec for git gc

This allows us to handle ENOENT from chdir specially.  We want to
tolerate this, because it can happen if the previous lockholder
cleaned it all up.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

git-cache-proxy: Abandon fetch attempt if client disconnects

The git client sends the command and then waits for our response.  We
can tell if it has disconnected, because our stdin (the socket) will
be readable.

This is a good idea because otherwise if we have clients with their
own (formal or informal) timeouts, we can build up a backlog of
queued useless fetch attempts.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

git-cache-proxy: Move $SIG{ALRM} setting to global

This is actually used in multiple places.  It should be set globally.
No overall functional change with the current code.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

changelog: Start 6.1.2~citrix2~

Use 2~ since there was a 1~ floating about on mariner...

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

Merge remote-tracking branch 'dgit/dgit/sid'

Signed-off-by: Ian Jackson <ian.jackson@citrix.com>

changelog: Bump version to 6.1.1 and finalise

I found some 6.1.1~citrix1~ on mariner, so go higher than that.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

changelog: Document Citrix changes

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

Merge remote-tracking branch 'mariner/master'

Signed-off-by: Ian Jackson <ian.jackson@citrix.com>

git-cache-proxy: Document some options in the head comment

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

git-cache-proxy: Periodically run `git gc --quiet'

git has a feature which is supposed to automatically run git gc.

But if your repository accumulates enough loose objects, then this
occurs:

 $ git gc --auto
 Auto packing the repository in background for optimum performance.
 See "git help gc" for manual housekeeping.
 error: The last gc run reported the following. Please correct the root cause
 and remove gc.log.
 Automatic cleanup will not be performed until the file is removed.

 warning: There are too many unreachable loose objects; run 'git prune' to remove them.

Removing $GIT_DIR/gc.log generally simply causes git gc --auto to
print, again, the message:

 warning: There are too many unreachable loose objects; run 'git prune' to remove them.

Ie, a repository can get into a state where it needs gc so badly that
git will not gc it automatically.  This is, of course, mad.  It seems
to have been a misguided attempt at a safety catch.  Unfortunately
there does not even appear to be a configuration knob to set this `too
many' limit to infinity.

Work around this problem by running `git gc --quiet' (every 10 days,
by default).  This is not ideal because it runs even if we haven't
updated the tree, but we would rather do it out of housekeeping rather
than in the middle of fetch/clone.

`git gc' without --auto does not refuse to prune the objects that need
pruning, and fixes the repository.

We leave the gc.auto config option enabled since I think it is largely
harmless, and disabling it would be extra work.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

git-cache-proxy: Refactor to prepare for 2nd kind of housekeeping

Generalise the housekeeping action code.
Introduce new variables $mode_what, $mode_locknb, and $mode_action.
Move the actual cleanup functionality into the $mode_action value.

No overall functional change.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

changelog: start ~citrix2

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

changelog: finalise 6.0.5~citrix1

fishdescriptor: Use Python "errno" module

Use Python "errno" module, not "os.errno" (which is not in modern
python3 apparently).

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

changelog: Start 6.0.5~citrix1

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

git-branchmove: rewrite in perl

Closes: #914398, #914399
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>

changelog: finalise 6.0.5~iwj1

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>