From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Mon, 28 Jul 2014 14:10:49 +0000 (+0100)
Subject: git-cache-proxy: housekeeping: More correctly handle errors from remove_tree
X-Git-Tag: debian/4.3.1~7
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?p=chiark-utils.git;a=commitdiff_plain;h=d4682414225149452aa98f82ddd995c0f1ebdb9c

git-cache-proxy: housekeeping: More correctly handle errors from remove_tree
---

diff --git a/debian/changelog b/debian/changelog
index e47c527..4118bc8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,7 @@ chiark-utils (4.3.1) unstable; urgency=low
 
   Bugfixes:
   * expire-iso8601: Fix mistake in usage message.
+  * git-cache-proxy: Fix various bugs in housekeeping.
 
  --
 
diff --git a/scripts/git-cache-proxy b/scripts/git-cache-proxy
index eafbb8a..334f509 100755
--- a/scripts/git-cache-proxy
+++ b/scripts/git-cache-proxy
@@ -415,7 +415,8 @@ sub housekeeping () {
 		logm 'warning', "housekeeping: $dir: problems with".
 		    " deletion prevent cleanup:";
 		foreach my $err (@$errs) {
-		    logm 'info', "problem deleting: $err->[0]: $err->[1]";
+		    my ($file, $message) = %$err;
+		    logm 'info', "problem deleting: $file: $message";
 		}
 	    }
 	}