X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?p=chiark-utils.git;a=blobdiff_plain;f=scripts%2Fgit-cache-proxy;h=647f6b60d3c152dae98a16240f0bf9181dcee86b;hp=d12bdb3a3c1c7de8c30d9a14a46883a7c52b0942;hb=a14cb06ac8fff27e407a39993b2b20f9a7109f7c;hpb=c46b09429cb3309bfb32fd57c294c9dc4d5cf6e9

diff --git a/scripts/git-cache-proxy b/scripts/git-cache-proxy
index d12bdb3..647f6b6 100755
--- a/scripts/git-cache-proxy
+++ b/scripts/git-cache-proxy
@@ -2,6 +2,12 @@
 #
 # git caching proxy
 
+# Suitable only for exposing to semi-trusted clients: clients are not
+# supposed to be able to take over the server.  However, clients can
+# probably deny service to each other because the current
+# implementation is not very good at handling various out-of-course
+# situations (notably, clients which are too slow).
+
 # usage: run it on some port, and then clone or fetch
 #  "git://<realhost>:<realport>/<real-git-url>[ <options>]"
 # where <real-git-url> is http://<host>/... or git://<host>/...
@@ -23,7 +29,8 @@
 
 # git-cache-proxy
 # Copyright 2010 Tony Finch
-# Copyright 2013 Ian Jackson
+# Copyright 2013,2014 Ian Jackson
+# Copyright 2017 Citrix
 # 
 # git-cache-proxy is free software; you can redistribute it and/or
 # modify them under the terms of the GNU General Public License as
@@ -354,6 +361,7 @@ sub clonefetch () {
 		servinfo "fetch/clone failed: $fetchfail";
 	    }
 	}
+        alarm 0;
 
 	if (!$exists) {
 	    rename $tmpd, $gitd or fail "rename fresh $tmpd to $gitd: $!";
@@ -399,21 +407,28 @@ sub housekeeping () {
 	    next;
 	}
 	logm 'info', "housekeeping: subdirs $subdir: cleaning";
-	my $ok = 1;
-	foreach my $suffix (qw(tmp git)) {
-	    my $dir = "${subdir}\\.$suffix";
-	    my $errs;
-	    remove_tree($dir, { safe=>1, error=>\$errs });
-	    if (stat $dir) {
-		$ok = 0;
-		logm 'warning', "housekeeping: $dir: problems with".
-		    "deletion prevent cleanup:";
-		foreach my $err (@$errs) {
-		    logm 'info', "problem deleting: $err->[0]: $err->[1]";
+	eval {
+	    foreach my $suffix (qw(tmp git)) {
+		my $dir = "${subdir}\\.$suffix";
+		my $tdir = "${subdir}\\.tmp";
+		if ($dir ne $tdir) {
+		    if (!rename $dir,$tdir) {
+			next if $! == ENOENT;
+			die "$dir: cannot rename to $tdir: $!\n";
+		    }
+		}
+		system qw(rm -rf --), $tdir;
+		if (stat $tdir) {
+		    die "$dir: problem deleting file(s), rm exited $?\n";
+		} elsif ($! != ENOENT) {
+		    die "$tdir: cannot stat after deletion: $!\n";
 		}
 	    }
-	}
-	if ($ok) {
+	};
+	if (length $@) {
+	    chomp $@;
+	    logm 'warning', "housekeeping: $subdir: cleanup prevented: $@";
+	} else {
 	    unlink $lock or hkfail "remove $lock: $!";
 	}
     }
@@ -443,8 +458,10 @@ sub housekeepingcheck ($$) {
     }
     if ($dofork) {
 	my $child = fork;
-	defined $child or hkfail "fork: $!";
+	defined $child or fail "fork: $!";
 	if (!$child) {
+	    open STDERR, "|logger -p daemon.warning -t '$us(housekeeping)'"
+		or die "fork: logger $!";
 	    housekeeping();
 	    exit 0;
 	}