X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?p=chiark-tcl.git;a=blobdiff_plain;f=cdb%2Fwriteable.c;h=fca54a8ea5e5d947606aa4d25573643404684b95;hp=4230e62d403e1f788a640bfe8caacd2605535c84;hb=ca8b96bf81245f21fe3906c71dc2994bfc5e516f;hpb=ca258c32ca9f43fa6ddb5642860f310c8b506f2c

diff --git a/cdb/writeable.c b/cdb/writeable.c
index 4230e62..fca54a8 100644
--- a/cdb/writeable.c
+++ b/cdb/writeable.c
@@ -1,7 +1,27 @@
-/**/
+/*
+ * cdb, cdb-wr - Tcl bindings for tinycdb and a journalling write extension
+ * Copyright 2006-2012 Ian Jackson
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301, USA.
+ */
 
 #include "chiark_tcl_cdb.h"
 
+#define KEYLEN_MAX (INT_MAX/2)
+
 #define ftello ftell
 #define fseeko fseek
 
@@ -15,10 +35,6 @@ static void maybe_close(int fd) {
   if (fd>=0) close(fd);
 }
 
-#define PE(m) do{						\
-    rc= cht_posixerr(ip, errno, "failed to " m); goto x_rc;	\
-  }while(0)
-
 /*==================== Subsystems and subtypes ====================*/
 
 /*---------- Pathbuf ----------*/
@@ -27,14 +43,14 @@ typedef struct Pathbuf {
   char *buf, *sfx;
 } Pathbuf;
 
-#define MAX_SUFFIX 4
+#define MAX_SUFFIX 5
 
 static void pathbuf_init(Pathbuf *pb, const char *pathb) {
-  int l= strlen(pathb);
-  pb->buf= TALLOC(l + 4);
+  size_t l= strlen(pathb);
+  assert(l < INT_MAX);
+  pb->buf= TALLOC(l + MAX_SUFFIX + 1);
   memcpy(pb->buf, pathb, l);
   pb->sfx= pb->buf + l;
-  *pb->sfx++= '.';
 }
 static const char *pathbuf_sfx(Pathbuf *pb, const char *suffix) {
   assert(strlen(suffix) <= MAX_SUFFIX);
@@ -63,13 +79,11 @@ static HashValue *htv_prep(int len) {
   HashValue *hd;
   hd= TALLOC((hd->data - (Byte*)hd) + len);
   hd->len= len;
+  return hd;
 }  
 static Byte *htv_fillptr(HashValue *hd) {
   return hd->data;
 }
-static void htv_fill(HashValue *hd, const Byte *data) {
-  memcpy(hd->data, data, hd->len);
-}
 
 static void ht_setup(HashTable *ht) {
   Tcl_InitHashTable(&ht->t, TCL_STRING_KEYS);
@@ -94,6 +108,15 @@ static void ht_maybeupdate(HashTable *ht, const char *key,
   Tcl_SetHashValue(he, val_eat);
 }
 
+static const HashValue *ht_lookup(HashTable *ht, const char *key) {
+  Tcl_HashEntry *he;
+  
+  he= Tcl_FindHashEntry(&ht->t, key);
+  if (!he) return 0;
+  
+  return Tcl_GetHashValue(he);
+}
+
 static int ht_forall(HashTable *ht,
 		     int (*fn)(const char *key, HashValue *val,
 			       struct ht_forall_ctx *ctx),
@@ -140,20 +163,24 @@ typedef struct Rw {
   int ix, autocompact;
   int cdb_fd, lock_fd;
   struct cdb cdb; /* valid iff cdb_fd >= 0 */
-  off_t cdb_bytes; /* valid iff cdb_fd >= 0 */
-  FILE *logfile;
+  FILE *logfile; /* may be 0; if so, is broken */
   HashTable logincore;
   Pathbuf pbsome, pbother;
   off_t mainsz;
   ScriptToInvoke on_info, on_lexminval;
 } Rw;
 
+static void rw_cdb_close(Tcl_Interp *ip, Rw *rw) {
+  if (rw->cdb_fd >= 0) cdb_free(&rw->cdb);
+  maybe_close(rw->cdb_fd);
+}
+
 static int rw_close(Tcl_Interp *ip, Rw *rw) {
   int rc, r;
 
   rc= TCL_OK;
   ht_destroy(&rw->logincore);
-  maybe_close(rw->cdb_fd);
+  rw_cdb_close(ip,rw);
   maybe_close(rw->lock_fd);
 
   if (rw->logfile) {
@@ -163,11 +190,13 @@ static int rw_close(Tcl_Interp *ip, Rw *rw) {
   }
 
   pathbuf_free(&rw->pbsome); pathbuf_free(&rw->pbother);
-  TFREE(rw);
   return rc;
 }
 
-static void destroy_cdbrw_idtabcb(Tcl_Interp *ip, void *rw) { rw_close(0,rw); }
+static void destroy_cdbrw_idtabcb(Tcl_Interp *ip, void *rw_v) {
+  rw_close(0,rw_v);
+  TFREE(rw_v);
+}
 const IdDataSpec cdbtcl_rwdatabases= {
   "cdb-rwdb", "cdb-openrwdatabases-table", destroy_cdbrw_idtabcb
 };
@@ -188,7 +217,7 @@ static int acquire_lock(Tcl_Interp *ip, Pathbuf *pb, int *lockfd_r) {
   /* Remove r where umask would remove w;
    * eg umask intending 0664 here gives 0660 */
   
-  *lockfd_r= open(pathbuf_sfx(pb,".lock"), O_RDONLY|O_CREAT, lockmode);
+  *lockfd_r= open(pathbuf_sfx(pb,".lock"), O_RDWR|O_CREAT, lockmode);
   if (*lockfd_r < 0)
     return cht_posixerr(ip, errno, "could not open/create lockfile");
 
@@ -209,7 +238,7 @@ static int acquire_lock(Tcl_Interp *ip, Pathbuf *pb, int *lockfd_r) {
   return TCL_OK;
 }
 
-/*---------- Log reading ----------*/
+/*---------- Log reading and writing ----------*/
 
 static int readlognum(FILE *f, int delim, int *num_r) {
   int c;
@@ -228,7 +257,7 @@ static int readlognum(FILE *f, int delim, int *num_r) {
   *p= 0;
 
   errno=0; ul= strtoul(numbuf, &ep, 10);
-  if (*ep || errno || ul >= INT_MAX/2) return -2;
+  if (*ep || errno || ul >= KEYLEN_MAX) return -2;
   *num_r= ul;
   return 0;
 }
@@ -252,7 +281,7 @@ static int readstorelogrecord(FILE *f, HashTable *ht,
   int c, rc, r;
 
   c= getc(f);
-  if (c==EOF) { if (feof(f)) return -1; return -2; }
+  if (c==EOF) { return feof(f) ? -1 : -2; }
   if (c=='\n') return -3;
   if (c!='+') return -2;
 
@@ -273,6 +302,8 @@ static int readstorelogrecord(FILE *f, HashTable *ht,
   r= fread(htv_fillptr(val), 1,vallen, f);
   if (r!=vallen) goto x2_free_keyval;
 
+  c= getc(f);  if (c!='\n') goto x2_free_keyval;
+
   rc= omitfn ? omitfn(val, ctx) : TCL_OK;
   if (rc) { assert(rc>0); TFREE(val); }
   else updatefn(ht, key, val);
@@ -286,36 +317,64 @@ static int readstorelogrecord(FILE *f, HashTable *ht,
   return -2;
 }
 
+static int writerecord(FILE *f, const char *key, const HashValue *val) {
+  int r;
+
+  r= fprintf(f, "+%d,%d:%s->", (int)strlen(key), val->len, key);
+  if (r<0) return -1;
+  
+  r= fwrite(val->data, 1, val->len, f);
+  if (r != val->len) return -1;
+
+  r= putc('\n', f);
+  if (r==EOF) return -1;
+
+  return 0;
+}
+
 /*---------- Creating ----------*/
 
 int cht_do_cdbwr_create_empty(ClientData cd, Tcl_Interp *ip,
 			      const char *pathb) {
-  static const char *const toremoves[]= {
-    ".main", ".cdb", ".log", ".tmp", 0
-  };
+  static const char *const toremoves[]= { ".cdb", ".jrn", ".tmp", 0 };
 
-  Pathbuf pb;
-  int lock_fd=-1, fd=-1, rc, r;
+  Pathbuf pb, pbmain;
+  int lock_fd=-1, rc, r;
+  FILE *f= 0;
   const char *const *toremove;
+  struct stat stab;
 
   pathbuf_init(&pb, pathb);
+  pathbuf_init(&pbmain, pathb);
+
   rc= acquire_lock(ip, &pb, &lock_fd);  if (rc) goto x_rc;
-  
-  fd= open(pathbuf_sfx(&pb, ".main"), O_RDWR|O_CREAT|O_EXCL, 0666);
-  if (fd <= 0) PE("create new database file");
+
+  r= lstat(pathbuf_sfx(&pbmain, ".main"), &stab);
+  if (!r) { rc= cht_staticerr(ip, "database already exists during creation",
+			      "CDB ALREADY-EXISTS");  goto x_rc; }
+  if (errno != ENOENT) PE("check for existing database .main during creation");
 
   for (toremove=toremoves; *toremove; toremove++) {
-    r= remove(*toremove);
+    r= remove(pathbuf_sfx(&pb, *toremove));
     if (r && errno != ENOENT)
       PE("delete possible spurious file during creation");
   }
   
+  f= fopen(pathbuf_sfx(&pb, ".tmp"), "w");
+  if (!f) PE("create new database .tmp");  
+  r= putc('\n', f);  if (r==EOF) PE("write sentinel to new database .tmp");
+  r= fclose(f);  f=0;  if (r) PE("close new database .tmp during creation");
+
+  r= rename(pb.buf, pbmain.buf);
+  if (r) PE("install new database .tmp as .main (finalising creation)");
+  
   rc= TCL_OK;
 
  x_rc:
-  maybe_close(fd);
+  if (f) fclose(f);
   maybe_close(lock_fd);
   pathbuf_free(&pb);
+  pathbuf_free(&pbmain);
   return rc;
 }
 
@@ -358,6 +417,19 @@ static int infocb(Tcl_Interp *ip, Rw *rw, const char *arg1,
   
 /*---------- Opening ----------*/
 
+static int cdbinit(Tcl_Interp *ip, Rw *rw) {
+  /* On entry, cdb_fd >=0 but cdb is _undefined_
+   * On exit, either cdb_fd<0 or cdb is initialised */
+  int r, rc;
+  
+  r= cdb_init(&rw->cdb, rw->cdb_fd);
+  if (r) {
+    rc= cht_posixerr(ip, errno, "failed to initialise cdb reader");
+    close(rw->cdb_fd);  rw->cdb_fd= -1;  return rc;
+  }
+  return TCL_OK;
+}
+
 int cht_do_cdbwr_open(ClientData cd, Tcl_Interp *ip, const char *pathb,
 		      Tcl_Obj *on_info, Tcl_Obj *on_lexminval,
 		      void **result) {
@@ -368,6 +440,7 @@ int cht_do_cdbwr_open(ClientData cd, Tcl_Interp *ip, const char *pathb,
   off_t logrecstart, logjunkpos;
 
   rw= TALLOC(sizeof(*rw));
+  rw->ix= -1;
   ht_setup(&rw->logincore);
   cht_scriptinv_init(&rw->on_info);
   cht_scriptinv_init(&rw->on_lexminval);
@@ -376,15 +449,14 @@ int cht_do_cdbwr_open(ClientData cd, Tcl_Interp *ip, const char *pathb,
   pathbuf_init(&rw->pbother, pathb);
   rw->autocompact= 1;
 
-  if (on_lexminval) {
-    rc= cht_scriptinv_set(&rw->on_lexminval, ip, on_lexminval, 0);
-    if (rc) goto x_rc;
-  } else {
-    rw->on_lexminval.llength= 0;
-  }
+  rc= cht_scriptinv_set(&rw->on_info, ip, on_info, 0);
+  if (rc) goto x_rc;
+
+  rc= cht_scriptinv_set(&rw->on_lexminval, ip, on_lexminval, 0);
+  if (rc) goto x_rc;
 
   mainfd= open(pathbuf_sfx(&rw->pbsome,".main"), O_RDONLY);
-  if (mainfd<0) PE("open exist3ing database file .main");
+  if (mainfd<0) PE("open existing database file .main");
   rc= acquire_lock(ip, &rw->pbsome, &rw->lock_fd);  if (rc) goto x_rc;
 
   r= fstat(mainfd, &stab);  if (r) PE("fstat .main");
@@ -392,14 +464,10 @@ int cht_do_cdbwr_open(ClientData cd, Tcl_Interp *ip, const char *pathb,
 
   rw->cdb_fd= open(pathbuf_sfx(&rw->pbsome,".cdb"), O_RDONLY);
   if (rw->cdb_fd >=0) {
-    r= cdb_init(&rw->cdb, rw->cdb_fd);
-    if (r) {
-      rc= cht_posixerr(ip, errno, "failed to initialise cdb reader");
-      close(rw->cdb_fd);  rw->cdb_fd= -1;  goto x_rc;
-    }
+    rc= cdbinit(ip, rw);  if (rc) goto x_rc;
   } else if (errno == ENOENT) {
-    if (rw->mainsz) {
-      rc= cht_staticerr(ip, ".cdb does not exist but .main is nonempty -"
+    if (rw->mainsz > 1) {
+      rc= cht_staticerr(ip, ".cdb does not exist but .main is >1byte -"
 			" .cdb must have been accidentally deleted!",
 			"CDB CDBMISSING");
       goto x_rc;
@@ -409,24 +477,24 @@ int cht_do_cdbwr_open(ClientData cd, Tcl_Interp *ip, const char *pathb,
     PE("open .cdb");
   }
 
-  rw->logfile= fopen(pathbuf_sfx(&rw->pbsome,".log"), "r+");
+  rw->logfile= fopen(pathbuf_sfx(&rw->pbsome,".jrn"), "r+");
   if (!rw->logfile) {
-    if (errno != ENOENT) PE("failed to open .log during open");
+    if (errno != ENOENT) PE("failed to open .jrn during open");
     rw->logfile= fopen(rw->pbsome.buf, "w");
-    if (!rw->logfile) PE("create .log during (clean) open");
+    if (!rw->logfile) PE("create .jrn during (clean) open");
   } else { /* rw->logfile */
     r= fstat(fileno(rw->logfile), &stab);
-    if (r==-1) PE("fstat .log during open");
+    if (r==-1) PE("fstat .jrn during open");
     rc= infocb(ip, rw, "open-dirty-start", "log=%luby",
 	       (unsigned long)stab.st_size);
     if (rc) goto x_rc;
 
     for (;;) {
       logrecstart= ftello(rw->logfile);
-      if (logrecstart < 0) PE("ftello .log during (dirty) open");
+      if (logrecstart < 0) PE("ftello .jrn during (dirty) open");
       r= readstorelogrecord(rw->logfile, &rw->logincore, 0,0, ht_update);
       if (ferror(rw->logfile)) {
-	rc= cht_posixerr(ip, errno, "error reading .log during (dirty) open");
+	rc= cht_posixerr(ip, errno, "error reading .jrn during (dirty) open");
 	goto x_rc;
       }
       if (r==-1) {
@@ -434,7 +502,7 @@ int cht_do_cdbwr_open(ClientData cd, Tcl_Interp *ip, const char *pathb,
       } else if (r==-2 || r==-3) {
 	char buf[100];
 	logjunkpos= ftello(rw->logfile);
-	if(logjunkpos<0) PE("ftello .log during report of junk in dirty open");
+	if(logjunkpos<0) PE("ftello .jrn during report of junk in dirty open");
 
 	snprintf(buf,sizeof(buf), "CDB SYNTAX LOG %lu %lu",
 		 (unsigned long)logjunkpos, (unsigned long)logrecstart);
@@ -443,7 +511,7 @@ int cht_do_cdbwr_open(ClientData cd, Tcl_Interp *ip, const char *pathb,
 	  Tcl_SetObjErrorCode(ip, Tcl_NewStringObj(buf,-1));
 	  snprintf(buf,sizeof(buf),"%lu",(unsigned long)logjunkpos);
 	  Tcl_ResetResult(ip);
-	  Tcl_AppendResult(ip, "syntax error (junk) in .log during"
+	  Tcl_AppendResult(ip, "syntax error (junk) in .jrn during"
 			   " (dirty) open, at file position ", buf, (char*)0);
 	  rc= TCL_ERROR;
 	  goto x_rc;
@@ -453,10 +521,10 @@ int cht_do_cdbwr_open(ClientData cd, Tcl_Interp *ip, const char *pathb,
 	if (rc) goto x_rc;
 
 	r= fseeko(rw->logfile, logrecstart, SEEK_SET);
-	if (r) PE("failed to fseeko .log before junk during dirty open");
+	if (r) PE("failed to fseeko .jrn before junk during dirty open");
 
 	r= ftruncate(fileno(rw->logfile), logrecstart);
-	if (r) PE("ftruncate .log to chop junk during dirty open");
+	if (r) PE("ftruncate .jrn to chop junk during dirty open");
       } else {
 	assert(!r);
       }
@@ -470,25 +538,32 @@ int cht_do_cdbwr_open(ClientData cd, Tcl_Interp *ip, const char *pathb,
 
  x_rc:
   rw_close(0,rw);
+  TFREE(rw);
   maybe_close(mainfd);
   return rc;
 }
 
-/*==================== COMPACTING ====================*/
+int cht_do_cdbwr_open_okjunk(ClientData cd, Tcl_Interp *ip, const char *pathb,
+		      Tcl_Obj *on_info, Tcl_Obj *on_lexminval,
+		      void **result) {
+  return cht_do_cdbwr_open(cd,ip,pathb,on_info,on_lexminval,result);
+}
+
+/*==================== COMPACTION ====================*/
 
 struct ht_forall_ctx {
   struct cdb_make cdbm;
   FILE *mainfile;
-  int lexminvall;
   long *reccount;
-  const char *lexminval;
+  int lexminvall;
+  const char *lexminval; /* may be invalid if lexminvall <= 0 */
 };
 
 /*---------- helper functions ----------*/
 
 static int expiredp(const HashValue *val, struct ht_forall_ctx *a) {
   int r, l;
-  if (!val->len) return 0;
+  if (!val->len || a->lexminvall<=0) return 0;
   l= val->len < a->lexminvall ? val->len : a->lexminvall;
   r= memcmp(val->data, a->lexminval, l);
   if (r>0) return 0;
@@ -512,26 +587,17 @@ static int addto_cdb(const char *key, HashValue *val,
 
 static int addto_main(const char *key, HashValue *val,
 		      struct ht_forall_ctx *a) {
-  int r;
-
   (*a->reccount)++;
-  
-  r= fprintf(a->mainfile, "+%d,%d:%s->", strlen(key), val->len, key);
-  if (r<0) return -1;
-  
-  r= fwrite(val->data, 1, val->len, a->mainfile);
-  if (r != val->len) return -1;
-
-  return 0;
+  return writerecord(a->mainfile, key, val);
 }
 
 /*---------- compact main entrypoint ----------*/
 
-static int compact_core(Tcl_Interp *ip, Rw *rw, unsigned long logsize,
+static int compact_core(Tcl_Interp *ip, Rw *rw, unsigned long logsz,
 			long *reccount_r) {
   /* creates new .cdb and .main
    * closes logfile
-   * leaves .log with old data
+   * leaves .jrn with old data
    * leaves cdb fd open onto old db
    * leaves logincore full of crap
    */
@@ -549,15 +615,15 @@ static int compact_core(Tcl_Interp *ip, Rw *rw, unsigned long logsize,
   a.reccount= reccount_r;
 
   r= fclose(rw->logfile);
+  rw->logfile= 0;
   if (r) { rc= cht_posixerr(ip, errno, "probable data loss!  failed to fclose"
 			    " logfile during compact");  goto x_rc; }
-  rw->logfile= 0;
   
   rc= infocb(ip, rw, "compact-start", "log=%luby main=%luby",
-	     logsize, (unsigned long)rw->mainsz);
+	     logsz, (unsigned long)rw->mainsz);
   if (rc) goto x_rc;
 
-  if (rw->on_lexminval.llength) {
+  if (cht_scriptinv_interp(&rw->on_lexminval)) {
     rc= cht_scriptinv_invoke_fg(&rw->on_lexminval, 0,0);
     if (rc) goto x_rc;
 
@@ -571,7 +637,7 @@ static int compact_core(Tcl_Interp *ip, Rw *rw, unsigned long logsize,
     rc= ht_forall(&rw->logincore, delete_ifexpired, &a);
 
   } else {
-    a.lexminval= "";
+    a.lexminvall= 0;
   }
 
   /* merge unsuperseded records from main into hash table */
@@ -584,19 +650,23 @@ static int compact_core(Tcl_Interp *ip, Rw *rw, unsigned long logsize,
 			  expiredp, &a,
 			  ht_maybeupdate);
     if (ferror(a.mainfile)) { rc= cht_posixerr(ip, errno, "error reading"
-                         " .main during compact"); goto x_rc;
-    }
+                         " .main during compact"); goto x_rc; }
     if (r==-3) {
       break;
     } else if (r==-1 || r==-2) {
       errpos= ftello(a.mainfile);
       if (errpos<0) PE("ftello .main during report of syntax error");
-      snprintf(buf,sizeof(buf), "CDB SYNTAX MAIN %lu", (unsigned long)errpos);
+      snprintf(buf,sizeof(buf), "CDB %s MAIN %lu",
+	       r==-1 ? "TRUNCATED" : "SYNTAX", (unsigned long)errpos);
       Tcl_SetObjErrorCode(ip, Tcl_NewStringObj(buf,-1));
       snprintf(buf,sizeof(buf), "%lu", (unsigned long)errpos);
       Tcl_ResetResult(ip);
-      Tcl_AppendResult(ip, "syntax error in .main during"
-		       " compact, at file position ", buf, (char*)0);
+      Tcl_AppendResult(ip,
+		       r==-1 ? "unexpected eof (truncated file)"
+		       " in .main during compact, at file position "
+		       : "syntax error"
+		       " in .main during compact, at file position ",
+		       buf, (char*)0);
       rc= TCL_ERROR;
       goto x_rc;
     } else {
@@ -635,8 +705,11 @@ static int compact_core(Tcl_Interp *ip, Rw *rw, unsigned long logsize,
   if (!a.mainfile) PE("create .tmp for new main during compact");
 
   r= ht_forall(&rw->logincore, addto_main, &a);
-  if (r) { rc= cht_posixerr(ip, r, "error writing to new .main"
+  if (r) { rc= cht_posixerr(ip, errno, "error writing to new .main"
 			    " during compact");  goto x_rc; }
+
+  r= putc('\n', a.mainfile);
+  if (r==EOF) PE("write trailing \n to main during compact");
   
   r= fflush(a.mainfile);  if (r) PE("fflush new main during compact");
   r= fdatasync(fileno(a.mainfile));
@@ -655,16 +728,18 @@ static int compact_core(Tcl_Interp *ip, Rw *rw, unsigned long logsize,
 
   /* done! */
   
-  rc= infocb(ip, rw, "compact-end", "log=%luby main=%luby nrecs=%l",
-	     logsize, (unsigned long)rw->mainsz, *a.reccount);
+  rc= infocb(ip, rw, "compact-end", "main=%luby nrecs=%ld",
+	     (unsigned long)rw->mainsz, *a.reccount);
   if (rc) goto x_rc;
 
-  rc= TCL_OK;
+  return rc;
+
 x_rc:
   if (a.mainfile) fclose(a.mainfile);
   if (cdbmaking) cdb_make_finish(&a.cdbm);
   maybe_close(cdbfd);
   remove(pathbuf_sfx(&rw->pbsome,".tmp")); /* for tidyness */
+  return rc;
 }
 
 /*---------- Closing ----------*/
@@ -678,8 +753,8 @@ static int compact_forclose(Tcl_Interp *ip, Rw *rw, long *reccount_r) {
 
   rc= compact_core(ip, rw, logsz, reccount_r);  if (rc) goto x_rc;
 
-  r= remove(pathbuf_sfx(&rw->pbsome,".log"));
-  if (r) PE("remove .log (during tidy close)");
+  r= remove(pathbuf_sfx(&rw->pbsome,".jrn"));
+  if (r) PE("remove .jrn (during tidy close)");
 
   return TCL_OK;
 
@@ -696,7 +771,7 @@ int cht_do_cdbwr_close(ClientData cd, Tcl_Interp *ip, void *rw_v) {
   else rc= TCL_OK;
 
   if (!rc) {
-    if (!rw->logfile) {
+    if (rw->logfile) {
       logsz= ftello(rw->logfile);
       if (logsz < 0)
 	rc= cht_posixerr(ip, errno, "ftell logfile during close info");
@@ -704,7 +779,8 @@ int cht_do_cdbwr_close(ClientData cd, Tcl_Interp *ip, void *rw_v) {
 	rc= infocb(ip, rw, "close", "main=%luby log=%luby",
 		   rw->mainsz, logsz);
     } else if (reccount>=0) {
-      rc= infocb(ip, rw, "close", "main=%luby nrecs=%l", rw->mainsz, reccount);
+      rc= infocb(ip, rw, "close", "main=%luby nrecs=%ld",
+		 rw->mainsz, reccount);
     } else {
       rc= infocb(ip, rw, "close", "main=%luby", rw->mainsz);
     }
@@ -713,7 +789,199 @@ int cht_do_cdbwr_close(ClientData cd, Tcl_Interp *ip, void *rw_v) {
   if (rc_close) rc= rc_close;
   
   cht_tabledataid_disposing(ip, rw_v, &cdbtcl_rwdatabases);
+  TFREE(rw);
+  return rc;
+}
+
+/*---------- Other compaction-related entrypoints ----------*/
+
+static int compact_keepopen(Tcl_Interp *ip, Rw *rw, int force) {
+  off_t logsz;
+  long reccount;
+  int rc, r;
+
+  logsz= ftello(rw->logfile);
+  if (logsz < 0) return cht_posixerr(ip, errno, "ftell .jrn"
+				       " during compact check or force");
+
+  if (!force && logsz < rw->mainsz / 3 + 1000) return TCL_OK;
+  /* Test case:                    ^^^ testing best value for this
+   *   main=9690434by nrecs=122803  read all in one go
+   *  no autocompact, :    6.96user 0.68system 0:08.93elapsed
+   *  auto, mulitplier 2:  7.10user 0.79system 0:09.54elapsed
+   *  auto, unity:         7.80user 0.98system 0:11.84elapsed
+   *  auto, divisor  2:    8.23user 1.05system 0:13.30elapsed
+   *  auto, divisor  3:    8.55user 1.12system 0:12.88elapsed
+   *  auto, divisor  5:    9.95user 1.43system 0:15.72elapsed
+   */
+
+  rc= compact_core(ip, rw, logsz, &reccount);  if (rc) goto x_rc;
+
+  rw_cdb_close(ip,rw);
+  ht_destroy(&rw->logincore);
+  ht_setup(&rw->logincore);
+
+  rw->cdb_fd= open(pathbuf_sfx(&rw->pbsome,".cdb"), O_RDONLY);
+  if (rw->cdb_fd < 0) PE("reopen .cdb after compact");
+
+  rc= cdbinit(ip, rw);  if (rc) goto x_rc;
+
+  rw->logfile= fopen(pathbuf_sfx(&rw->pbsome,".jrn"), "w");
+  if (!rw->logfile) PE("reopen .jrn after compact");
+
+  r= fsync(fileno(rw->logfile));  if (r) PE("fsync .jrn after compact reopen");
+
+  return TCL_OK;
+
+x_rc:
+  /* doom! all updates fail after this (because rw->logfile is 0), and
+   * we may be using a lot more RAM than would be ideal.  Program will
+   * have to reopen if it really wants sanity. */
   return rc;
 }
 
-/*==================== Other entrypoints ====================*/
+int cht_do_cdbwr_compact_force(ClientData cd, Tcl_Interp *ip, void *rw_v) {
+  return compact_keepopen(ip, rw_v, 1);
+}
+int cht_do_cdbwr_compact_check(ClientData cd, Tcl_Interp *ip, void *rw_v) {
+  return compact_keepopen(ip, rw_v, 0);
+}
+
+int cht_do_cdbwr_compact_explicit(ClientData cd, Tcl_Interp *ip, void *rw_v) {
+  Rw *rw= rw_v;
+  rw->autocompact= 0;
+  return TCL_OK;
+}
+int cht_do_cdbwr_compact_auto(ClientData cd, Tcl_Interp *ip, void *rw_v) {
+  Rw *rw= rw_v;
+  rw->autocompact= 1;
+  return TCL_OK;
+}
+
+/*---------- Updateing ----------*/
+
+static int update(Tcl_Interp *ip, Rw *rw, const char *key,
+		  const Byte *data, int dlen) {
+  HashValue *val;
+  const char *failed;
+  int rc, r;
+  off_t recstart;
+
+  if (strlen(key) >= KEYLEN_MAX)
+    return cht_staticerr(ip, "key too long", "CDB KEYOVERFLOW");
+
+  if (!rw->logfile) return cht_staticerr
+    (ip, "failure during previous compact or error recovery;"
+     " cdbwr must be closed and reopened before any further updates",
+     "CDB BROKEN");
+  
+  recstart= ftello(rw->logfile);
+  if (recstart < 0)
+    return cht_posixerr(ip, errno, "failed to ftello .jrn during update");
+
+  val= htv_prep(dlen);  assert(val);
+  memcpy(htv_fillptr(val), data, dlen);
+
+  r= writerecord(rw->logfile, key, val);
+  if (!r) r= fflush(rw->logfile);
+  if (r) PE("write update to logfile");
+
+  ht_update(&rw->logincore, key, val);
+
+  if (!rw->autocompact) return TCL_OK;
+  return compact_keepopen(ip, rw, 0);
+
+ x_rc:
+  TFREE(val);
+  assert(rc);
+
+  /* Now, we have to try to sort out the journal so that it's
+   * truncated and positioned to where this abortively-written record
+   * started, with no buffered output and the error indicator clear.
+   *
+   * There seems to be no portable way to ensure the buffered unwritten
+   * output is discarded, so we close and reopen the stream.
+   */
+  fclose(rw->logfile);
+
+  rw->logfile= fopen(pathbuf_sfx(&rw->pbsome,".jrn"), "r+");
+  if (!rw->logfile) { failed= "fopen"; goto reset_fail; }
+
+  r= ftruncate(fileno(rw->logfile), recstart);
+  if (r) { failed= "ftruncate"; goto reset_fail; }
+
+  r= fseeko(rw->logfile, recstart, SEEK_SET);
+  if (r) { failed= "fseeko"; goto reset_fail; }
+
+  return rc;
+
+ reset_fail:
+  Tcl_AppendResult(ip, " (additionally, ", failed, " failed"
+		   " in error recovery: ", strerror(errno), ")", (char*)0);
+  if (rw->logfile) { fclose(rw->logfile); rw->logfile= 0; }
+
+  return rc;
+}  
+
+int cht_do_cdbwr_update(ClientData cd, Tcl_Interp *ip,
+			void *rw_v, const char *key, Tcl_Obj *value) {
+  int dlen;
+  const char *data;
+  data= Tcl_GetStringFromObj(value, &dlen);  assert(data);
+  return update(ip, rw_v, key, data, dlen);
+}
+
+int cht_do_cdbwr_update_hb(ClientData cd, Tcl_Interp *ip,
+			   void *rw_v, const char *key, HBytes_Value value) {
+  return update(ip, rw_v, key, cht_hb_data(&value), cht_hb_len(&value));
+}
+
+int cht_do_cdbwr_delete(ClientData cd, Tcl_Interp *ip, void *rw_v,
+			const char *key) {
+  return update(ip, rw_v, key, 0, 0);
+}
+
+/*---------- Lookups ----------*/
+
+static int lookup_rw(Tcl_Interp *ip, void *rw_v, const char *key,
+		    const Byte **data_r, int *len_r /* -1 => notfound */) {
+  Rw *rw= rw_v;
+  const HashValue *val;
+
+  val= ht_lookup(&rw->logincore, key);
+  if (val) {
+    if (val->len) { *data_r= val->data; *len_r= val->len; return TCL_OK; }
+    else goto not_found;
+  }
+
+  if (rw->cdb_fd<0) goto not_found;
+
+  return cht_cdb_lookup_cdb(ip, &rw->cdb, key, strlen(key), data_r, len_r);
+
+ not_found:
+  *data_r= 0;
+  *len_r= -1;
+  return TCL_OK;
+}
+
+int cht_do_cdbwr_lookup(ClientData cd, Tcl_Interp *ip, void *rw_v,
+			const char *key, Tcl_Obj *def,
+			Tcl_Obj **result) {
+  const Byte *data;
+  int dlen, r;
+  
+  r= lookup_rw(ip, rw_v, key, &data, &dlen);  if (r) return r;
+  return cht_cdb_donesomelookup(ip, rw_v, def, result, data, dlen,
+				cht_cdb_storeanswer_string);
+}
+  
+int cht_do_cdbwr_lookup_hb(ClientData cd, Tcl_Interp *ip, void *rw_v,
+			   const char *key, Tcl_Obj *def,
+			   Tcl_Obj **result) {
+  const Byte *data;
+  int dlen, r;
+  
+  r= lookup_rw(ip, rw_v, key, &data, &dlen);  if (r) return r;
+  return cht_cdb_donesomelookup(ip, rw_v, def, result, data, dlen,
+				cht_cdb_storeanswer_hb);
+}