From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun, 17 Mar 2013 13:59:31 +0000 (+0000)
Subject: minor improvements and a todo, prompted by docs work
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?p=cgi-auth-flexible.git;a=commitdiff_plain;h=0908f788ba5fd88725dd9324fb4488748c391d7e

minor improvements and a todo, prompted by docs work
---

diff --git a/cgi-auth-flexible.pm b/cgi-auth-flexible.pm
index c9d9766..f4e0d68 100644
--- a/cgi-auth-flexible.pm
+++ b/cgi-auth-flexible.pm
@@ -1294,22 +1294,25 @@ sub mutate_ok ($) {
 }
 
 our %_resource_get_needs_secret_hidden =
-    (map { $_ => 0 } qw(PAGE FRAME IFRAME SRCDUMP STYLESHEET FAVICON),
+    (map { $_ => 0 } qw(PAGE FRAME IFRAME SRCDUMP STYLESHEET FAVICON ROBOTS),
      map { $_ => 1 } qw(IMAGE SCRIPT AJAX-XML AJAX-JSON AJAX-OTHER));
 
-sub resource_get_needs_secret_hidden ($) {
-    my ($r, $nonpagetype) = @_;
-    my $ent = $_resource_get_needs_secret_hidden{$nonpagetype};
-    die "unsupported nonpage GET type $nonpagetype" unless defined $ent;
+die todo make so can add new ones;
+
+sub need_add_hidden ($$) {
+    my ($r, $method, $reqtype) = @_;
+    return 1 if $method ne 'GET';
+    my $ent = $_resource_get_needs_secret_hidden{$reqtype};
+    die "unsupported nonpage GET type $reqtype" unless defined $ent;
     return $ent;
 }
 
 sub check_nonpage ($$) {
-    my ($r, $nonpagetype) = @_;
+    my ($r, $reqtype) = @_;
     $r->_assert_checked();
     return unless $r->resource_get_needs_secret_hidden($nonpagetype);
     return if $r->{ParmT};
-    die "missing hidden secret parameter on nonpage GET $nonpagetype";
+    die "missing hidden secret parameter on nonpage request $nonpagetype";
 }
 
 #---------- output ----------