From f7e755628b681804e4dd82cd8bcb501a5a6dca57 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sun, 11 Mar 2007 10:12:45 +0000 Subject: [PATCH 1/1] Gary Wong observes that solo's decode_params() is overenthusiastic about eating the letter `d' (for `diagonal') when it appears in a symmtery description: it should only be used after `m', because mirror symmetry is the only type that can be diagonal. This was causing parsing of the parameter description `3x3adu' to produce the wrong answer: the d would be swallowed, then the u ignored for being incomprehensible, and you'd get default Trivial difficulty. [originally from svn r7386] --- solo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solo.c b/solo.c index c02e750..bba2cbd 100644 --- a/solo.c +++ b/solo.c @@ -207,7 +207,7 @@ static void decode_params(game_params *ret, char const *string) if (*string == 'r' || *string == 'm' || *string == 'a') { int sn, sc, sd; sc = *string++; - if (*string == 'd') { + if (sc == 'm' && *string == 'd') { sd = TRUE; string++; } else { -- 2.30.2