From e7b2a9dd8d8915802fb69ce2242b1f913b7f3172 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Wed, 4 May 2011 18:22:15 +0000 Subject: [PATCH] Having looked at Keen's clue selection code, I also notice that the intended behaviour of classifying multiplication clues as low-quality if they only left one possible pair of multiplicands has never actually worked, because I should have compared the possible clue count against 2 rather than 1 since the multiplicands can occur either way round. [originally from svn r9165] --- keen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/keen.c b/keen.c index 175db55..8d9b6bd 100644 --- a/keen.c +++ b/keen.c @@ -931,7 +931,7 @@ done for (k = 1; k <= w; k++) if (v % k == 0 && v / k <= w && v / k != k) n++; - if (n > 1) + if (n > 2) singletons[j] |= F_MUL; else singletons[j] |= F_MUL_BAD; -- 2.30.2