From: Simon Tatham Date: Sat, 21 Jun 2014 17:40:29 +0000 (+0000) Subject: Fix vertically misaligned text in Javascript puzzles. X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?a=commitdiff_plain;h=ff8a9fbc541b714e64fc089f75ec712a04cbd90f;hp=a7ddd6337517864d8ae44a20b8225046b6d6fdf3;p=sgt-puzzles.git Fix vertically misaligned text in Javascript puzzles. When I constructed my test canvas to measure the vertical extent of a text string for ALIGN_VCENTRE, I forgot to ensure that the 'width' variable was an integer, as a result of which the loop over canvas pixels kept trying to use fractional array indices and returning undefined :-) [originally from svn r10196] --- diff --git a/emcclib.js b/emcclib.js index 7d001c3..385281a 100644 --- a/emcclib.js +++ b/emcclib.js @@ -412,7 +412,7 @@ mergeInto(LibraryManager.library, { // Find the width of the string var ctx1 = onscreen_canvas.getContext('2d'); ctx1.font = font; - var width = ctx1.measureText(midpoint_test_str).width; + var width = (ctx1.measureText(midpoint_test_str).width + 1) | 0; // Construct a test canvas of appropriate size, initialise it to // black, and draw the string on it in white