From: Simon Tatham Date: Mon, 15 Jan 2007 23:30:44 +0000 (+0000) Subject: Phil Bordelon points out an off-by-one error: since Solo doesn't use X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?a=commitdiff_plain;h=a7f19c87a9d926cdb8a090d96bda4a6f853bfe18;p=sgt-puzzles.git Phil Bordelon points out an off-by-one error: since Solo doesn't use zero as a valid puzzle symbol, it can support at most 35 symbols, not 36. (This is largely academic since IME anything above about 25 is impractical to generate, but there we go.) [originally from svn r7115] --- diff --git a/solo.c b/solo.c index a2f40eb..0a4e852 100644 --- a/solo.c +++ b/solo.c @@ -331,8 +331,8 @@ static char *validate_params(game_params *params, int full) return "Both dimensions must be at least 2"; if (params->c > ORDER_MAX || params->r > ORDER_MAX) return "Dimensions greater than "STR(ORDER_MAX)" are not supported"; - if ((params->c * params->r) > 36) - return "Unable to support more than 36 distinct symbols in a puzzle"; + if ((params->c * params->r) > 35) + return "Unable to support more than 35 distinct symbols in a puzzle"; return NULL; }