From: Simon Tatham <anakin@pobox.com>
Date: Wed, 24 Feb 2016 19:18:30 +0000 (+0000)
Subject: Tracks: tighten up a small loophole in completion checking.
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?a=commitdiff_plain;h=755c3d5277262739e8beb03da3649e7f4d53e915;p=sgt-puzzles.git

Tracks: tighten up a small loophole in completion checking.

If you had a single connected path linking the source to the
destination but _also_ had a spurious edge elsewhere in the grid, then
the spurious edge would be highlighted as an error, but it wouldn't
inhibit declaring the game complete and showing the victory flash.
---

diff --git a/tracks.c b/tracks.c
index d633a9c..2fefe36 100644
--- a/tracks.c
+++ b/tracks.c
@@ -1646,8 +1646,10 @@ static int check_completion(game_state *state, int mark)
             for (i = 0; i < w*h; i++) {
                 if ((dsf_canonify(dsf, i) != pathclass) &&
                     ((state->sflags[i] & S_TRACK) ||
-                     (S_E_COUNT(state, i%w, i/w, E_TRACK) > 0)))
+                     (S_E_COUNT(state, i%w, i/w, E_TRACK) > 0))) {
+                    ret = FALSE;
                     state->sflags[i] |= S_ERROR;
+                }
             }
         }
     }