From: Simon Tatham Date: Fri, 17 Aug 2012 19:45:03 +0000 (+0000) Subject: Fix implicit split to @_. Also add 'use warnings', which would have X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?a=commitdiff_plain;h=200d6533bb315e5f69f926d15724016132cf6232;p=sgt-puzzles.git Fix implicit split to @_. Also add 'use warnings', which would have spotted it for me. [originally from svn r9605] --- diff --git a/winiss.pl b/winiss.pl index bd2ac05..7416ace 100755 --- a/winiss.pl +++ b/winiss.pl @@ -11,13 +11,15 @@ # where `1234' is the revision number which will be encoded in the # installer's version indicators. +use warnings; + $rev = shift @ARGV; ($revclean=$rev) =~ s/M$//; $lst = shift @ARGV; open LST, "<", $lst; while () { chomp; - split /:/; + @_ = split /:/; push @exes, $_[0]; $names{$_[0]} = $_[1]; }