filed MR for missing From<Box<>>

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

diff --git a/src/bin/client.rs b/src/bin/client.rs
index 83fc74f0d332909352f11a615b90d8258200e926..d45434292a18023d317d6124388c41dbecbca8b1 100644 (file)
--- a/src/bin/client.rs
+++ b/src/bin/client.rs
@@ -249,8 +249,8 @@ async fn run_client<C:HCC>(
            ! packets.is_empty() =>
         {
           while let Some(packet) = packets.pop_front() {
-            match upbound.add(ic.max_batch_up, packet.into()/*xxx*/) {
-              Err(packet) => { packets.push_front(packet.into()/*xxx*/); break; }
+            match upbound.add(ic.max_batch_up, packet.into()/*todo:504*/) {
+              Err(packet) => { packets.push_front(packet.into()/*todo:504*/); break; }
               Ok(()) => { },
             }
           }

diff --git a/src/slip.rs b/src/slip.rs
index 452634e392f40b9fbde09fbb03976b7365369bcb..67b4d40b17fc7d3da40bfe7d1d94c284b95d2b02 100644 (file)
--- a/src/slip.rs
+++ b/src/slip.rs
@@ -100,9 +100,12 @@ where AC: Fn(&[u8]) -> Result<(), PacketError>,
 
 pub type Frame = Vec<u8>;
 pub type FramesData = Vec<Vec<u8>>;
-//pub type Frame = Box<[u8]>;
-//pub type FramesData = Vec<Frame>;
-//  `From<Box<[u8]>>` is not implemented for `Bytes`
+// todo: https://github.com/tokio-rs/bytes/pull/504
+//   pub type Frame = Box<[u8]>;
+//   pub type FramesData = Vec<Frame>;
+//       `From<Box<[u8]>>` is not implemented for `Bytes`
+// when this is fixed, there are two `into`s in client.rs which 
+// become redundant (search for todo:504)
 
 
 #[derive(Default)]