X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?a=blobdiff_plain;f=servexec.c;h=80b754c1dd31938ae3092ce1363f8c62f9c50e76;hb=HEAD;hp=168e07657ad427dd16021e5a58662d0af10cd9ef;hpb=a4833eb88857a3027cc2d9ff602f8f2e076b9d6d;p=userv.git
diff --git a/servexec.c b/servexec.c
index 168e076..80b754c 100644
--- a/servexec.c
+++ b/servexec.c
@@ -2,11 +2,12 @@
* userv - execserv.c
* daemon code which executes actual service (ie child process)
*
- * Copyright (C)1996-1997,1999 Ian Jackson
+ * userv is copyright Ian Jackson and other contributors.
+ * See README for full authorship information.
*
* This is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but
@@ -15,8 +16,7 @@
* General Public License for more details.
*
* You should have received a copy of the GNU General Public License
- * along with userv; if not, write to the Free Software
- * Foundation, 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ * along with userv; if not, see .
*/
#include
@@ -35,6 +35,7 @@
#include "common.h"
#include "daemon.h"
#include "lib.h"
+#include "both.h"
#include "version.h"
static void NONRETURNING serv_syscallfail(const char *msg) {
@@ -70,7 +71,7 @@ void bisexec_version(const char *const *argv) {
const unsigned char *p;
int i;
- printf("uservd version " VERSION VEREXT "; copyright (C)1996-1997 Ian Jackson.\n"
+ printf("uservd version " VERSION VEREXT "\n"
#ifdef DEBUG
"DEBUGGING VERSION"
#else
@@ -92,7 +93,8 @@ void bisexec_version(const char *const *argv) {
printf("\n"
"rendezvous socket: `" RENDEZVOUSPATH "'\n"
"system config dir: `" SYSTEMCONFIGDIR "'\n"
- "pipe filename format: `%s' (max length %d)\n",
+ "pipe filename format: `%s' (max length %d)\n"
+ COPYRIGHT("","\n"),
PIPEFORMAT, PIPEMAXLEN);
serv_checkstdoutexit();
}
@@ -137,6 +139,15 @@ void bisexec_execute(const char *const *argv) {
serv_checkstdoutexit();
}
+void bisexec_shutdown(const char *const *argv) {
+ /* This is only reached if the serviceuser_uid test in
+ * process.c:servicerequest() fails (we have to handle the
+ * shutdown request there, unfortunately).
+ */
+ fputs("uservd: builtin service shutdown: permission denied\n",stderr);
+ _exit(-1);
+}
+
static void serv_resetsignal(int signo) {
struct sigaction sig;
@@ -181,7 +192,7 @@ static const char *see_c_group(void) {
static const char *seei_gid(int i) {
static char buf[CHAR_BIT*sizeof(gid_t)/3+4];
- snyprintf(buf,sizeof(buf),"%d",calling_gids[i]);
+ snyprintf(buf,sizeof(buf),"%ld",(long)calling_gids[i]);
return buf;
}
static const char *see_c_gid(void) {
@@ -214,7 +225,8 @@ void execservice(const int synchsocket[], int clientfd) {
"-",
0
};
- int fd, realfd, holdfd, newfd, r, envvarbufsize=0, targ, nargs, i, l;
+ int fd, realfd, holdfd, newfd, r, envvarbufsize=0, targ, nargs, i, l, fdflags;
+ int unused;
char *envvarbuf=0;
const char **args, *const *cpp;
char *const *pp;
@@ -223,7 +235,8 @@ void execservice(const int synchsocket[], int clientfd) {
if (dup2(fdarray[2].realfd,2)<0) {
static const char duperrmsg[]= "uservd(service): cannot dup2 for stderr\n";
- write(fdarray[2].realfd,duperrmsg,sizeof(duperrmsg)-1);
+ unused= write(fdarray[2].realfd,duperrmsg,sizeof(duperrmsg)-1);
+ (void)unused;
_exit(-1);
}
serv_resetsignal(SIGPIPE);
@@ -237,10 +250,20 @@ void execservice(const int synchsocket[], int clientfd) {
if (r!=1) serv_syscallfail("write synch byte to parent");
r= synchread(synchsocket[1],'g');
if (r) serv_syscallfail("reach synch byte from parent");
+ if (close(synchsocket[1])) serv_syscallfail("close our synch socket");
if (close(clientfd)) serv_syscallfail("close client socket fd");
- /* Now we have to make all the fd's work. It's rather a complicated
+ /* First we need to close the holding writing ends of the pipes
+ * inherited from our parent: */
+ for (fd=0; fd= 0)
+ fdarray[fdarray[fd].realfd].holdfd= fd;
}
for (fd=0; fd