X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?a=blobdiff_plain;f=scripts%2Fgit-cache-proxy;h=3e57a4f5530e2971794dd3a82612590421624c8e;hb=cb4bd3da4722880f69cd53cc8c4fa114259c45c5;hp=0c6ba556d4909dd70b3b7dd3c8ff01a001759bc4;hpb=0551f3103af1b31e4cf03bd81c191f34837ef7d1;p=chiark-utils.git diff --git a/scripts/git-cache-proxy b/scripts/git-cache-proxy index 0c6ba55..3e57a4f 100755 --- a/scripts/git-cache-proxy +++ b/scripts/git-cache-proxy @@ -29,7 +29,7 @@ # git-cache-proxy # Copyright 2010 Tony Finch -# Copyright 2013 Ian Jackson +# Copyright 2013,2014 Ian Jackson # # git-cache-proxy is free software; you can redistribute it and/or # modify them under the terms of the GNU General Public License as @@ -415,14 +415,11 @@ sub housekeeping () { die "$dir: cannot rename to $tdir: $!\n"; } } - my $errs; - remove_tree($tdir, { safe=>1, error=>\$errs }); - if (!stat $tdir) { - foreach my $err (@$errs) { - my ($file, $message) = %$err; - logm 'info', "problem deleting: $file: $message"; - } - die "$dir: problem deleting file(s)\n"; + system qw(rm -rf --), $tdir; + if (stat $tdir) { + die "$dir: problem deleting file(s), rm exited $?\n"; + } elsif ($! != ENOENT) { + die "$tdir: cannot stat after deletion: $!\n"; } } }; @@ -459,8 +456,10 @@ sub housekeepingcheck ($$) { } if ($dofork) { my $child = fork; - defined $child or hkfail "fork: $!"; + defined $child or fail "fork: $!"; if (!$child) { + open STDERR, "|logger -p daemon.warning -t '$us(housekeeping)'" + or die "fork: logger $!"; housekeeping(); exit 0; }