X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ian/git?a=blobdiff_plain;ds=sidebyside;f=base%2Fscriptinv.c;h=a066572c2873ecc3edff403574c8f6cc2a89f350;hb=f16e3e0cf0a2b965643df01e24ef59e1393da78d;hp=29651b254769d61680f542a4671d156847acea74;hpb=3340221c68f8c948db9d2d3b553692fe642dd0f8;p=chiark-tcl.git

diff --git a/base/scriptinv.c b/base/scriptinv.c
index 29651b2..a066572 100644
--- a/base/scriptinv.c
+++ b/base/scriptinv.c
@@ -1,16 +1,18 @@
 /*
  */
 
-#include "chiark-tcl.h"
+#include "chiark-tcl-base.h"
 
 void cht_scriptinv_init(ScriptToInvoke *si) {
-  si->obj= 0;
+  si->ipq= 0;
+  si->script= 0;
   si->xargs= 0;
 }
 
 void cht_scriptinv_cancel(ScriptToInvoke *si) {
-  if (si->obj) { Tcl_DecrRefCount(si->obj); si->obj= 0; }
+  if (si->script) { Tcl_DecrRefCount(si->script); si->script= 0; }
   if (si->xargs) { Tcl_DecrRefCount(si->xargs); si->xargs= 0; }
+  si->ipq= 0;
 }
 
 int cht_scriptinv_set(ScriptToInvoke *si, Tcl_Interp *ip,
@@ -18,41 +20,44 @@ int cht_scriptinv_set(ScriptToInvoke *si, Tcl_Interp *ip,
   int rc, xlength;
   
   cht_scriptinv_cancel(si);
+  if (!newscript) return 0;
 
-  rc= Tcl_ListObjLength(ip, newscript, &si->llength);  if (rc) return rc;
+  rc= Tcl_ListObjLength(ip, newscript, &si->llen);  if (rc) return rc;
   Tcl_IncrRefCount(newscript);
 
   if (xargs) {
     rc= Tcl_ListObjLength(ip, xargs, &xlength);  if (rc) return rc;
     Tcl_IncrRefCount(xargs);
-    si->llength += xlength;
+    si->llen += xlength;
   }
 
-  si->obj= newscript;
+  si->script= newscript;
   si->xargs= xargs;
-  si->ip= ip;
+  si->ipq= ip;
   return 0;
 }  
   
-void cht_scriptinv_invoke(ScriptToInvoke *si, int argc, Tcl_Obj *const *argv) {
+int cht_scriptinv_invoke_fg(ScriptToInvoke *si, int argc,
+			    Tcl_Obj *const *argv) {
   Tcl_Obj *invoke=0;
   int i, rc;
 
-  assert(si->obj);
+  if (!si->ipq) return TCL_OK;
+
   for (i=0; i<argc; i++) Tcl_IncrRefCount(argv[i]);
 
-  invoke= Tcl_DuplicateObj(si->obj);
+  invoke= Tcl_DuplicateObj(si->script);
   Tcl_IncrRefCount(invoke);
 
   if (si->xargs) {
-    rc= Tcl_ListObjAppendList(si->ip, invoke, si->xargs);
+    rc= Tcl_ListObjAppendList(si->ipq, invoke, si->xargs);
     if (rc) goto x_rc;
   }
 
-  rc= Tcl_ListObjReplace(si->ip, invoke,si->llength,0, argc,argv);
+  rc= Tcl_ListObjReplace(si->ipq, invoke,si->llen,0, argc,argv);
   if (rc) goto x_rc;
 
-  rc= Tcl_EvalObjEx(si->ip,invoke,TCL_EVAL_GLOBAL|TCL_EVAL_DIRECT);
+  rc= Tcl_EvalObjEx(si->ipq, invoke, TCL_EVAL_GLOBAL|TCL_EVAL_DIRECT);
   if (rc) goto x_rc;
 
   rc= 0;
@@ -60,5 +65,11 @@ void cht_scriptinv_invoke(ScriptToInvoke *si, int argc, Tcl_Obj *const *argv) {
 x_rc:
   for (i=0; i<argc; i++) Tcl_DecrRefCount(argv[i]);
   if (invoke) Tcl_DecrRefCount(invoke);
-  if (rc) Tcl_BackgroundError(si->ip);
+  return rc;
 }
+
+void cht_scriptinv_invoke(ScriptToInvoke *si, int argc, Tcl_Obj *const *argv) {
+  int rc;
+  rc= cht_scriptinv_invoke_fg(si, argc, argv);
+  if (rc) Tcl_BackgroundError(si->ipq);
+}