Do not leak a harmless fd into the service program environment

[userv.git] / servexec.c

diff --git a/servexec.c b/servexec.c
index aa35fc7550272dcc9286160673791a829909b64f..6b55ea7b730c8c287a7cf1e49b1a77307ac3bbf4 100644 (file)
--- a/servexec.c
+++ b/servexec.c
@@ -2,11 +2,14 @@
  * userv - execserv.c
  * daemon code which executes actual service (ie child process)
  *
- * Copyright (C)1996-1997,1999 Ian Jackson
+ * userv is
+ * Copyright 1996-2017 Ian Jackson <ian@davenant.greenend.org.uk>.
+ * Copyright 2000      Ben Harris <bjh21@cam.ac.uk>
+ * Copyright 2016-2017 Peter Benie <pjb1008@cam.ac.uk>
  *
  * This is free software; you can redistribute it and/or modify it
  * under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful, but
@@ -15,8 +18,7 @@
  * General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with userv; if not, write to the Free Software
- * Foundation, 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ * along with userv; if not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <stdio.h>
@@ -71,7 +73,7 @@ void bisexec_version(const char *const *argv) {
   const unsigned char *p;
   int i;
   
-  printf("uservd version " VERSION VEREXT "; copyright (C)1996-2000 Ian Jackson.\n"
+  printf("uservd version " VERSION VEREXT "\n"
 #ifdef DEBUG
         "DEBUGGING VERSION"
 #else
@@ -93,7 +95,8 @@ void bisexec_version(const char *const *argv) {
   printf("\n"
         "rendezvous socket: `" RENDEZVOUSPATH "'\n"
         "system config dir: `" SYSTEMCONFIGDIR "'\n"
-        "pipe filename format: `%s' (max length %d)\n",
+        "pipe filename format: `%s' (max length %d)\n"
+        COPYRIGHT("","\n"),
         PIPEFORMAT, PIPEMAXLEN);
   serv_checkstdoutexit();
 }
@@ -247,6 +250,7 @@ void execservice(const int synchsocket[], int clientfd) {
   if (r!=1) serv_syscallfail("write synch byte to parent");
   r= synchread(synchsocket[1],'g');
   if (r) serv_syscallfail("reach synch byte from parent");
+  if (close(synchsocket[1])) serv_syscallfail("close our synch socket");
 
   if (close(clientfd)) serv_syscallfail("close client socket fd");