1 From: Werner Koch <wk@gnupg.org>
2 Date: Fri, 10 Feb 2017 17:16:07 +0100
3 Subject: gpg: Fix memory leak in the error case of signature creation.
5 Content-Type: text/plain; charset="utf-8"
6 Content-Transfer-Encoding: 8bit
8 * g10/sign.c (write_signature_packets): Free SIG. Also replace
12 If do_sign fails SIG was not released. Note that in the good case SIG
13 is transferred to PKT and freed by free_packet.
15 Reported-by: Stephan Müller
16 Signed-off-by: Werner Koch <wk@gnupg.org>
17 (cherry picked from commit 5996c7bf99f3a681393fd9589276399ebc956cff)
19 g10/sign.c | 11 +++++++++--
20 1 file changed, 9 insertions(+), 2 deletions(-)
22 diff --git a/g10/sign.c b/g10/sign.c
23 index acc894c..ff099b3 100644
26 @@ -686,7 +686,10 @@ write_signature_packets (SK_LIST sk_list, IOBUF out, gcry_md_hd_t hash,
29 /* Build the signature packet. */
30 - sig = xmalloc_clear (sizeof *sig);
31 + sig = xtrycalloc (1, sizeof *sig);
33 + return gpg_error_from_syserror ();
35 if (duration || opt.sig_policy_url
36 || opt.sig_notations || opt.sig_keyserver_url)
38 @@ -731,8 +734,12 @@ write_signature_packets (SK_LIST sk_list, IOBUF out, gcry_md_hd_t hash,
39 print_status_sig_created (pk, sig, status_letter);
42 - log_error ("build signature packet failed: %s\n", gpg_strerror (rc));
43 + log_error ("build signature packet failed: %s\n",