1 From d64db36be81b970bfc9f9d7bae854819e267d6a0 Mon Sep 17 00:00:00 2001
2 From: Ian Jackson <ijackson@chiark.greenend.org.uk>
3 Date: Fri, 4 Nov 2016 17:23:42 +0000
4 Subject: [PATCH 1/5] check-ref-format: Refactor out check_one_ref_format
6 We are going to want to reuse this. No functional change right now.
8 It currently has a hidden memory leak if --normalize is used.
10 Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
12 builtin/check-ref-format.c | 26 ++++++++++++++------------
13 1 file changed, 14 insertions(+), 12 deletions(-)
15 diff --git a/builtin/check-ref-format.c b/builtin/check-ref-format.c
16 index eac4994..4d56caa 100644
17 --- a/builtin/check-ref-format.c
18 +++ b/builtin/check-ref-format.c
19 @@ -48,12 +48,22 @@ static int check_ref_format_branch(const char *arg)
23 +static int normalize = 0;
24 +static int flags = 0;
26 +static int check_one_ref_format(const char *refname)
29 + refname = collapse_slashes(refname);
30 + if (check_refname_format(refname, flags))
33 + printf("%s\n", refname);
36 int cmd_check_ref_format(int argc, const char **argv, const char *prefix)
41 - const char *refname;
43 if (argc == 2 && !strcmp(argv[1], "-h"))
44 usage(builtin_check_ref_format_usage);
45 @@ -76,13 +86,5 @@ int cmd_check_ref_format(int argc, const char **argv, const char *prefix)
46 if (! (i == argc - 1))
47 usage(builtin_check_ref_format_usage);
51 - refname = collapse_slashes(refname);
52 - if (check_refname_format(refname, flags))
55 - printf("%s\n", refname);
58 + return check_one_ref_format(argv[i]);