chiark / gitweb /
hacky exim queue admin helpers
[bin.git] / crondiv
diff --git a/crondiv b/crondiv
old mode 100644 (file)
new mode 100755 (executable)
index 666171c..1157511
--- a/crondiv
+++ b/crondiv
@@ -3,26 +3,26 @@
 # "Divide" a crontab frequency down by the first argument on the command line,
 # logging to the second argument, and executing the remainder.
 
-if [ "X$1" = "X" -o "X$2" = "X" -o "X$3" = "X" ]; then
+if [ -z "$1" ] || [ -z "$2" ] || [ -z "$3" ]; then
        echo "Usage: $0 frequency logfile command [ arguments ]" >&2
        exit 1
 fi
 
-FREQUENCY=$1
-LOGFILE=$2
+FREQUENCY="$1"
+LOGFILE="$2"
 shift 2
 
-if [ -f $LOGFILE ]; then
-       LASTEXEC=$(($(tail -n 1 $LOGFILE)+1))
+if [ -f "$LOGFILE" ]; then
+       LASTEXEC="$(($(tail -n 1 "$LOGFILE")+1))"
 else
        LASTEXEC=1
 fi
 
-if [ $LASTEXEC -ge $FREQUENCY ]; then
-       echo "$*" executed at $(date) >> $LOGFILE
-       echo 0 >> $LOGFILE
+if [ "$LASTEXEC" -ge "$FREQUENCY" ]; then
+       echo "$* executed at $(date)" >> "$LOGFILE"
+       echo 0 >> "$LOGFILE"
        eval "$*"
 else
-       echo $LASTEXEC >> $LOGFILE
+       echo "$LASTEXEC" >> "$LOGFILE"
 fi