[PATCH consfigurator v2 2/2] GPG: handle missing file separately to subprocess errors

[Sean Whitton]

Hello,

On Sun 25 Sep 2022 at 08:38PM +02, Russell Sim wrote:

> There is a special case when running on remote machines where we might want to
> handle missing data sources and skip them, so we must raise the
> MISSING-DATA-SOURCE condition if the source is missing.
>
> Providing this functionality for READ-STORE created a discrepancy where
> SUBPROCESS-ERROR's were wrapped differently depending on if you called
> PUT-STORE or READ-STORE.  Handling the missing case explicitly allows us to
> pass the GPG-ERROR directly without needing to re-wrap it in the case where
> the file is missing.

I'm struggling to understand the purpose of this patch based on your
description.  Could you give a few examples, perhaps?

I don't know exactly what you mean when you say "remote machine", but it
seems worth noting that data sources are never accessed except in the
root Lisp -- see the long comment in CONTINUE-DEPLOY*-PROGRAM.

-- 
Sean Whitton