[git-remote-gcrypt] Useless 2nd argument of PRIVDECRYPT

Lucas Cimon lucas.cimon at gmail.com
Thu Aug 11 21:39:32 BST 2022


Hi!

Thank you for maintaining this great project.

While playing with it, I realized something strange with the internal
PRIVDECRYPT
<https://github.com/spwhitton/git-remote-gcrypt/blob/master/git-remote-gcrypt#L364>
function:
it takes 2 arguments, and the 2nd one (the textual signers list) is never
used, appart from the occasional error message.

You'll find enclosed a patch that removes this "signers" argument from
PRIVDECRYPT,
and the resulting "git-remote-gcrypt" script works perfectly fine.

It seems like the "good signature" argument passed to PRIVDECRYPT already
contains enough information
to check for "gcrypt.participants" signatures.

What do you think?

Regards

- Lucas Cimon



-- 
https://chezsoi.org/lucas/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.chiark.greenend.org.uk/pipermail/sgo-software-discuss/attachments/20220811/b12efe19/attachment.htm>


More information about the sgo-software-discuss mailing list