[PATCH consfigurator v2 5/6] add gnupg scaffolding for test suite

Sean Whitton spwhitton at spwhitton.name
Fri Mar 11 18:12:29 GMT 2022


Hello David,

On Fri 11 Mar 2022 at 06:56am -04, David Bremner wrote:

> Yeah, it seems reasonable. Also we can avoid env by conditionally
> passing --homedir to gpg. But the parameter should maybe live in package
> consfigurator? Then what about the functions in data/util.lisp?
> gpg-file-as-string can certainly reference the parameter by qualified
> path, but maybe it would be less confusing to just move everything in
> data/util.lisp into util.lisp?

I see what you mean -- it would be strange to have the user have to
import from UTIL.DATA in order to setq it in their consfig.  One option
would be to have each data source for which it is relevant reexport it.
Otherwise, yes, I guess it has to go in CONSFIGURATOR.  But I think it
should have a qualified name, e.g. *DATA-SOURCE-GNUPGHOME*, to make it
clear it's only about data sources.

I don't mind moving everything into util.lisp, but another option would
be to put *DATA-SOURCE-GNUPGHOME* in data.lisp and keep data/util.lisp.

-- 
Sean Whitton



More information about the sgo-software-discuss mailing list