[consfigurator] v2 pass data source

Sean Whitton spwhitton at spwhitton.name
Thu Mar 10 21:40:09 GMT 2022


Hello,

On Thu 10 Mar 2022 at 11:55am -07, Sean Whitton wrote:

> Hello,
>
> On Wed 09 Mar 2022 at 08:28pm -04, David Bremner wrote:
>
>> Hopefully I caught most of Sean's comments from the previous version.  This
>> version impliments much stricter validation for IDEN1 and IDEN2 (btw it would
>> be good to have a name for these). Along the way it introduces
>> #'valid-hostname-p, and extends the test suite to set up and tear down a gpg
>> and pass setup to test against.
>
> Thanks.  I am going to get the first half of the series and my docs
> change restricting the valid IDEN1 applied to master, plus calling
> VALID-HOSTNAME-P in data.lisp, and then look more carefully at the
> latter three patches.

... however I just noticed that there is no Signed-off-by on these
patches, so probably best for you to resend the whole series after I've
commented on the final three patches.

-- 
Sean Whitton



More information about the sgo-software-discuss mailing list