[PATCH] Add some properties to install and configure Postgresql

David Bremner david at tethera.net
Wed Dec 29 17:50:37 GMT 2021


Sean Whitton <spwhitton at spwhitton.name> writes:

>> +(named-readtables:in-readtable :interpol-syntax)
>
> You don't need this, as the :consfigurator named readtable includes it.

dropped.
>
> (defproplist %run-sql :posix (sql)
>   (as (or (get-hostattrs-car 'postgres-superuser) "postgres")
>     (cmd:single :input sql "psql" "postgres")))

Done.
>
>> +(defproplist has-database :posix (db-name &key (owner nil))
>
> Keyword parameter default values default to nil, so please drop the
> sublist.

I dropped this parameter, and added a new property "has-owner",
following the pattern from e.g. consifigurator.property.user

>
> If I later supply an OWNER parameter, will the database ownership be
> updated?  If not, could you extend the SQL to do that?  Makes the
> property a lot easier to use, I think.
>

This is solved / avoided by the new property 'has-owner'

Updated patch to follow.



More information about the sgo-software-discuss mailing list