[git-remote-gcrypt] BUG involving handling of spaces in user.signingkey value

Sean Whitton spwhitton at spwhitton.name
Wed Jun 16 04:55:02 BST 2021


Hello,

On Tue 15 Jun 2021 at 08:20PM -04, Jeff Huffman wrote:

> 1. Using array variables rather than space-separated strings for information that is,
>    logically, a list of strings.

Unfortunately, that's not in POSIX sh.

> 2. Expanding array variables in double quotes. i.e. use "$@", not $@

That might be a good idea in this case.

> I'm hardly an accomplished shell programmer, but in my limited
> experience, these 2 rules seem like they solve a whole lot of
> whitespace problems for me before they begin.  Sorry if a came off a
> bit preachy :-)

Not at all.

-- 
Sean Whitton



More information about the sgo-software-discuss mailing list