[PATCH] rclone needs a flag to exit nonzero when a file is not found

Sean Whitton spwhitton at spwhitton.name
Sun Jun 13 07:52:10 BST 2021


Hello,

On Wed 09 Jun 2021 at 01:33PM -10, nathants wrote:

> Signed-off-by: Nathan Todd-Stone <me at nathants.com>
> ---
>  git-remote-gcrypt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/git-remote-gcrypt b/git-remote-gcrypt
> index c519bf8..7e7240f 100755
> --- a/git-remote-gcrypt
> +++ b/git-remote-gcrypt
> @@ -238,7 +238,7 @@ GET()
>  		(exec 0>&-; rsync -I -W "$(rsynclocation "$1")"/"$2" "$3" >&2)
>  	elif isurl rclone "$1"
>  	then
> -		(exec 0>&-; rclone copyto "${1#rclone://}"/"$2" "$3" >&2)
> +		(exec 0>&-; rclone copyto --error-on-no-transfer "${1#rclone://}"/"$2" "$3" >&2)
>  	elif islocalrepo "$1"
>  	then
>  		cat "$1/$2" > "$3"
> @@ -258,7 +258,7 @@ PUT()
>  		rsync $Conf_rsync_put_flags -I -W "$3" "$(rsynclocation "$1")"/"$2" >&2
>  	elif isurl rclone "$1"
>  	then
> -		rclone copyto "$3" "${1#rclone://}"/"$2" >&2
> +		rclone copyto --error-on-no-transfer "$3" "${1#rclone://}"/"$2" >&2
>  	elif islocalrepo "$1"
>  	then
>  		cat >| "$1/$2" < "$3"

Thank you for this, but could you provide more detail for the commit
message, please?  In what situation are there problems and why is this
the best way to resolve them?

-- 
Sean Whitton



More information about the sgo-software-discuss mailing list