[PATCH git-remote-gcrypt imported] Allowing git-config to configure ...

[Sean Whitton]

Hello,

On Tue 02 Jun 2020 at 10:42AM +01, Jay Colson wrote:

> https://github.com/spwhitton/git-remote-gcrypt/commit/effdd2cf440963a790c668ea045b4cf65b0bdf00

Unfortunately, your current patch doesn't work.  It assumes that there
is exactly one refspec in $1 inside do_push, which might not be true.

I think that you need to do the check after the loop which begins

    while IFS=: read -r src_ dst_ # << +src:dst

as then you'll have a list of refspecs and you can just see if any of
them don't start with a '+'.

I also noticed that your patch introduces indentation and whitespace
errors; I'd be grateful if you could follow the style of the existing
code in your next revision.

Thanks!

-- 
Sean Whitton