[PATCH 25/43] Hack on the newly imported X25519 and X448 code.

Mark Wooding mdw at distorted.org.uk
Sun Apr 30 20:40:02 BST 2017

Ian Jackson <ijackson at chiark.greenend.org.uk> writes:

> Is there a way to retain more of the textual formatting, etc., of the
> original ?  When copying cryptoalgorithms wholesale I normally prefer
> to use a set of #defines to make it fit, rather than reformatting.

Yes.  I've had another go at this, taking a different approach.  There's
still a lot of pure deletion, but I'm pretty sure we'll never want the
stuff I've deleted, and code which doesn't exist can't have bugs in.
I've preserved the formatting, and this time I've left in stuff which we
don't need now but might want later (though I've ifdeffed it out because
it won't build without some more support machinery).

The diff is still rather heavy, but most of it is the test vectors.  I
don't have a good answer for them: upstream has some elaborate machinery
for parsing them which I really don't want to reproduce here, even in
Perl or something.  Indeed, I liked the idea so little that I prepared
the replacement test vector files by hand.

-- [mdw]

More information about the sgo-software-discuss mailing list