[PATCH 2/5] make-secnet-sites: Fix userv invocation after pfilepath

Ian Jackson ijackson at chiark.greenend.org.uk
Thu Jul 12 19:56:09 BST 2012


Richard Kettlewell writes ("Re: [PATCH 2/5] make-secnet-sites: Fix userv invocation after pfilepath"):
> I don't seem to have time to do the full set of outstanding patches 
> justice, but I did notice a couple of trivial things:

Thanks.

> On 17/12/2011 22:03, Ian Jackson wrote:
>  > +		headerinput=pfilepath(header,allow_include=True)
> 
> The description seems to be slightly inaccurate - 'headerinput' rather 
> than 'headerlines'.

I have fixed this.  (NB this means that the "live" branch in chiark's
/home/secnet/secnet-live.git is going to be rebasing.)

> On 17/12/2011 22:03, Ian Jackson wrote:
>  > -#define LINK_QUALITY_DOWN 0   /* No chance of a packet being 
> delivered */
>  > -#define LINK_QUALITY_DOWN_STALE_ADDRESS 1 /* Link down, old address 
> information */
>  > -#define LINK_QUALITY_DOWN_CURRENT_ADDRESS 2 /* Link down, current 
> address information */
>  > -#define LINK_QUALITY_UP 3     /* Link active */
>  > +#define LINK_QUALITY_UNUSED 0   /* This link is unused, do not make 
> this netlink */
>  > +#define LINK_QUALITY_DOWN 1   /* No chance of a packet being 
> delivered right away*/
>  > +#define LINK_QUALITY_DOWN_STALE_ADDRESS 2 /* Link down, old address 
> information */
>  > +#define LINK_QUALITY_DOWN_CURRENT_ADDRESS 3 /* Link down, current 
> address information */
>  > +#define LINK_QUALITY_UP 4     /* Link active */
> 
> Perhaps this should be an enum.

Maybe.  I don't think that's critical now though.

Ian.



More information about the sgo-software-discuss mailing list